Bug 108137

Summary: Switching layouts in kdesktop_lock doesn't work
Product: kdesktop Reporter: Omri Mezrich <omezrich>
Component: generalAssignee: Andriy Rysin <arysin>
Severity: normal CC: faure, finex, ossi
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Fix to lockdlg.cc - patched against latest 3.4 branch
Fix to lockdlg.h - patched against latest 3.4 branch

Description Omri Mezrich 2005-06-26 00:40:14 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-8ubuntu2) 
OS:                Linux

When clicking on the layout switcher in kdesktop_lock, it changes to "err".

From what I traced, the problem is in PasswordDlg::layoutClicked:

QStringList::iterator it = layoutsList.find( mLayoutButton->text() );
if( it == layoutsList.end() ) {  // huh?
    setLayoutText( "err" );

mLayoutButton->text() contains an ampersand due to KCheckAccelerators adding an accel key. (That's something I don't understand - every button on every dialog becomes automatically accelerated?)

anyway - patch attached which just keeps an iterator to the current layout in layoutsList.
Comment 1 Omri Mezrich 2005-06-26 00:42:21 UTC
Created attachment 11583 [details]
Fix to lockdlg.cc - patched against latest 3.4 branch
Comment 2 Omri Mezrich 2005-06-26 00:42:50 UTC
Created attachment 11584 [details]
Fix to lockdlg.h - patched against latest 3.4 branch
Comment 3 David Faure 2005-06-26 10:07:59 UTC
Andy Rysin: this seems to be your code. Or Ossi can have a look, maybe.
Comment 4 Andriy Rysin 2005-06-29 00:42:22 UTC
I really don't have a way to test it all, as I don't have an environment for
compiling and running this as I haven't been doing active KDE development for
more than a year now. I'll try to take a look at the code but without testing
not sure how useful it'd be.


--- David Faure <faure@kde.org> wrote:

[bugs.kde.org quoted mail]

Yahoo! Sports 
Rekindle the Rivalries. Sign up for Fantasy Football 
Comment 5 Oswald Buddenhagen 2005-07-09 22:11:05 UTC
i will have a look ...

*** This bug has been marked as a duplicate of 102149 ***
Comment 6 FiNeX 2009-01-02 20:31:04 UTC
Bug closed. Kdesktop is no more mantained.