Bug 102880

Summary:	[icq] line breaks broken (incoming and outgoing)
Product:	[Unmaintained] kopete	Reporter:	Stephen Chao <stephen>
Component:	ICQ and AIM Plugins	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mail, meyerm, michael.jahn, nbari, ojo, wstephenson
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	ICQ message receive - html extra step

Description Stephen Chao 2005-03-30 20:28:49 UTC

Version:           CVS (March 30, 2005) (using KDE KDE 3.4.0)
Installed from:    Slackware Packages
OS:                Linux

Outgoing messages in ICQ have line breaks replaced with <br />.  Incoming line breaks are not displayed.

Tested with ICQ & MSN.

Possibly related to old bug 59878.

Comment 1 Matt Rogers 2005-04-01 16:52:43 UTC

do you have a debug log?

Comment 2 Stephen Chao 2005-04-01 19:17:39 UTC

Not currently compiled with --enable-debug :(
Is it really necessary?  Or did you want a tcpdump?

I just found out about bug 102383 and bug 102333.  It seems sending msgs over icq do not need to be html'ized, while incoming (still) does.  Meaning 102333 still isn't fixed.  (Just tested now with a friend).

Comment 3 Matt Rogers 2005-04-02 23:47:32 UTC

ok, so there are really two problems here, is that correct?
The first problem being that we send icq messages html'ized and the second one being that we don't properly convert icq messages to html for display in the chat window?

Comment 4 Stephen Chao 2005-04-03 00:15:17 UTC

Created attachment 10492 [details]
ICQ message receive - html extra step

Correct -- 2 problems.	Or rather, the last patch I saw commited to cvs patched
the wrong one.	For myself, I've reverted the last patch in
/protocols/oscar/oscarcontact.cpp, and added this attachment.
Note that I've only changed type 1 messages.  Works as a nice temp patch for
me.

Comment 5 Olivier Goffart 2005-04-03 09:48:58 UTC

*** Bug 101103 has been marked as a duplicate of this bug. ***

Comment 6 Matt Rogers 2005-04-07 01:47:10 UTC

the patch is technically correct, but it's in the wrong place, and i don't want liboscar depending on kopete stuff more than it already does. escaping should be done in the kopete frontends to liboscar (*Account and *Contact)

Comment 7 Olivier Goffart 2005-04-09 18:21:26 UTC

*** Bug 103564 has been marked as a duplicate of this bug. ***

Comment 8 Will Stephenson 2005-04-13 09:26:56 UTC

*** Bug 103765 has been marked as a duplicate of this bug. ***

Comment 9 Olivier Goffart 2005-04-14 19:04:03 UTC

*** Bug 103865 has been marked as a duplicate of this bug. ***

Comment 10 Stephen Chao 2005-04-19 02:22:06 UTC

Just a suggestion:
Can we revert slotSendMsg in /protocols/oscar/oscarcontact.cpp back to when it was working properly?  Already people are incorrectly patching the breakage.  That way we can close this bug and reopen bug 102383 until a proper fix is out.

Comment 11 Stephen Chao 2005-05-05 01:47:03 UTC

Looks good as far as I can tell.  Thx!

Comment 12 Michael Jahn 2005-05-24 23:58:50 UTC

Not fixed in 3_4 branch. AFAICS revision 408739 needs to be backported :-) 
I asked in #kopete and I hope it is okay that I reopened this bug. 
And should bug 102383 be reopened (the commit was reverted, wasn't it?)

Comment 13 Stephen Chao 2005-06-16 01:54:55 UTC

Yeah, not sure what's up with the branches, but I just got KDE 3.4.1 ... not fixed.
Am I doomed to compile cvs forevermore?

Comment 14 Matt Rogers 2005-06-26 05:32:48 UTC

should be fixed in trunk.
(code for send message doesn't send escapedBody anymore. code for receive message uses Kopete::Message::escape similar to patch in this bug report)

Comment 15 Matt Rogers 2005-06-26 16:20:40 UTC

*** Bug 108163 has been marked as a duplicate of this bug. ***