Summary: | MusicBrainz isn't Tunepimp | ||
---|---|---|---|
Product: | [Applications] juk | Reporter: | Thiago Macieira <thiago> |
Component: | general | Assignee: | Scott Wheeler <wheeler> |
Status: | RESOLVED FIXED | ||
Severity: | minor | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Thiago Macieira
2005-03-05 19:53:33 UTC
It's true enough that the headers don't require one another, but the libraries do. The -lmusicbrainz in JuK isn't needed, but is pulled in by libtool anyway. (TunePimp is just an extra layer of abstraction on top of MusicBrainz for tagging applications.) At any rate -- I'll clean things up a bit, but the assumptions aren't *that* shakey. Then libtool will link libmusicbrainz, if necessary. Here, with --as-needed, it'll only be pulled at runtime. k3b and amarok have already adapted their configure scripts. Unfortunately, they did not write a shared test. Do you think you could "fix" that (with a cached result)? If not, I'll do it. CVS commit by wheeler: This really is about all the extent to which I care about configure checks. Until it doesn't work I don't really care to fix it further. (Don't explicitly pull libmusicbrainz.) Thiago, if you want to write a shared and better check and all that, well, have fun. ;-) BUG:100908 M +1 -1 Makefile.am 1.81 --- kdemultimedia/juk/Makefile.am #1.80:1.81 @@ -77,5 +77,5 @@ ################################################## if link_lib_MB -mblibs = -lmusicbrainz -ltunepimp +mblibs = -ltunepimp endif ################################################## |