juk's configure.in.in code contains this: KDE_CHECK_HEADER(tunepimp/tp_c.h, [ AC_DEFINE(HAVE_MUSICBRAINZ, 1, [have MusicBrainz]) have_musicbrainz=true ], [ AC_DEFINE(HAVE_MUSICBRAINZ, 0, [have MusicBrainz]) have_musicbrainz=false ]) AM_CONDITIONAL(link_lib_MB, test x$have_musicbrainz = xtrue) and in Makefile.am: if link_lib_MB mblibs = -lmusicbrainz -ltunepimp endif In other words, juk assumes that if you have libtunepimp, that you also have libmusicbrainz, which isn't necessarily true. The libraries are independent. And even if they weren't, the headers for one don't have to be installed if the headers for the other are found. k3b has copied juk's configure.in.in code, which in turn made it clash with amarok (both in kdeextragear-1). I recommend the following: 1) do not use #define HAVE_MUSICBRAINZ to be 0 if not found. Instead, let it be undefined 2) make separate tests for musicbrainz and tunepimp PS: I am told by someone in #amarok that juk doesn't need libmusicbrainz. Maybe you should investigate that. PPS: amarok bug #100906, k3b bug #100907
It's true enough that the headers don't require one another, but the libraries do. The -lmusicbrainz in JuK isn't needed, but is pulled in by libtool anyway. (TunePimp is just an extra layer of abstraction on top of MusicBrainz for tagging applications.) At any rate -- I'll clean things up a bit, but the assumptions aren't *that* shakey.
Then libtool will link libmusicbrainz, if necessary. Here, with --as-needed, it'll only be pulled at runtime. k3b and amarok have already adapted their configure scripts. Unfortunately, they did not write a shared test. Do you think you could "fix" that (with a cached result)? If not, I'll do it.
CVS commit by wheeler: This really is about all the extent to which I care about configure checks. Until it doesn't work I don't really care to fix it further. (Don't explicitly pull libmusicbrainz.) Thiago, if you want to write a shared and better check and all that, well, have fun. ;-) BUG:100908 M +1 -1 Makefile.am 1.81 --- kdemultimedia/juk/Makefile.am #1.80:1.81 @@ -77,5 +77,5 @@ ################################################## if link_lib_MB -mblibs = -lmusicbrainz -ltunepimp +mblibs = -ltunepimp endif ##################################################