Bug 100907 - MusicBrainz isn't Tunepimp: config.h definitions clashes with amarok's
Summary: MusicBrainz isn't Tunepimp: config.h definitions clashes with amarok's
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Sebastian Trueg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-05 19:47 UTC by Thiago Macieira
Modified: 2005-03-07 03:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Macieira 2005-03-05 19:47:40 UTC 
Hello, k3b assumes MusicBrainz is/contains libtunepimp, which isn't always  
true. The libraries are separate and independent.   
  
What's more, k3b's configure.in.in definitions clashes with those from amarok  
(since both live in kdeextragear-1). Please see Bug #100906 for more  
information on the clash.  
  
I'd recommend that k3b do the following: 
1) test for musicbrainz and tunepimp separately, defining a different HAVE_* 
for each 
2) not use #define HAVE_MUSICBRAINZ to be 0 in case it isn't found. Instead, 
simply let it be undefined. 
 
I know the configure.in.in checks are the same as juk's. I'm going to report 
the same minor bug to juk shortly.
Comment 1 Thiago Macieira 2005-03-05 19:54:28 UTC 
amarok bug #100906, juk bug #100908
Comment 2 Sebastian Trueg 2005-03-07 03:05:32 UTC 
CVS commit by trueg: 

BUGS: 100907

Added system check for generic devices.
Added warning if Joliet is not activated.
Fixed progress display for audio conversion.


  M +1 -0      ChangeLog   1.98
  M +1 -1      configure.in.bot   1.16
  M +26 -11    configure.in.in   1.69
  M +3 -2      src/Makefile.am   1.181
  M +14 -9     src/k3b.cpp   1.220
  M +415 -116  src/k3bemptydiscwaiter.cpp   1.22
  M +59 -31    src/k3bemptydiscwaiter.h   1.11
  M +2 -2      src/k3binteractiondialog.cpp   1.10
  M +7 -6      src/k3bjobprogressdialog.cpp   1.22
  M +5 -5      src/k3bjobprogressdialog.h   1.7
  M +27 -1     src/k3bsystemproblemdialog.cpp   1.37
  M +2 -2      src/k3btrm.cpp   1.4
  M +2 -2      src/k3btrm.h   1.3
  M +1 -1      src/ktrm.cpp   1.2
  M +1 -1      src/ktrm.h   1.2
  M +2 -2      src/projects/k3baudiotracktrmlookupdialog.cpp   1.4
  M +2 -2      src/projects/k3baudiotrackview.cpp   1.4
  M +3 -3      src/projects/k3baudioview.cpp   1.3
  M +6 -1      src/projects/k3bdataburndialog.cpp   1.3
  M +21 -1     src/projects/k3bdataimagesettingswidget.cpp   1.2
  M +4 -1      src/projects/k3bdataimagesettingswidget.h   1.2
  M +7 -1      src/projects/k3bdataview.cpp   1.3
  M +3 -1      src/projects/k3bdataview.h   1.2
  M +70 -40    src/rip/base_k3bcddbpatternwidget.ui   1.10
  M +2 -2      src/rip/k3baudiocdview.cpp   1.26
  M +2 -2      src/rip/k3baudioprojectconvertingdialog.cpp   1.2
  M +2 -2      src/rip/k3baudioprojectconvertingthread.cpp   1.2
  M +2 -2      src/rip/k3baudiorippingdialog.cpp   1.38
  M +23 -2     src/rip/k3baudioripthread.cpp   1.41
  M +2 -1      src/rip/k3bcddbpatternwidget.cpp   1.11