Bug 92471 - holiday plugin: make selecting multiple holiday sets possible
Summary: holiday plugin: make selecting multiple holiday sets possible
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: 3.3.1
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 131571 155217 207735 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-31 18:32 UTC by Wilbert Berendsen
Modified: 2018-06-03 17:00 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.9.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wilbert Berendsen 2004-10-31 18:32:23 UTC
Version:           3.3.1 (using KDE 3.3.1, compiled sources)
Compiler:          gcc version 3.3.4
OS:                Linux (i686) release 2.6.7

I created a holiday file with the Lutheran names of sundays in the Netherlands. I would like to be able to use it beside the official Dutch holiday file.

So it would be nice if I didn't have to select just one holiday file, but could select one or more of them.
Comment 1 Wilbert Berendsen 2004-10-31 18:33:59 UTC
I think this is related to, but not a duplicate of, bug #28583
Comment 2 Hamster 2005-01-16 01:42:12 UTC
It would also be useful in situations where you live in one country and work in another!
Comment 3 Rob Kaper 2005-04-01 12:13:30 UTC
Agreed, or simply when your job involves a lot of international clients/customers/contacts. I'd like to use Dutch holidays as default, but still want to see other dates (in my case mostly UK).
Comment 4 Paul MacDougall 2005-09-30 03:19:30 UTC
I've always wondered why you were limited to only one set.

Is there any way to kludge/hack a solution to this currently?
Comment 5 Reinhold Kainhofer 2006-11-02 18:53:45 UTC
Reassigning all KOrganizer bug reports and wishes to the newly created 
korganizer-devel mailing list.
Comment 6 Reinhold Kainhofer 2007-01-01 15:38:30 UTC
Report #131571 has the nice idea to add a flag to the corresponding holidays to indicate from which country they come.

Cheers,
Reinhold
Comment 7 Reinhold Kainhofer 2007-01-01 15:38:35 UTC
*** Bug 131571 has been marked as a duplicate of this bug. ***
Comment 8 Erik Anderson 2008-01-08 18:38:50 UTC
*** Bug 155217 has been marked as a duplicate of this bug. ***
Comment 9 Erik Anderson 2008-01-08 19:10:45 UTC
Wow, 3+ years for this.  Any progress?  Any clear roadmap, even?  

I live in the US.  I have clients in the UK and Japan.  I have friends in Germany.  My wife works at a Jewish school.  That's five lists of holidays I would like to be able to see simultaneously.  Outlook can do this, and has been able to for some time now.  KOrganizer Version 3.5.6 (enterprise 0.20070907.709405) still has this limitation.  Come on, guys, what's up?  

SUGGESTION: 
Mozilla has thoughtfully put together a page listing .ics calendar files that include various holidays, complete with localization info [http://www.mozilla.org/projects/calendar/holidays.html].  These can be easily imported into Sunbird, either locally after downloading or even remotely right from the URLs shown on the Mozilla page, and lo and behold, multiple holidays are shown.  Since KOrganizer is iCalendar-compliant, this *should* be easy enough to do for KOrganizer as well.  

(Unfortunately, the Mozilla .ics files seem to include options that prevent KOrganizer from using them as-is.  I'm trying to find out what exactly I need to do to get them to work.)
Comment 10 Erik Anderson 2008-01-08 19:29:57 UTC
CORRECTION:
Not sure what changed 'cause it wasn't anything I explicitly did (other than to load the files in Sunbird, not sure what that would change for KOrganizer?), but the Mozilla .ics files are now loading correctly in KOrganizer, as local files, local directories, or remote files (directly from the Mozilla URLs).  Yay!

SUGGESTION:
Just get rid of that danged "Settings -> Configure KOrganizer -> Time & Date -> Use holiday region" option!  It is precious close to useless, leads to endless confusion and disappointment if anyone wants multiple holiday regions at once, and is much more elegantly and simply replaced by using a set of (possibly read-only) holiday .ics files.  Users could then be given a checkbox list of holiday sets to choose from, allowing multiple choices, rather than the one-only limited dropbox setup in the current GUI configuration.  (The set of holiday .ics files should probably be included as an installation option, since some users are still on dial-up or metered internet usage, such as in Australia, and remote calendar files might not work well in such situations.)

Incidentally, this also nicely does away with the need for a specialized KOrganizer holiday plug-in file format, and further leverages an already established and widely used standard (iCal).  And it should be much easier to implement than reworking the whole holiday plug-in infrastructure.  :)
Comment 11 George Goldberg 2008-01-10 03:36:46 UTC
*** Bug 155217 has been marked as a duplicate of this bug. ***
Comment 12 Michael Grivas 2009-02-08 10:19:08 UTC
Is there any progress on this issue ?
As proposed by Reinhold in #28583, there is a solution to have anything you like.
I made a new file ~/.kde/share/apps/libkholiday/holiday_personal 
in which I copied all the calendars I wanted from /usr/share/apps/libkholidays,
namely the Greek, Spanish and Catalan. I simply did copy-paste one under the other, into the same (new) file.
Now I see all of them together. 

I understand that choosing more than is very helpful, especially if each could have a different colour or a flag on its side or whatever. Nevertheless, that trick covers the requirement and solved my problem. 

Erik, if I understand well, you propose two things: 
1) Multiple choice in the holidays list-box (although you describe it differently).
2) Use of iCal files instead of plan-like ones. 
Well, there is a way to use iCalendar files, right? 
If the developers things it's better this way (plan), it must be better.
Comment 13 Michael Grivas 2009-02-08 10:20:47 UTC
Oh, I forgot. The trick works in both 3.5.10 and 4.1.x versions of KDE (and korganizer respectively).
Actually, I have a link from one to the other, so they both see one single file.
Comment 14 John Layt 2010-05-29 02:34:38 UTC
*** Bug 207735 has been marked as a duplicate of this bug. ***
Comment 15 John Layt 2010-05-29 02:49:09 UTC
I had hoped to have this done in SC 4.5, but it will now be in SC 4.6.  If you want a preview of what I plan for it to look like, then have a look at the Plasma Digital Clock Settings for Time Zone.  In addition to the obvious from there, it will also list various metadata about the regions and holiday types, and allow you to choose which region(s) to use for marking days off, i.e. be able to display some regions for information only.

As I've mentioned elsewhere, we can't use .ics files as they are not flexible enough.
Comment 16 John Layt 2010-12-15 20:17:46 UTC
KHoliday in 4.6 offers a new HolidaySelector widget that allows for selecting multiple holiday regions to be displayed at once, but the backend work is still needed in KOrganizer to store and use multiple regions.  In 4.6 the plasma calendar will have multiple holiday regions enabled.
Comment 17 Allen Winter 2018-06-03 17:00:40 UTC
done for KOrganizer
will be available in the 5.9.0 release