Bug 28583 - Too many holidays: ~/.holiday please
Summary: Too many holidays: ~/.holiday please
Status: RESOLVED NOT A BUG
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: 2.2-beta
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 56549 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-07-09 21:48 UTC by jensen
Modified: 2010-05-29 01:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jensen 2001-07-09 21:33:13 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           korganizer
Version:           2.2beta1 (using KDE 2.2.0 beta1)
Severity:          wishlist
Installed from:    compiled sources
Compiler:          gcc version 2.95.3 20010315 (SuSE)
OS:                Linux (i686) release 2.4.4-4GB
OS/Compiler notes: 

I know how to select the holiday scheme in Settings
(the blank entry should probably read "none").
I see the change takes effect after a restart.

The problem is that the US holiday list includes a
lot of frivolous holidays ("World Poetry Day"??)
that I would like to remove.

It would be nice to have the option of a personalized holiday list.

(Submitted via bugs.kde.org)
(Called from KBugReport dialog)
Comment 1 Reinhold Kainhofer 2004-01-19 12:48:01 UTC
*** Bug 56549 has been marked as a duplicate of this bug. ***
Comment 2 M G Berberich 2004-12-19 17:01:22 UTC
You can create a personal holiday file at 

~/.kde/share/apps/korganizer/holiday_personal

by hand if you like
Comment 3 EC 2006-10-15 23:55:04 UTC
I have experimented creating a file with name 

 ~/.kde/share/apps/korganizer/holiday_personal

however says nothing about the syntax to be used 
to be used in this file. 

I tried one witg single line, using the syntax for 
holiday files, but xorganizer failed to display it. 
For example I copied this line from the holiday 
syntax example somewhere at kde.org 

small  "Surprise"  blue  on  last  sunday  in  october plus  1  day

Am I missing something? Is this file supposed to be
processed before being used? What should one choose
in the configuration menu for holidays?
Or perhaps "holiday_personal" is supposed 
to be a directory, containing files?

In general I would say that this topic needs further
documentation.  Thanks.
Comment 4 Reinhold Kainhofer 2006-10-16 15:09:50 UTC
Am Sonntag, 15. Oktober 2006 23:55 schrieb EC:
> I have experimented creating a file with name
>
>  ~/.kde/share/apps/korganizer/holiday_personal


Actually, that path is wrong. It should be
     ~/.kde/share/apps/libkholiday/holiday_something
(where something can really be anything you like. That string after holiday_ 
will be displayed in korganizer's selection box in the config dialog).

E.g. I copied to /usr/share/apps/libkholidays/holiday_at to 
/home/reinhold/.kde/share/apps/libkholidays/holiday_Reinhold, so that 
KOrganizer now also offers a holiday region named "Reinhold" in the config 
dialog.

> however says nothing about the syntax to be used
> to be used in this file.


See
http://pim.kde.org/components/korganizer/holidays.php

If you want, you can even include already existing holiday files into your own 
holiday file, so you can extend the official holidays with your own.

Cheers,
Reinhold
Comment 5 Reinhold Kainhofer 2006-11-02 19:29:36 UTC
Reassigning all KOrganizer bug reports and wishes to the newly created 
korganizer-devel mailing list.
Comment 6 Erik Anderson 2008-01-08 19:33:03 UTC
Why not use .ics files for holidays instead?  (c.f. suggestion shown for Bug 92471)
Comment 7 Michael Grivas 2009-02-08 10:02:56 UTC
Thank you, Reinhold, for your suggestion. 
It works just fine in both KDE 3.5.10 and 4.1.x .
Actually, I made a link from .kde4/... to .kde/..., so both see the same file.
That covers (not solves) the need for multiple calendars as in 
http://bugs.kde.org/show_bug.cgi?id=92471

Erik, I don't understand why ical would be any better. After all, you can import iCalendar, isn't it the same ? 
Comment 8 Erik Anderson 2009-02-08 11:00:22 UTC
(In reply to comment #7)
> Thank you, Reinhold, for your suggestion. 
> It works just fine in both KDE 3.5.10 and 4.1.x .
> Actually, I made a link from .kde4/... to .kde/..., so both see the same file.
> That covers (not solves) the need for multiple calendars as in 
> http://bugs.kde.org/show_bug.cgi?id=92471
> 
> Erik, I don't understand why ical would be any better. After all, you can
> import iCalendar, isn't it the same ? 
> 

Hello Michael --

I see you later commented over in the Bug 92471 report.  As noted there, my suggestion about .ics files was prompted by:

* my need to have more than one holiday 'region' shown at once (described in more detail in the Bug 92471 thread), whereas Korganizer only allows (allowed?) one and only one 'region';
* confusion as to why Korganizer needs a whole new format to describe holidays when .ics already does the job;
* and a desire for simplicity and better interoperability by using the already widely employed .ics format.


> After all, you can import iCalendar, isn't it the same?

While functionally offering the same end result, it's terribly confusing to have a "Holiday" setting in the Korganizer GUI that is limited to only one 'region'; and even should the holiday files be expandable to include more than one 'region', it's also terribly confusing to have to learn a completely new file format simply to define holidays that may already be fully described in existing and downloadable .ics files.  

My suggestion was made primarily for simplicity's sake -- Korganizer's holiday file format is not so widely known, requires more work of the end user to add to, is more confusing than .ics (IMHO), and increases the code and GUI complexity and reduces the usability of the UI -- all to duplicate functionality that already exists (i.e., import .ics files defining the holidays you want).  The whole holiday 'region' code could be entirely removed from Korganizer, streamlining the codebase and simplifying the UI, and most of us wouldn't miss it -- and those that did could achieve the same result using .ics files.  

I guess I'm just confused as to why we need all of this separate functionality for holidays.  

There's my $0.02.  :)  YMMV.  

Cheers,

-- Erik Anderson
Comment 9 John Layt 2010-05-29 01:57:41 UTC
Closing as it appears to me this bug is long-since resolved, i.e. the op requested being able to have a personal holiday file and was shown how to do this.

As to why we have our own file format rather than .ics, the iCalendar standard is too restricted and doesn't cope with many of the more complex holiday recursion rules, especially around substitute days.  It also doesn't support calendar systems other than Gregorian, i.e. we need to be able to calculate Islamic and Jewish calendar dates as well.  Eventually we will have a new XML based file format which we will propose as a new standard with shared data files between many projects, but that's still a while off.

KHolidays is now back under active development.  I had hoped to have the ability to select multiple holiday regions available in SC 4.5 but ran out of time so it will be in 4.6, but that's a separate bug/wish.