Bug 88477 - Clear playlist when file is dropped on player-window (not playlist-window)
Summary: Clear playlist when file is dropped on player-window (not playlist-window)
Status: RESOLVED UNMAINTAINED
Alias: None
Product: noatun
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Charles Samuels
URL:
Keywords:
: 110413 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-30 23:26 UTC by Johan Billing
Modified: 2012-07-02 16:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Billing 2004-08-30 23:26:21 UTC
Version:            (using KDE KDE 3.3.0)
Installed from:    Gentoo Packages

As an old XMMS users, I feel that it is counter-intuitive that a file is added to the end of the playlist when it is dropped on a player window. Instead, I think that Noatun should clear the playlist and play the first of the dropped files immediately. This is also how Kaboodle behaves. If a file is dropped on the playlist, it should of course still be added to the playlist. 

Or maybe there could be a configuration option for this? 

"Clear playlist when file is dropped on player"
Comment 1 Charles Samuels 2004-08-31 07:25:37 UTC
maybe a configuration option, but I say "on my dead body" when it comes to being default :)

I just don't like the idea of making data loss (loss of the playlist) so easy.

I think we should consider two things here:
 1) the split playlist sucks
 2) the split playlist has no configuration page, and it's kinda lame to have just one option in it :)

so on those conditions, maybe Stefan Gehn would like to make his Flex playlist the default for noatun, and we trash SPL. Then you could make a patch against Flex :)

Comment 2 Johan Billing 2004-08-31 21:48:00 UTC
After thinking about this some more and looking a bit at the source, I 
think what I really want is for drag&drop to be equivalent to File/Open.

To use the winskin plugin as an example, I feel that this:

void WaSkin::dropEvent(QDropEvent * event)
{
     KURL::List uri;
     if (KURLDrag::decode(event, uri))
     {
         for (KURL::List::Iterator i = uri.begin(); i != uri.end(); ++i)
             napp->player()->openFile(*i, false);
     }
}

should be changed to this:

void WaSkin::dropEvent(QDropEvent * event)
{
     KURL::List uri;
     if (KURLDrag::decode(event, uri))
     {
         napp->player()->openFile(uri, napp->clearOnOpen(), true);
     }
}

This is also more in line with how most other KDE apps work (Kaboodle, 
Konqueror, KView, Kwrite etc). The KDE User Interface Guidelines don't 
seem to contain anything about this though, drag&drop is only discussed in
the context of moving things around such as files in konqueror or mails 
between folders.

Comment 3 Stefan Gehn 2004-08-31 22:03:38 UTC
since when does dropping a file have to clear the whole playlist?

> so on those conditions, maybe Stefan Gehn would like to make his Flex
> playlist the default for noatun, and we trash SPL. Then you could make a
> patch against Flex :) 

No because:
- flexplaylist dropped the checkbox selection for items, replacing splitplaylist with flexplaylist would mean loosing one (probably) important feature (which I really don't want in my own playlist, that's why I removed it in FPL)
- I want my own release schedule, the KDE schedules are really not my cup of tea
- I generally don't feel well with having my code in KDE since the community I once liked is not there anymore

Of course I can make drag-n-drop optionally clear the playlist in FPL, I won't, however, make FPL a part of what KDE ships with.
Comment 4 Charles Samuels 2004-09-01 02:44:27 UTC
Johan,

I find your comparison to Kaboodle and all a bit specious, all of these programs treat the media file as the document, whereas noatun treats the playlist itself as the document.  For example, adding a file to Kate doesn't empty the filelist, but adds the document to it.

For a more contrived example, Konqueror doesn't empty a directory when you drop a file on it. :)

I think a reasonable change would be for the playlist to play the dropped file immediately (subject to a configuration option!), but never clear the playlist.

thanks,

charles
Comment 5 Johan Billing 2004-09-05 12:04:36 UTC
On the order hand, when you drop a file on Kate it doesn't insert it at the end of the current document either. :-)

But this is just a minor issue, and I am sure that I will get used to Noatun's behaviour eventually, so I will shut up about this now. :-)
Comment 6 Stefan Gehn 2004-10-20 18:45:23 UTC
Marking as WONTFIX because it very much looks like this would be ill-logic (drag-n-drop never clears the list you dropped something on).
Comment 7 Hackeron 2005-01-12 22:47:45 UTC
> Marking as WONTFIX because it very much looks like this would be ill-logic (drag-n-drop never clears the list you dropped something on). 

Ofcourse, if you drop into the list (playlist), then fine, let it be added. If you drop into the interface, it should replace the playlist.

Try this in xmms or in kaffeine. If you drop into the playlist, files are added, if not then playlist is replaced. Otherwise to play a file you need to drop it in the interface, go to playlist, remove previous file, click on new file. Thats insane.
Comment 8 Stefan Gehn 2005-01-12 23:21:21 UTC
Ahh, now after rereading all this I think it start making sense. That would also make the behaviour of dragndrop and passing files on the commandline equal.
I'll consider this for KDE 4.0 as KDE 3.4 is almost out of the door and no new KDE 3.x release is planned.
Comment 9 Charles Samuels 2005-01-12 23:31:58 UTC
Hackeron,

It's also insane to empty the playlist.  That's data loss, one of two "critical" bugs along with security holes.  Noatun is not xmms or kaffeine, the two programs are used very differently, so if you want something like that, just use Kaboodle as it would behave as you want.

Please realise that one of the first things I did when first starting work on Noatun was not doing that "empty the playlist all the time" thing, like XMMS.  It was one of noatun's raison d'être, if you will.

that said, as long as it's not the default behaviour, I don't really care, but I do not want to provide the user with a potentially dangerous feature without the user knowing that it will happen.

thanks
Comment 10 Stefan Gehn 2005-01-13 15:36:23 UTC
I see no problem with making drops on mainwindow behave like files passed on commandline. We have an option for the second one so why not use it for both?
Comment 11 Stefan Gehn 2005-09-27 15:16:39 UTC
*** Bug 110413 has been marked as a duplicate of this bug. ***
Comment 12 Christoph Feck 2012-07-02 16:29:20 UTC
noatun has not been part of the KDE 4 release and is no longer maintained.

KDE now offers Dragon as a video player and JuK as a music player. Additionally, other popular KDE players have been ported to KDE 4, such as Amarok or Kaffeine.

If this issue is still applicable to KDE 4 applications, please add a comment or file a new report.

For more information, see http://websvn.kde.org/?view=revision&revision=718046