Bug 87722 - docked gnome applications expands system tray
Summary: docked gnome applications expands system tray
Status: RESOLVED FIXED
Alias: None
Product: kicker
Classification: Plasma
Component: systemtray (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: VHI normal
Target Milestone: ---
Assignee: Aaron J. Seigo
URL:
Keywords:
: 87575 87578 87725 88354 89405 91159 93220 105321 108921 109119 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-22 01:37 UTC by Heiko Liebfried
Modified: 2020-05-04 03:23 UTC (History)
15 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Arbitrarily expanded system tray with ed2k-gtk (27.37 KB, image/png)
2004-08-22 01:53 UTC, Heiko Liebfried
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Liebfried 2004-08-22 01:37:55 UTC
Version:            (using KDE KDE 3.3.0)
Installed from:    Gentoo Packages
Compiler:          gcc-Version 3.3.4 20040623 (Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6) 
OS:                Linux

Problem:
When i dock ed2k_gui system tray behaves strangely.
After some time the system tray expands about 4-6 of it's normal (needed) size
although there is no reason for this.
Kicker reacts as expected and expands to give system tray more space.
In kde 3.2.3 (3.2.2) this never happened.


Docked applications:
KAMix - SuSE Sound mixer application (self compiled)
Klipper
Korganizer
Kalarm
Kget
Knotes
Knemo - Networking Tool http://www.kde-apps.org/content/show.php?content=12956
Kwalletmanager

! And ed2k-gtk-gui (vers. 0.6.2 - Gtk gui application for overnet (the problematic app) !

Kicker Position and settings:
My Kicker Position is bottom.
Height - Big
Length - auto expanding (starting with 1%)
Kicker orientation - middle
Kicker background Picture - no
Transparency - no 
 
How to reproduce:
Start ed2k_gui and dock it to system tray.
Click the docked icons a few times.
Wait ...
The bug occurs after a short while in irregular 
time periods.


Alas i don't have more gnome/gtk apps installed, because 
kde has 99.5% i need :)

I tried to dock gtk-demo with ksystraycmd but it worked flawlessly.

Perhaps other users could try other gtk apps, if this is a bug 
of kickers system tray to dock gtk-apps (without ksystraycmd).

I will attach a picture of system tray with the bug.
Comment 1 Heiko Liebfried 2004-08-22 01:39:58 UTC
I forget:
When system tray is expanded (bug occured) and i close ed2k-gtk, it resizes to it's normal size again !
Comment 2 Heiko Liebfried 2004-08-22 01:53:24 UTC
Created attachment 7214 [details]
Arbitrarily expanded system tray with ed2k-gtk

Here you can see the bug in action. 
Notice that the right system tray handle isn't visible although i checked the
checkbox to show them all the time.
Comment 3 Aaron J. Seigo 2004-08-22 14:30:36 UTC
this would be because the gtk icon is misreporting its width. we now take into consideration that an icon may be wider than 22px and resize accordingly to avoid clipping. but if the icon misreports it's width, there's nothing i can really do about it. this is made worse by the fact that the current systray implementation uses a single (max) width for all columns. i'll fix that bit today, but you'll still have at least one column that is too wide and there is likely to be nothing i can do about it since the real bug lies elsewhere.
Comment 4 Heiko Liebfried 2004-08-22 14:42:09 UTC
Wow a very fast reply !
Only one column too wide would keep kicker usable.The clock and other areas wouldn't dissapear anymore.
Thank you very much for fast reply and help :)
Comment 5 Maksim Orlovich 2004-08-22 17:37:04 UTC
*** Bug 87575 has been marked as a duplicate of this bug. ***
Comment 6 Maksim Orlovich 2004-08-22 17:38:24 UTC
*** Bug 87578 has been marked as a duplicate of this bug. ***
Comment 7 Maksim Orlovich 2004-08-22 17:38:49 UTC
Reported as a problem with wine apps, too
Comment 8 Maksim Orlovich 2004-08-22 17:40:56 UTC
*** Bug 87725 has been marked as a duplicate of this bug. ***
Comment 9 Lubos Lunak 2004-08-23 14:39:38 UTC
I think the fd.o systray spec expects the tray to resize the icons as it wants: http://freedesktop.org/Standards/systemtray-spec/systemtray-spec-0.1.html#docking
Last sentence in the section. It's not clearly stated though.
Comment 10 Maksim Orlovich 2004-08-29 16:37:41 UTC
*** Bug 88354 has been marked as a duplicate of this bug. ***
Comment 11 Tim-Philipp M 2004-09-08 15:44:25 UTC
The ed2k_gui "icon" is not misreporting its width. 

It's more than an icon actually, it's an icon, a label, another icon, and another label (all packed horizontally), but the KDE system tray only ever shows the icon at the left. 

See

  http://bugs.kde.org/show_bug.cgi?id=65712

for details (if you don't have Gtk+ installed, look at the two .png images to see the problem). 

Cheers
 -Tim
Comment 12 Aaron J. Seigo 2004-09-08 23:40:52 UTC
are these all children of a single window? e.g. is the Xembed'd window the parent of all these, correctly reporting it's width, and displaying all the children accurately?

and talk about your total abuse of the system tray =(
Comment 13 Tim-Philipp M 2004-09-08 23:58:02 UTC
> are these all children of a single window? e.g. is the Xembed'd 
> window the parent of all these, correctly reporting it's width, 
> and displaying all the children accurately?

I'm not familiar with the Xlib side of things, nor did I write 
the tray icon implementation (EggTrayIcon), so I can only really 
guess and say "yes", given that I stick to stock GtkBin/GtkContainer/GtkBox
methods, EggTrayIcon is derived from GtkPlug, and GtkPlug is derived from GtkWindow, and and  don't do anything fancy. 

There's a test program attached to the other bug I pointed out 
above, so it should be easy for more knowledgeable people than 
me to find out, I hope.

 
> and talk about your total abuse of the system tray =( 

Does it say that this is not allowed in the specs anywhere? 

(And even if it wasn't allowed, it must surely be desirable
to catch this and deal with it more elegantly, no?).

Most other system trays I am aware of deal with this case
perfectly well. The only one that doesn't that I'm aware
of is the KDE one (sorry, if I'm getting repetitive ;-).

Cheers 
-Tim
Comment 14 Aaron J. Seigo 2004-09-14 21:48:01 UTC
*** Bug 89405 has been marked as a duplicate of this bug. ***
Comment 15 Lubos Lunak 2004-10-12 10:50:09 UTC
*** Bug 91159 has been marked as a duplicate of this bug. ***
Comment 16 Lubos Lunak 2004-11-15 13:17:20 UTC
*** Bug 93220 has been marked as a duplicate of this bug. ***
Comment 17 Jason W 2004-11-28 07:40:40 UTC
windows apps runthrough wine tend to cause this as well.  It would definitely be nice to have the wideness limited to one column, but I can't help thinking the old behaviour would still be preferable.

I have never experienced clipping caused by an icon that is larger than 22 pixels, but I and plenty others have the problem with tray columns being too wide.  Even if clipping is (contrary to my experience) very widespread, in my opinion occasional clipping is aesthetically preferable to large amounts of whitespace around random icons.

Nonetheless, I'll be looking forward to any fix you produce
Comment 18 Aaron J. Seigo 2005-03-08 04:53:33 UTC
> I have never experienced clipping caused by an icon that is larger than 22
> pixels

the change to not assume 22px was specifically to take into consideration systray entries that aren't 22x22 and were getting clipped. it was another popular bug.
Comment 19 alancio 2005-03-30 13:13:38 UTC
This bug is still present in KDE 3.4.0.

It seems really easy to fix, it has many votes to get fixed and it would make KDE look much better and more usable IMHO.
Comment 20 Aaron J. Seigo 2005-03-30 16:55:32 UTC
> It seems really easy to fix

so easy, in fact, that we still don't have a patch from anyone ;) fixing this means completely rewriting how the systray lays out the icons and the problem appears due to buggy systray apps. despite 6 people voting for it, and there being about as many duplicate bugs, this makes it a "i'll get to eventually" type bug.

having a patch in hand would help speed that up, of course.
Comment 21 Peter Thomassen 2005-03-30 23:37:38 UTC
Are you sure this is caused by malpractice of the systray apps? --> Comment #11.

Maybe an option would be useful, to specify if only the first, actual icon or the whole area requested by the systray app is shown (widths of the columns are fixed or variable, resp.).
Comment 22 Aaron J. Seigo 2005-06-27 17:57:28 UTC
*** Bug 105321 has been marked as a duplicate of this bug. ***
Comment 23 Aaron J. Seigo 2005-07-11 19:34:47 UTC
*** Bug 108921 has been marked as a duplicate of this bug. ***
Comment 24 Aaron J. Seigo 2005-07-15 07:52:56 UTC
*** Bug 109119 has been marked as a duplicate of this bug. ***
Comment 25 Aaron J. Seigo 2006-03-17 02:56:05 UTC
SVN commit 519397 by aseigo:

switch this to using a qt layout; helps minimize the "omg, one of the
systray icons is too wide!" bug by ensuring only the column with the
wider icon is bigger, not all columns. simplifies the code a bit, too
CCBUGS:123380,87722


 M  +74 -106   systemtrayapplet.cpp  
 M  +2 -0      systemtrayapplet.h