Bug 81770 - Please implement rounded file selection
Summary: Please implement rounded file selection
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kstyle (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Karol Szwed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-17 23:13 UTC by Davide Ferrari
Modified: 2006-12-28 16:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to implement rounded corners (4.14 KB, patch)
2004-06-06 20:59 UTC, James Ots
Details
A Faster patch for rounded selections (4.30 KB, patch)
2004-06-09 19:01 UTC, James Ots
Details
A patch for rounded selections on the desktop (5.46 KB, patch)
2004-06-09 19:03 UTC, James Ots
Details
snapshot18.png (67.70 KB, image/png)
2004-06-10 11:06 UTC, Stephan Kulow
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Ferrari 2004-05-17 23:13:27 UTC
Version:            (using KDE KDE 3.2.2)
Installed from:    Gentoo Packages

KDE and Konqueror are getting every day more powerful and even more eye-candy, but there's a thing that still suffer respect to other DE: the ugly file selection. I think that something more beautiful should be implemented, and I saw that what I want is already implemented in a KDE program, Album Shaper. Here it's the link on kde-apps

http://www.kde-apps.org/content/show.php?content=9929&forummode=2&forumpage=0&forumexplevel=0&forumthread=53020#c53050

with a pretty short dialog of the author and me.
and this is a direct screenshot, to see what I mean with rounded selection

http://www.kde-apps.org/content/pre2/9929-2.jpg

Since the code is almost already there, please implement it, if you want! :)
Comment 1 James Ots 2004-06-06 20:59:28 UTC
Created attachment 6265 [details]
Patch to implement rounded corners

Ok, here's a patch to do what you were asking for. I basically ripped the code
straight out of albumshaper, which is GPL so that should be ok.

It doesn't do rounded corners on the desktop though, because it currently
blends a single background colour with the selection colour, and I couldn't be
bothered to make it blend with an image. I wrote a patch for
kfileividesktop.cpp which did the same thing, but it doesn't look right on an
image background, so I haven't included it here. I could write a more complex
version if it's wanted and I have the time.
Comment 2 Davide Ferrari 2004-06-06 23:32:02 UTC
You were really kind, thanks! If you can work more on this issue, implementing it even on image backgrounds, it would be really perfect! And please commit it to the official KDE devel branch, I hope it would be accepted...anyway, thanks again, you rock!
Comment 3 James Ots 2004-06-09 19:01:57 UTC
Created attachment 6287 [details]
A Faster patch for rounded selections

This is a much faster rounded corner drawing method.
Comment 4 James Ots 2004-06-09 19:03:31 UTC
Created attachment 6288 [details]
A patch for rounded selections on the desktop

This has the same effect as the other patch, but it works on the desktop
properly when there's an image behind.

It's not very nice code, but does seem to work.
Comment 5 Leo Savernik 2004-06-09 22:09:34 UTC
The example looks awful. Would you please attach a screenshot of how this new file selector should look like (but only a small one (max. 640x480), not at 1920x1600)?
Comment 6 Sebastien 2004-06-09 22:31:01 UTC
Very cool to have it implemented !!!!!

I've used a few GNOME and it has it by default.
It's so beautifull and slick !

A chance to have it integrated to KDE 3.3 ?

Another question : is it possible to also have a beautifull region selection (click on an empty place and drag to draw a rectangle that select a lot of icons) ?

As the GNOME (or Windows xp) one : solid rectangle (selection color : typically blue) and semi-transparent filled (half-blue) ?
It's eye candy (so, important for adoption of Linux/KDE by "the masse") BUT also an usability issue : we see better what is selected.
Comment 7 Stephan Kulow 2004-06-10 11:06:14 UTC
Am Mittwoch 09 Juni 2004 19:03 schrieb James Ots:
> It's not very nice code, but does seem to work.
The drawing of the focus is incorrect on some items. I attach a screen shot.

Otherwise I like the look and I think it should be in 3.3

Greetings, Stephan


Created an attachment (id=6293)
snapshot18.png
Comment 8 James Ots 2004-06-10 16:33:05 UTC
Sebastien: See Bug 47633 for the region selection stuff.

Since people seem to like it, I'll work a bit harder on it and iron out any faults. See y'all in a few days :-)
Comment 9 James Ots 2004-06-10 16:53:51 UTC
Actually, that dodgy looking dotted box is happening in 3.2.2 without my rounded corner code. I'll have a look at it though and see if I can fix that too, since my head is full of that code at the moment.
Comment 10 James Ots 2004-06-10 19:46:12 UTC
The FocusRect painting appears to be a bug in QT - I created a QIconView and it exhibits the same behaviour. It is now Bug 83167.
Comment 11 Sashmit Bhaduri 2004-06-11 19:49:22 UTC
Erm, wouldn't it be better for styles to be able to handle this (e.g, implement this in kstyle as well)
Comment 12 Davide Ferrari 2004-08-16 12:48:45 UTC
James, any news about this topic?
Comment 13 Davide Ferrari 2006-12-28 16:12:48 UTC
Well, there are patches applied by distro (i.e. Ubuntu, Suse) and KDE is going the 4 way. Closing this wish, even if it's not resolved upstream.