Bug 47633 - Drag and drop looks ugly the selection too
Summary: Drag and drop looks ugly the selection too
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: RedHat Enterprise Linux Linux
: LO wishlist
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
: 40567 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-09-08 21:48 UTC by vlindos
Modified: 2008-11-16 20:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bugzilla Maintainers 2002-09-08 21:39:51 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           kwin
Version:           KDE 3.0.0 
Severity:          wishlist
Installed from:    RedHat RPMs
Compiler:          Not Specified
OS:                Linux
OS/Compiler notes: Not Specified

I've wonder when there will be nautilus like selection and more beaty drag and drop current looks very ugly

(Submitted via bugs.kde.org)
Comment 1 Stephan Binner 2002-09-13 11:34:28 UTC
What is "Nautilus like selection"? 
Comment 2 Jesse 2002-09-14 01:45:20 UTC
I believe he means the way in which nautilus draws the selection rectangle.  
With nautilus, WinXP, and Mac (I think), the area being selected is actually a 
transparent, colored-filled rectangle.  KDE just has a dashed-line, unfilled 
rectangle.  The effect is quite nice actually.  The color of the rectangle is 
not completely flat though if i remember correctly.  It has slight highlights 
on the edges to give it a polished, 3D look to it.
Comment 3 Maksim Orlovich 2002-09-14 02:22:51 UTC
AFAIK, this is currently difficult without some nasty hacking due to the way            QIconView handles selection. The relevant code is the following, both for          erasing and drawing:                        p.begin( viewport() );              p.setRasterOp( NotROP );              p.setPen( QPen( color0, 1 ) );              p.setBrush( NoBrush );              drawRubber( &p );              d->dragging = TRUE;                        p.end();                              The NotROP basically means that the black pixels drawn invert the selection.          this is called first  to remove the old rectangle and then to draw the new        one.                 drawRubber *is* virtual,  but to implement it access to the private       d->rubber is required; and I don't see an accessor. The default implementation      calls drawPrimitive with PE_FocusRect for the current style, so a custom      implementation can be put in place without much hacking (basically by looking  for the NotROP). However, this  requires some nasty hacking, as far as I can  see, to keep track of the state of the blended-in rectangle without having the  benefit of access to the widget's   data structures describing things like the scrolling going on, if any (It's easy in  the non-scrolled case) it. Everyone should feel free to prove me wrong however ;-). Of course, KIconView can probably reimplement the selection drag entirely, but that's probably extremely complicated.                          P.S.: It'd be quite appreciated if users didn't change the assignments            incorrectly after they've been adjusted by a developer. KWin has absolutely  nothing to do with this.    
Comment 4 Jesse 2004-01-03 04:32:18 UTC
A long time ago I made an accidental change to the bug by reassigning to kwin -- I'm guessing it still has nothing to do with this (??)  sorry :-/

But anyhow, now that some time has passed, is the drawing of the selection rectangle (and the corresponding painting of the icons) still too complex to accomplish this?   Perhaps it's not too late to influence the development of the next QT version as well.
Comment 5 aviv bergman 2004-02-08 20:48:24 UTC
Subject: Re:

see
http://lists.kde.org/?l=kde-devel&m=107623938426476&w=2
for a patch

Comment 6 Jesse 2004-05-22 23:01:49 UTC
*** Bug 40567 has been marked as a duplicate of this bug. ***
Comment 7 Anders Storsveen 2005-10-19 16:12:02 UTC
*** This bug has been confirmed by popular vote. ***
Comment 8 FiNeX 2008-11-16 20:31:31 UTC
The selection (rubberband) has been implemented some time ago. It is available on both KDE3 and KDE4. About drag n' drop, if you don't like how are implemented on KDE4, please report it against plasma product.

Thanks!