Bug 56611 - Date picker should honor the work days setting
Summary: Date picker should honor the work days setting
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: 3.2-beta
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Cornelius Schumacher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-30 06:54 UTC by Hans
Modified: 2004-03-30 20:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hans 2003-03-30 06:54:50 UTC
Version:           3.1 (using KDE 3.1.0)
Installed from:    SuSE
Compiler:          gcc version 2.95.3 20010315 (SuSE)
OS:          Linux (i686) release 2.4.4-4GB

The icon "Work Week" stays the same no matter which day you select as first day of the week. The blue mark should start at the leftmost square if Monday is the first working day and the start of the week.

It could be a better (and easier) solution to use a completely different icon (a person sitting in an office for example).
Comment 1 Michael Brennan Sayer 2003-12-02 08:08:40 UTC
Using KDE 3.1.4

Start of working week

I live in the UAE and my working week starts on Saturday through to Wednesday 
(Thursday Friday off).  I've notice that even though I state that my week 
starts on Saturday the week view always shows Monday to Friday.

However the 7 day view does show Saturday as the start of the 7 day week.

The working week is important especially in the Middle East.  They have two versions of a working week.  For the Government it and local companies it's Sat>Weds (Thursday/Friday off) and for international companies it tendsto be Sun>Thurs (Friday/Saturday off)
Comment 2 groot 2003-12-02 11:26:06 UTC
Confirmed in HEAD from 1-12-2003 as well; although the widget displays friday in red as day of prayer (or whatever the red is supposed to mean, as it's applied to sundays in gregorian calendars) the work week highlights monday - friday.
Comment 3 Reinhold Kainhofer 2003-12-02 14:32:57 UTC
Subject: Re:  Date picker should honor the system-wide week start setting

That's true. The day of prayer is done correctly, but the week start setting 
is not used. Also, the work week is not so easy to determine.

For more background (but no real conclusions or anything), see the thread on 
kde-pim:

http://lists.kde.org/?l=kde-pim&m=106304391916816&w=2
http://lists.kde.org/?l=kde-pim&m=106310892412264&w=2

I tried to "fix" that behaviour some time ago, but then found it might not be 
so straight-forward (in particular the work week).

Reinhold

Comment 4 Reinhold Kainhofer 2003-12-02 14:37:09 UTC
Also, please not that the original bug report was just about the toolbar icon, while the later comments are actually about the date picker. The toolbar icon won't be changed for sure, but the date picker is a real bug.

Reinhold
Comment 5 Levy, Chen 2004-03-02 18:15:05 UTC
Bug#50515: "marking Saturday as vacation day" (wishlist), may be related to this discussion. It is obviously not a duplicate because this bug is about the toolbar icon.
Comment 6 Reinhold Kainhofer 2004-03-30 20:02:57 UTC
CVS commit by kainhofe: 

Finally, korganizer supports overnight working hours, and allows the user to select which days are working days (using seven check boxes, one for each day of the week).

A few words concerning night shift:
For overnight working hours, I use the day when the shift starts to determine if the shift is on a holiday, and thus shouldn't be drawn as work shift. As an example: If you have working hours Mon-Fri from 20:00 - 05:00, then you'll see the following shifts:
Mon 20:00 - Tue 05:00
Tue 20:00 - Wed 05:00
...
Fri 20:00 - Sat 05:00

But NOT Sat 20:00-Sun05:00 and also not Sun 20:00 - Mon 05:00 (because in these cases the shift starts on a day that is not a working day). The same applies to holidays: If the tuesday is a holiday, the shift from tuesday evening to wednesday morning will not be shown. I hope this is the expected behavior...

CCMAIL: 70053-done@bugs.kde.org, 56611-done@bugs.kde.org


  M +24 -16    koagenda.cpp   1.106
  M +19 -13    koagendaview.cpp   1.133
  M +30 -7     koprefsdialog.cpp   1.93
  M +3 -4      korganizer.kcfg   1.14