Bug 50515 - marking Saturday as vacation day
Summary: marking Saturday as vacation day
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: klocale (show other bugs)
Version: 3.0.2
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: John Layt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-11-10 13:24 UTC by ifinci
Modified: 2009-06-03 15:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ifinci 2002-11-10 13:24:36 UTC
Version:           3.0.2 (using KDE 3.0.2)
Installed from:    SuSE
Compiler:          gcc version 2.95.2 19991024 (release)
OS:          Linux (i686) release 2.4.18

Even in I select that week starts on Sunday, Sunday stays written in Red (in the calander view), and not Saturday as one whould expect (since this is the day of the weekend when week starts on Sunday).

If this is not the meaning of "week starts on Sunday", then there should be an option to specify that Saturday is the day of the weekend and not Sunday (which is a regular working day here in Israel for example).

Thanks,
Ilan
Comment 1 ifinci 2003-02-09 16:19:31 UTC
This is also true for the version shipped with KDE 3.1 
Comment 2 Cornelius Schumacher 2003-02-28 09:44:32 UTC
Better configurability of what is considered a work day and what not would be nice, agreed. 
 
Comment 3 Cornelius Schumacher 2003-02-28 10:47:02 UTC
*** Bug 54350 has been marked as a duplicate of this bug. ***
Comment 4 Levy, Chen 2004-03-04 08:37:30 UTC
In KDE 3.2 this problem is fixed, well almost fixed. The following quote from a discussion on the KDE Hebrew localization mailing list at http://groups.yahoo.com/group/kde-il/message/709 (slightly edited) explains the problem and offers a solution in a concise mannar, so instead of refraseing it, here is the quote itself:

 > > When the calender system is set to Hebrew,
 > > Saturday is indeed marked as a hollyday, but is there a way to
 > > uncouple these settings, i.e. use a Gregorian calender and still
 > > take the weekend off, on Saturday?
 
 > Well, it's not possible at the moment since the day highlighted 
 > is determined according to the calendar system. Do you think there 
 > should be a  way to configure this? 
 > If so, how do you think it should be done? 
 > Should there be an option for it in KOrganizer, or maybe something 
 > for all of KDE, or should it be determined in another way?
  
 Well, I am no usability expert but:
 
 1) Most of the Israelis I know use the Gregorian calender, some
 people use the Hebrew calender as a secondary calender (Memorials
 for grand-mother's funeral, etc). Not many write Hebrew dates on
 bank checks. Almost all of us are taking our day off, on Saturday.
 So, yes, there should be a separate selection of this option.
 
 2) I think that the rest-day should be configurable outside
 KOrganizer. I can think of other applications that can use this
 data, e.g. a project management software may want to know what is
 the rest-day, to be able to calculate the work-days needed for the
 completion of a task.
 
 3) IMHO, the natural place to configure the rest-day(s) (it can be
 more then one day in the week), is the Country & Language -> Date &
 Time, after the "First day of the week" selection, or in an advanced
 dialog behind this dialog. The default should be set by the, region
 and/or the system calender and/or the first day of the week.
 
The original thread "Hebrew dates in Korganizer 3.2" start at: http://groups.yahoo.com/group/kde-il/message/698 the entire discussion is written in English except for some dates in the quote headesr wich are Hebrew dates in Hebrew letters :)

The KDE Hebrew localization mailing list (at http://groups.yahoo.com/group/kde-il/) is a good place to ask for usibility feedback on this subject.
Comment 5 Reinhold Kainhofer 2004-07-09 15:53:12 UTC
KOrganizer just uses the day of rest returned by the functions in kdelibs. If the calendar system and the day of rest settings should be decoupled, that has to be changed in kdelibs, and korganizer will then use the decoupled settings.

Reinhold
Comment 6 Oded Arbel 2005-11-16 16:24:21 UTC
This issue should be closed - in 3.4 (and possibly earlier), Korganizer correctly marks friday and saturday as rest days if so configured - i.e., they are marked in red in the month views.
Comment 7 Shai 2006-03-09 19:07:41 UTC
This issue should not be closed -- Days are marked correctly in the date selector (the three little months on top of eachother), but in the selectable month view (i.e, day - 3 days - work week - week - month --- that month) Sundays are still marked red although they are workdays (as of KDE 3.5.1, Korganizer 3.5 on Debian Unstable).
Comment 8 Dmitry Kagan 2006-10-25 09:44:06 UTC
Hi!

The KDE PIM bug triage is coming, according to the dot. Also this bug is kdelibs, it actually affect the KDE PIM applications. These kind of bugs are really annoying and shouldn't exist in a top class desktop environment , such as KDE.
Please fix this!

Thank you!
Comment 9 John Layt 2007-07-24 23:22:54 UTC
KCalendarSystem currently has dayOfPray() method which returns the weekday for religious observance in a particular calendar system.  While it would be possible to also add dayOfRest() to KCalendarSystem, this would not solve the above problem, as the Gregorian system is used in many countries that may have a different value to return.  Instead, dayOfRest() and probably dayOfPrayer() should be added to KLocale and set on a country basis.  Perhaps, given that for many in the west the day of religious observance has lost that original meaning, and there are a couple of nominally atheist countries, a daysOfRest() or weekend() method would be better, returning a list of day numbers.

John.
Comment 10 John Layt 2008-10-16 21:02:28 UTC
I am preparing an RFC to the kcd list for a change in 4.2 to add the start and end of the working week and the day of religious observance to KLocale so the calendar widgets can then know the local requirement.  Assigning to me to action.
Comment 11 John Layt 2009-06-03 15:34:11 UTC
Forgot to close this one.  In KDE 4.2 there are now Locale options to set the first and last day of the working week and a designated day of religious observance independent of the calendar system. The standard date picker now uses these, as does a few other places.  

The plasma calendar does not use this as it does not currently highlight work days or religious days, a separate wish would need to be raised against plasma for this.