Bug 52884 - bookmark comments (keywords) should be searched as well
Summary: bookmark comments (keywords) should be searched as well
Status: RESOLVED FIXED
Alias: None
Product: keditbookmarks
Classification: Applications
Component: general (show other bugs)
Version: 4.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-11 17:58 UTC by Rick Reumann
Modified: 2003-10-17 01:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Reumann 2003-01-11 17:58:04 UTC
Version:           3.0.4 (using KDE KDE 3.0.5)
Installed from:    SuSE RPMs

I made a comment about this in bug 51122 but thought it could be added as a new one. A tool like powermarks really would be great for Linux users who are often keyboard oriented, but without creating that whole application a quick solution could be to provide what Mozilla has. In Moz you could enter in keywords for bookmarks in the bookmark manager. You then can search through all your bookmarks by typing in keywords. This is very useful. Imagine you bookmark an article on the "NY Giants." The article actually talks a lot about the city of NY and also talks about the giants. Rather than bookmark twice at the time you ended up just putting in your sports directory. Months later you remember an article talking about something in NY but in your NY folder you can't find the bookmark. With Moz when you enter the bookmark you could give it the keywords "Giants" and "NY", then if you searched on either term the bookmark would come back in the search results. Powermarks is of course much more elegant and fast program for Windows but the mozilla solution is a start. To see what powermarks does
http://www.kaylon.com/power.html
Thanks for listening.
Comment 1 Alex Radu 2003-08-14 07:18:56 UTC
I second this, this is a MUST HAVE feature and I was very suprised not to find it in 
Konqueror. The Search bookmarks feature in Mozilla's Bookmark manager is fantastic and 
includes a bunch of filters to make your search more effective. You can even save the 
query. 
 
For example I search for bookmarks containing the word KDE and lets say I find one. 
KDE.org. I save this search and it becomes a folder, the cool thing is that once I add more 
KDE bookmarks they will all pile up in that folder. 
 
I use this style filters for most of my bookmarks and I never have to organize them with 
Mozilla's awesome filters tehy go where I want them to from the start!! 
 
Konqueror needs a killer feature like this. 
Comment 2 Moritz Moeller-Herrmann 2003-10-10 08:19:46 UTC
KDE in CVS has a search bookmarks feature (like Mozilla) as well as the
possibility to add comments to bookmarks.

Unfortunately the search ignores comments. (aka keywords) This makes comments
almost useless as keywords == bug.
Comment 3 Moritz Moeller-Herrmann 2003-10-10 08:23:08 UTC
This is not a konqueror bug...
Comment 4 lypanov 2003-10-13 10:41:37 UTC
thanks moritz i'll fix this soon 
 
Alex 
Comment 5 Alex Radu 2003-10-14 01:33:46 UTC
Are you sure it has a search features as powerful as Mozilla?

Mozilla 's search feature is like this:

Find bookmarks whose:

Dopdown menu 1 here Dropdown menu 2 here _____space for input___________
[name]              [contains]
[location]          [starts with]
[description]       [ends with]
[keyword]           [is]
                    [is not]
                    [dosen't contain]
_____________________________________________________________________________

[] save query
_____________________________________________________________________________

4 x 6 = 12 Therefore, from the dropdown menus you have 12 fields of criteria,
not to mention the input field.

The save query function is also phenomenal. It allows your bookmarks to organize
THEMSELVES.

For example I can save a query for items locations which contain the term KDE.
Now, all my bookmarks whcih have a url that contains KDE will be organized into
a single folder and any items I add in the future will be addted to that folder. 

This means that all my messy KDE urls such as bugs.kde.org, kde-look.org,
dot.kde.org, developer.kde.org, apps.kde.com, kdedevelopers.org, kde-forum.org
etc. will be placed in one folder called Find "KDE".

Of course, the search function is only one of many of Mozilla's bookmark manager
features. 

If KDE developers have really managed to add sucha  comprehensive and yet still
simple search feature I am very impressed. If not, evena  simple search is a
good step forward.


Comment 6 lypanov 2003-10-16 23:46:22 UTC
Subject: kdebase/konqueror/keditbookmarks

CVS commit by lypanov: 

enable searching on comment field
CCMAIL:52884-close@bugs.kde.org


  M +2 -2      search.cpp   1.28


--- kdebase/konqueror/keditbookmarks/search.cpp  #1.27:1.28
@@ -22,4 +22,5 @@
 #include "listview.h"
 #include "search.h"
+#include "commands.h"
 
 #include <qregexp.h>
@@ -85,6 +86,5 @@ void KBookmarkTextMap::update()
 void KBookmarkTextMap::visit(const KBookmark &bk) {
     if (!bk.isSeparator()) {
-        // todo - comment field
-        QString text = bk.url().url() + " " + bk.text();
+        QString text = bk.url().url() + " " + bk.text() + NodeEditCommand::getNodeText(bk, "desc");
         m_bk_map[text].append(bk);
     }


Comment 7 Alex Radu 2003-10-17 00:10:57 UTC
Will someone inform me on this. Is the search feature as powerful as in Mozilla 1.5?
Comment 8 Sashmit Bhaduri 2003-10-17 00:20:25 UTC
I have no clue about Mozilla 1.5, but Konqueror-cvs's search feature looks to be pretty much similar to MozillaFirebird 0.7/Mozilla pre-1.6
Comment 9 Alex Radu 2003-10-17 01:39:24 UTC
Oh, that's too bad, Firebird's feature is pathetic compared to Mozilla 1.5. 

Also, it doesen't matter if you have a clue about Mozilla 1.5 or not, waht do you think I typed a whole page describing Mozilla 1.5's advanced search features for!!! Please read it and tell me.