Bug 338417 - Loading a document from the dashboard to practice make the document as modified.
Summary: Loading a document from the dashboard to practice make the document as modified.
Status: RESOLVED FIXED
Alias: None
Product: parley
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: parley bug tracker
URL:
Keywords:
: 338566 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-08-20 19:32 UTC by Andreas
Modified: 2014-08-26 20:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.14.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas 2014-08-20 19:32:13 UTC
As per title.
Also the save action Ctrl-S doesn't clear the modified from the title.
Switching to the editor and back does clear the modified from the title.
Comment 1 Andreas 2014-08-22 21:35:54 UTC
Git commit 73c5397f6fac7f598d2c5ea71ef3de167110f0c3 by Andreas Xavier.
Committed on 22/08/2014 at 18:58.
Pushed by axavier into branch 'KDE/4.14'.

Fix bugs: 338302 and 338417 title bar [modified] tag is inconsistent

Symptoms:
The [modified] in the title bar was inconsistent.

Problems:
1. The title bar was only connected to the dirty bit in the doc from
the Editor. Going directly welcome -> stats did not connect the title
bar to the dirty bit.
2.  Whenever a new document was created, new collection, welcome screen
etc. the title bar was disconnected.
3. In several places setModified was called on the kvocdoc when either
nothing changed or the kvocdoc should know better.

Solution:
The title bar is ParleyMainWindow's title bar. ParleyMainWindow also
know when the document is updated. I created a updateParleyDocument
so that ParleyMainWindow always knows when the doc changes and
slotFileNew so that anyone can ask ParleyMainWindow to update its
own title bar.

Not fixed: Parley still directly calls the setModified in kvocdoc
when it starts practice. kvocdoc needs to be fixed before that is
removed.
Related: bug 338302
FIXED-IN:4.14.1

M  +0    -7    src/editor/editor.cpp
M  +1    -10   src/parleydocument.cpp
M  +19   -1    src/parleymainwindow.cpp
M  +6    -0    src/parleymainwindow.h
M  +1    -0    src/practice/practicemainwindow.cpp
M  +0    -1    src/settings/documentproperties.cpp
M  +0    -1    src/settings/languageproperties.cpp
M  +1    -0    src/vocabulary/vocabularymodel.cpp
M  +1    -1    src/welcomescreen/welcomescreen.cpp

http://commits.kde.org/parley/73c5397f6fac7f598d2c5ea71ef3de167110f0c3
Comment 2 Andreas 2014-08-22 21:40:24 UTC
Git commit 487294f869f35b9c228cf18f82b5e2d141a0cee4 by Andreas Xavier.
Committed on 22/08/2014 at 18:58.
Pushed by axavier into branch 'master'.

Fix bugs: 338302 and 338417 title bar [modified] tag is inconsistent

Symptoms:
The [modified] in the title bar was inconsistent.

Problems:
1. The title bar was only connected to the dirty bit in the doc from
the Editor. Going directly welcome -> stats did not connect the title
bar to the dirty bit.
2.  Whenever a new document was created, new collection, welcome screen
etc. the title bar was disconnected.
3. In several places setModified was called on the kvocdoc when either
nothing changed or the kvocdoc should know better.

Solution:
The title bar is ParleyMainWindow's title bar. ParleyMainWindow also
know when the document is updated. I created a updateParleyDocument
so that ParleyMainWindow always knows when the doc changes and
slotFileNew so that anyone can ask ParleyMainWindow to update its
own title bar.

Not fixed: Parley still directly calls the setModified in kvocdoc
when it starts practice. kvocdoc needs to be fixed before that is
removed.
Related: bug 338302
FIXED-IN:4.14.1

M  +0    -7    src/editor/editor.cpp
M  +1    -10   src/parleydocument.cpp
M  +19   -1    src/parleymainwindow.cpp
M  +6    -0    src/parleymainwindow.h
M  +1    -0    src/practice/practicemainwindow.cpp
M  +0    -1    src/settings/documentproperties.cpp
M  +0    -1    src/settings/languageproperties.cpp
M  +1    -0    src/vocabulary/vocabularymodel.cpp
M  +1    -1    src/welcomescreen/welcomescreen.cpp

http://commits.kde.org/parley/487294f869f35b9c228cf18f82b5e2d141a0cee4
Comment 3 Andre Klapper 2014-08-26 20:34:46 UTC
*** Bug 338566 has been marked as a duplicate of this bug. ***