Bug 304615 - Cut & Paste operations are not aborted when clipboard content changes
Summary: Cut & Paste operations are not aborted when clipboard content changes
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 2.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
: 304614 311101 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-05 13:07 UTC by Janek Bevendorff
Modified: 2012-12-03 19:51 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kde-baseapps/4120805872c2e9fac909a403b83221c09c9110a2
Version Fixed In: 4.9.4
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Janek Bevendorff 2012-08-05 13:07:58 UTC 
When hitting Ctrl+X on a file or folder it is grayed out to indicate that this file is about to be moved upon next paste.

But when I switch to another application before pasting the file (e.g. to a text editor such as Kate) and copy/cut some text into the clipboard, Dolphin doesn't recognize the clipboard content change and keeps showing the grayed out icon.

This behavior is very irritating, because it suggests, that Dolphin still stores the file in the clipboard, but hitting Ctrl+V actually pastes the text from the clipboard to a new file and the icon stays grayed out until I close Dolphin or cut and paste another file.

Reproducible: Always

Steps to Reproduce:
1. Open Dolphin, select a file and hit Ctrl+X
2. Open a text editor, write some text and copy it the clipboard
3. Go back to Dolphin and hit Ctrl+V


Expected Results:  
Cut & Paste operation in Dolphin should be aborted when the clipboard content changes.

Also reproducible in Konqueror, related to Bug 304614
Comment 1 Frank Reininghaus 2012-08-06 09:18:25 UTC 
Thanks, I can confirm this issue.
Comment 2 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:20:02 UTC 
Resetting assignee to default as per bug #305719
Comment 3 Frank Reininghaus 2012-11-23 16:19:40 UTC 
Proposed fix at https://git.reviewboard.kde.org/r/107390/.
Comment 4 Frank Reininghaus 2012-11-23 16:21:00 UTC 
*** Bug 304614 has been marked as a duplicate of this bug. ***
Comment 5 Frank Reininghaus 2012-11-24 15:03:24 UTC 
Git commit 4120805872c2e9fac909a403b83221c09c9110a2 by Frank Reininghaus.
Committed on 24/11/2012 at 04:52.
Pushed by freininghaus into branch 'KDE/4.9'.

Update the 'isCut' state of items when cutting non-files, e.g., text
FIXED-IN: 4.9.4
REVIEW: 107390

M  +2    -6    dolphin/src/kitemviews/private/kfileitemclipboard.cpp

http://commits.kde.org/kde-baseapps/4120805872c2e9fac909a403b83221c09c9110a2
Comment 6 Frank Reininghaus 2012-11-25 10:47:24 UTC 
Git commit 599082906dd2d0b842a6b5c0d266f45e77473bd2 by Frank Reininghaus.
Committed on 25/11/2012 at 11:45.
Pushed by freininghaus into branch 'KDE/4.9'.

Fix regression caused by 4120805872c2e9fac909a403b83221c09c9110a2

Copied items should not be shown in gray. Thanks to Christoph Feck for
testing and reporting this regression!
CCMAIL: christoph@maxiom.de

M  +7    -1    dolphin/src/kitemviews/private/kfileitemclipboard.cpp

http://commits.kde.org/kde-baseapps/599082906dd2d0b842a6b5c0d266f45e77473bd2
Comment 7 Frank Reininghaus 2012-12-03 19:51:20 UTC 
*** Bug 311101 has been marked as a duplicate of this bug. ***