Bug 283969 - [PATCH] default taskbox uses plasma-desktop for desktop item instead of 'Show Desktop'
Summary: [PATCH] default taskbox uses plasma-desktop for desktop item instead of 'Show...
Status: RESOLVED DUPLICATE of bug 273478
Alias: None
Product: kwin
Classification: Plasma
Component: effects-tabbox (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 10:09 UTC by Will Stephenson
Modified: 2011-11-13 08:48 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
modify the label if the window is the desktop (1.12 KB, patch)
2011-10-14 10:36 UTC, Will Stephenson 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Will Stephenson 2011-10-14 10:09:32 UTC 
Version:           unspecified
OS:                Linux

When the 'Show Desktop' task switcher option is enabled:

[TabBox]
ShowDesktop=true

the default box switch effect includes the desktop as 'plasma-desktop' which is ugly.  In the non-composited task switcher the desktop is listed as 'Show Desktop', which is correct.

Reproducible: Didn't try

Steps to Reproduce:
enable Show Desktop on a default configuration

Actual Results:  
plasma-desktop shown

Expected Results:  
Pretty string instead.
Comment 1 Will Stephenson 2011-10-14 10:36:03 UTC 
Created attachment 64510 [details]
modify the label if the window is the desktop

Copied from tabbox, but I guess that this should be done in a library since the other switchers would need it too.
Comment 2 Martin Flöser 2011-10-15 06:59:42 UTC 
Patch seems fine. I don't think it's worth to add it to the library - it's only used in four effects...
Comment 3 Martin Flöser 2011-11-13 08:42:42 UTC 
BoxSwitch is no longer used in 4.8 and migrated to a QML based layout. This means only the other effects are affected, but I plan to migrate them to QML (if possible) in 4.9.
Comment 4 Martin Flöser 2011-11-13 08:48:38 UTC 

*** This bug has been marked as a duplicate of bug 273478 ***