Bug 273478 - JJ: Synchronize Show Desktop wording in all tabbox effects
Summary: JJ: Synchronize Show Desktop wording in all tabbox effects
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: tabbox (show other bugs)
Version: unspecified
Platform: Chakra Linux
: NOR wishlist
Target Milestone: 4.9
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/104...
Keywords: junior-jobs
: 283969 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-05-17 13:00 UTC by Rodney Gedda
Modified: 2012-04-01 06:09 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rodney Gedda 2011-05-17 13:00:22 UTC
Version:           unspecified (using Devel) 
OS:                Linux

Set the "walk through windows" actions in the Task Switcher KCM to "include desktop".

Then, using alt-tab box switcher to switch between windows and the desktop, do:

- alt-tab to expose the plasma desktop. let go to have an active desktop (no windows)
- walk through the windows again using alt-tab
- try to land on plasma desktop again
- kwin lands you on the last active window and not plasma desktop

So essentially the bug as I see it is when cycling through windows with the plasma desktop as one of them, you can't switch from plasma desktop back to the plasma desktop, you always land on the window that was last used. You go:

desktop -> cycle through windows -> go to land back on desktop -> land on last window 

Is this expected behaviour? It doesn't happen with regular windows, just plasma desktop. With regular windows you can cycle through alt-tab as much as you like and land on the same window all the time.


Reproducible: Always

Steps to Reproduce:
Set the "walk through windows" actions in the Task Switcher KCM to "include desktop".

Then, using alt-tab box switcher to switch between windows and the desktop, do:

- alt-tab to expose the plasma desktop. let go to have an active desktop (no windows)
- walk through the windows again using alt-tab
- try to land on plasma desktop again
- kwin lands you on the last active window and not plasma desktop

Is this expected behaviour? It does happen with regular windows, just plasma desktop.
Comment 1 Thomas Lübking 2011-05-17 13:46:37 UTC
"Is this expected behaviour?"

Yes, In a way :-(
The Desktop in that list is not a link to a focusable window but toggles "Show Desktop", so the first time you call it, all windows are "minimized", the other time they're all "unminimized" and the former focus situation should be restored.

You should rather not see other windows when the desktop was shown this way.
Which switcher do you use and how are your other settings (current/all desktop/s, etc) and which KDE/KWin version?
Comment 2 Rodney Gedda 2011-05-17 14:06:12 UTC
Sure, I understand. It just seems strange that when you can see the desktop in the switcher and you go to stop on it you get a window instead :-)

- current desktop
- I use box switch
- KDE 4.6.3 CHAKRA

$ kwin --version
Qt: 4.7.3
KDE Development Platform: 4.6.3 (4.6.3)
KWin: 4.6.3 (4.6.3)

Best,

Rodney
Comment 3 Thomas Lübking 2011-05-17 14:30:07 UTC
Ah, interesting:
my desktop doesn't the focus from the WM and is the only item shown after the show desktop trigger.
Other desktops (plasma-desktop, pcmanfm) do take the focus and all windows are shown next to them while "show desktop" is active.

@Martin:
i always thought it would be like it's here ;-)
Is the current behavior intentional or should it maybe act like if the desktop does not take focus (and while the desktop is shown, the desktop is the only item in the switcher list, so you can only toggle out)
Comment 4 Martin Flöser 2011-05-17 17:43:10 UTC
I think the behavior is intentional as showDesktop is used. With the first go it uses showDeskotp and with the second it restores. Works perfectly fine here.
Comment 5 Rodney Gedda 2011-05-18 06:42:17 UTC
Hi Martin, I agree it works fine, but I also like the idea of telling the user the desktop will be restored when they alt-tab out of plasma-desktop. Should the box label be changed to something like "Restore Desktop". Right now it just says "plasma-desktop" and that's not what you get.
Comment 6 Martin Flöser 2011-05-18 07:11:24 UTC
----- Ursprüngliche Mitteilung -----
> https://bugs.kde.org/show_bug.cgi?id=273478
> 
> 
> 
> 
> 
> --- Comment #5 from Rodney Gedda <rodney gedda info>   2011-05-18
> 06:42:17 --- Hi Martin, I agree it works fine, but I also like the idea
> of telling the user the desktop will be restored when they alt-tab out
> of plasma-desktop. Should the box label be changed to something like
> "Restore Desktop". Right now it just says "plasma-desktop" and that's
> not what you get.
In the classic switcher there is I think a proper wording. What effect are you using?
Comment 7 Rodney Gedda 2011-05-18 12:58:20 UTC
I'm using the Box Switch effect.

When I change to "No Effect" the wording is "Show Desktop" in both cases. When you alt-tab into the desktop it says "Show Desktop" and when you alt-tab away it says "Show Desktop".

Should we settle on one term for all forms of window switching - whether it's box switch or no effect?

- to desktop -> "Show Desktop"
- out of desktop -> "Show Windows" or "Restore Desktop"
Comment 8 Martin Flöser 2011-05-20 17:37:26 UTC
It should be pretty simple to just call it Show Desktops everywhere. I am against changing the wording as that's actually consistent with other places in  KDE as e.g. the "Show Desktop" Plasmoid.
Comment 9 Martin Flöser 2011-11-13 08:48:38 UTC
*** Bug 283969 has been marked as a duplicate of this bug. ***
Comment 10 Yogesh Marwaha 2011-11-23 16:07:52 UTC
(In reply to comment #4)
> I think the behavior is intentional as showDesktop is used. With the first go
> it uses showDeskotp and with the second it restores. Works perfectly fine here.
This behaviour may be intentional but to me it is not perfect. "Show Desktop" should only show the desktop, not (un)minimise the windows. This will be more consistent with the other entries in there.
For example, if I use the task switcher to switch to (say) Konqueror and after that again switch to Konqueror (same window) then it will not be minimised.

PS: I'm just posting because from the comments so far, I'm unable to deduce developer's thoughts whether this behaviour should change or not.
Comment 11 Thomas Lübking 2011-11-23 17:46:20 UTC
(In reply to comment #10)
> This behaviour may be intentional but to me it is not perfect. "Show Desktop"
> should only show the desktop, not (un)minimise the windows.

Assume you've like 20 windows spread around and want quick access to the desktop (check weahter - why has everybody weather plasmoids, are there no windows in other countries? - anyway...)
Now with your suggested change the following action would be to unminimize _all_ 20 windows.
Does that sound sane?

> This will be more consistent with the other entries in there.
Maybe, but the questions are "why are entries there" & "what is the desktop"
For normal windows -> activate & raise that window
The desktop is treated as "normal" window in the plasma-netbook mode but other(legacy)wise the desktop can often not even be activated and NEVER be raised.

> PS: I'm just posting because from the comments so far, I'm unable to deduce
> developer's thoughts whether this behaviour should change or not.
I frankly don't care about that feature, but to me the current behaviour seems far more sane and from Martin's comments (he's the kwin maintainer) i didn't read any intention to change it either.

Open remains (probably - i don't use it ;-) that wording bug.
Comment 12 Martin Flöser 2011-11-23 17:57:45 UTC
On Wednesday 23 November 2011 17:46:20 Thomas Lübking wrote:
> Open remains (probably - i don't use it ;-) that wording bug.
same here - I don't use this feature, so if anyone wants to change it: Patches 
are more than welcome :-)
Comment 13 Yogesh Marwaha 2011-11-24 06:43:49 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > This behaviour may be intentional but to me it is not perfect. "Show Desktop"
> > should only show the desktop, not (un)minimise the windows.
> 
> Assume you've like 20 windows spread around and want quick access to the
> desktop (check weahter - why has everybody weather plasmoids, are there no
> windows in other countries? - anyway...)
> Now with your suggested change the following action would be to unminimize
> _all_ 20 windows.
> Does that sound sane?
> 
There is some misunderstanding at either end. The behaviour you are 
talking about seems to be *the present implementation*.

If "Show Desktop" in plasma is not actually minimising/unminimising windows but 
doing it differently, then we can copy the implementation from their to suit us.

What I meant to say, in essence, is that Show Desktop" in "tasks list" should 
only show desktop if it is not visible, and if it is already visible, then it should do
nothing.

> > PS: I'm just posting because from the comments so far, I'm unable to deduce
> > developer's thoughts whether this behaviour should change or not.
> I frankly don't care about that feature, but to me the current behaviour seems
> far more sane and from Martin's comments (he's the kwin maintainer) i didn't
> read any intention to change it either.
> 
> Open remains (probably - i don't use it ;-) that wording bug.
If a developer is not willing to do it is separate thing and if he/she is not 
willing to get it done (by anybody else) is another.
It Martin does not want to do it, it is ok. The point is whether he think that this
should be done or not. That I wanted to know. 

Even I dont use this feature, but if it is there it should work properly. Noticed 
it just yesterday.
Comment 14 Thomas Lübking 2011-11-24 07:34:56 UTC
(In reply to comment #13)
> There is some misunderstanding at either end. The behaviour you are 
> talking about seems to be *the present implementation*.
I hope not. Triggering it first should minimize all windows, triggering it again should unminimize unless the "show desktop" state is broken by unminimizing a particular window.

> If "Show Desktop" in plasma is not 
it's a kwin feature, called by plasma (by fdo protocol) - i'm not aware of another implementation (but the dashboard, what's sth. entirely different)

> What I meant to say, in essence, is that Show Desktop" in "tasks list" should 
> only show desktop if it is not visible, and if it is already visible, then it
> should do nothing.
iff at all, it should be absent.

> If a developer is not willing to do it is separate thing and if he/she is not 
> willing to get it done (by anybody else) is another.
Well, he's suggested anybody with a different opinion may show it - what's probably a general fact anyway ;-)

Since the netbook shell is treated as ordinary window and it's always possible to escape from the tablist (what the OP intends) there's actually no feature missing and imo only the usability group is in position to say "desktop in tablist only good in netbook mode. stop. remove setting at once. full stop" =)
Comment 15 Martin Flöser 2012-03-29 08:42:00 UTC
For synchronising the wording in the remaining effects: https://git.reviewboard.kde.org/r/104436/
Comment 16 Martin Flöser 2012-04-01 06:09:03 UTC
Git commit 05dbefec41215806443bc3c8f008d5a8043a7041 by Martin Gräßlin.
Committed on 29/03/2012 at 10:34.
Pushed by graesslin into branch 'master'.

Synchronize Show Desktop Wording in TabBox Effects

Use "Show Desktop" for the desktop entry with the same
message as in "normal" TabBox.
FIXED-IN: 4.9.0
REVIEW: 104436

M  +15   -2    kwin/effects/coverswitch/coverswitch.cpp
M  +5    -0    kwin/effects/coverswitch/coverswitch.h
M  +17   -4    kwin/effects/flipswitch/flipswitch.cpp
M  +5    -0    kwin/effects/flipswitch/flipswitch.h

http://commits.kde.org/kde-workspace/05dbefec41215806443bc3c8f008d5a8043a7041