Bug 264765 - Visual Glitches on top plasma panel after retract using KWin's Slide effect
Summary: Visual Glitches on top plasma panel after retract using KWin's Slide effect
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 264862 265234 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-01-29 17:23 UTC by george panta
Modified: 2011-03-18 18:10 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.6.2


Attachments
Top panel with glitches after retracting yakuake (16.78 KB, image/jpeg)
2011-01-29 17:23 UTC, george panta
Details

Note You need to log in before you can comment on or make changes to this bug.
Description george panta 2011-01-29 17:23:19 UTC
Created attachment 56624 [details]
Top panel with glitches after retracting yakuake

Version:           2.9.8 (using KDE 4.6.0) 
OS:                Linux

After activating the new "ask window manager to perform the slide animation" option, Opening and then retracting yakuake leaves some visual glitches to the plasma panel that is situated at the top (yakuake sliding animation originates from the top too). Those glitches are actually parts of the yakuake window.

Screenshot attached.

Reproducible: Didn't try




I suppose yakuake should instruct KWin to repaint the area of the Screen after it animates. I hope that this can be added for yakuake only, since other plasma widgets using the same effect do not exhibit this behaviour and the removal of Fullscreen repaints from the slide effect provides serious performance benefits.
Comment 1 Eike Hein 2011-01-29 22:41:16 UTC
Since the animation is performed by KWin in the first place, not Yakuake, it's up to KWin to update the screen - Yakuake can't do anything about this.

I'm reassigning to KWin for further triaging, though it's probably a driver bug or so anyway.
Comment 2 Martin Flöser 2011-01-30 11:30:16 UTC
I was just able to reproduce, but do not understand it, yet.
Comment 3 Martin Flöser 2011-01-30 17:34:54 UTC
*** Bug 264862 has been marked as a duplicate of this bug. ***
Comment 4 Frank Niethardt 2011-02-02 22:46:36 UTC
bugs 264372 and 265234 are actually about the same issue
Comment 5 Eike Hein 2011-02-02 22:47:13 UTC
Bug 264765 might be related as well - similar symptoms, but earlier Yakuake without WM-assisted animation.
Comment 6 Eike Hein 2011-02-02 22:48:52 UTC
Err, meant bug 264372 of course, as Frank said as well concurrently.
Comment 7 Aaron J. Seigo 2011-02-02 23:04:27 UTC
*** Bug 265234 has been marked as a duplicate of this bug. ***
Comment 8 Frank Niethardt 2011-02-02 23:11:36 UTC
Just because I feel this is important and may be well hidden in the bugs closed as duplicate: When you enable "Windows may cover panel" (translated from German) in the panel's settings, there are no glitches anymore...
Comment 9 Thomas Lübking 2011-02-02 23:31:07 UTC
blur effect related?
Comment 10 Frank Niethardt 2011-02-02 23:41:07 UTC
Problem seems to vanish if you disable "sliding popups" effect.
Comment 11 Thomas Lübking 2011-02-02 23:44:52 UTC
that's pretty obvious ;-)
but i wondered because of the above/below state and so whether the popup needs to be blurred or not for the panel.
Comment 12 Eike Hein 2011-02-02 23:51:21 UTC
Frank, in your original bug report (bug 264372) you claimed to be using Yakuake 2.9.7, which doesn't make use of the "Sliding Popups" effect. Was that incorrect information?
Comment 13 Frank Niethardt 2011-02-02 23:57:16 UTC
Thomas, sorry, but disabling bluring doesn't change anything...

Eike, I think that's a misunderstanding. I didn't say anything about using effects at all...
Comment 14 Eike Hein 2011-02-03 00:10:10 UTC
You did: You said in comment #10 that the problem goes away for you if you disable the "Sliding Popups" effect. I'm wondering how that can affect Yakuake 2.9.7 because it doesn't make use of that effect for the animation. Yakuake 2.9.8 however - the version *this* bug report references - does. 

If you're not using 2.9.7 but something newer (like a git build from the last weeks, or 2.9.8) that uses the effect, then there's a clear link to the effect; if not, your problem might be separate from it despite the similar symptom. That's why I was asking you to confirm whether it's really 2.9.7.
Comment 15 Frank Niethardt 2011-02-03 00:13:40 UTC
After rereading the whole thing: I didn't look closely on the version numbers, as there was already an Archlinux user in front of me.

Archlinux currently provides:

Qt: 4.7.1
KDE: 4.6.00 (4.6.0)
Yakuake: 2.9.8
Comment 16 george panta 2011-02-17 19:15:14 UTC
This bug is also triggered by Current Application Control Plasmoid.
Add it to top panel, enter its settings and check its only choice.

When you click on it, a plasma list widget appears and on popup close glitches are left on top panel.
Comment 17 Martin Flöser 2011-03-18 18:05:43 UTC
Git commit 672a08ad631155c57b225c6ac64310b19bc1ba12 by Martin Gräßlin.
Committed on 18/03/2011 at 18:06.
Pushed by graesslin into branch 'KDE/4.6'.

Repaint area between offset and window in sliding popups

As this area was not repainted it caused visual garbage during
animationgs. Most visible with yakuake and a panel at the top.
Offset in that case is the upper screenedge while yakuake is
positioned below the panel. The area of the panel did not get
repainted causing the garbage.
BUG: 264765
FIXED-IN: 4.6.2

M  +17   -1    kwin/effects/slidingpopups/slidingpopups.cpp     

http://commits.kde.org/kde-workspace/672a08ad631155c57b225c6ac64310b19bc1ba12
Comment 18 Martin Flöser 2011-03-18 18:10:04 UTC
Git commit 84630e8bb5ac00abc1046e36c068e8288153c48f by Martin Gräßlin.
Committed on 18/03/2011 at 18:06.
Pushed by graesslin into branch 'master'.

Repaint area between offset and window in sliding popups

As this area was not repainted it caused visual garbage during
animationgs. Most visible with yakuake and a panel at the top.
Offset in that case is the upper screenedge while yakuake is
positioned below the panel. The area of the panel did not get
repainted causing the garbage.
CCBUG: 264765

M  +17   -1    kwin/effects/slidingpopups/slidingpopups.cpp     

http://commits.kde.org/kde-workspace/84630e8bb5ac00abc1046e36c068e8288153c48f