Bug 228390 - Playlist gets huge after configuring Qt toolbars
Summary: Playlist gets huge after configuring Qt toolbars
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kdeui (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
: 228496 242197 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-02-25 00:12 UTC by Basti
Modified: 2023-01-14 05:11 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Normal playlist layout. (36.46 KB, image/png)
2010-02-25 00:17 UTC, Basti
Details
Now change toolbar options to “text beside icons” and apply... (74.66 KB, image/png)
2010-02-25 00:24 UTC, Basti
Details
Now the playlist is huge and you can’t resize it anymore. (49.60 KB, image/png)
2010-02-25 00:25 UTC, Basti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Basti 2010-02-25 00:12:37 UTC
Version:            (using KDE 4.4.0)
OS:                Linux
Installed from:    Fedora RPMs

The toolbar at the bottom of the playlist adopts the toolbar’s option (text beside the icon/no text/...) in the KDE “Styles” configuration which changes Qt’s look. That causes a huge playlist window in Amarok which is only resolved by restarting the app. See the screenshots. Solution: Force these icons to have no text.
Comment 1 Basti 2010-02-25 00:17:17 UTC
Created attachment 41074 [details]
Normal playlist layout.
Comment 2 Basti 2010-02-25 00:24:05 UTC
Created attachment 41077 [details]
Now change toolbar options to “text beside icons” and apply...
Comment 3 Basti 2010-02-25 00:25:32 UTC
Created attachment 41078 [details]
Now the playlist is huge and you can’t resize it anymore.
Comment 4 Christoph Feck 2010-02-25 01:11:32 UTC
As far as I know there is a regression in kdelibs that makes toolbars always change on the systemsettings configured text style changes, instead of keeping what the programmer set.
Comment 5 Basti 2010-02-25 01:18:50 UTC
So you say there is no possible solution? I think there is one because changing the shown option doesn’t affect the toolbars in KMail, Akregator and others that I set to “text only” via context menu.
Comment 6 Christoph Feck 2010-02-25 01:22:31 UTC
Reassigned on David's request.
Comment 7 Myriam Schweingruber 2010-02-25 18:46:38 UTC
*** Bug 228496 has been marked as a duplicate of this bug. ***
Comment 8 Kevin Funk 2010-07-29 12:54:23 UTC
commit 0c4f37cb1cd1f3973d987337ab8144a7256344ee
Author: Kevin Funk <krf@electrostorm.net>
Date:   Thu Jul 29 12:48:27 2010 +0200

    Fix bottom playlist toolbar getting to tall
    
    When using KToolBar settings like "Text only" button style in system
    settings causes the toolbar to be applied by these settings.
    Using QToolBar instead of KToolBar fixes this.
    
    BUG: 228390

diff --git a/ChangeLog b/ChangeLog
index 42b4265..5234be9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -42,6 +42,8 @@ VERSION 2.3.2-Beta 1
       Patch by Richard Longland <rlongland@hotmail.com>.
 
   BUGFIXES:
+    * Fixed playlist bottom toolbar getting to tall when using "Text only"
+      button style. (BR 228390)
     * Fixed Amarok layout saving when minized to tray. (BR 244583)
     * Make "No other participants" in the events applet translatable.
       Patch by Jan Janssen. (BR 235311)
diff --git a/src/playlist/PlaylistDock.cpp b/src/playlist/PlaylistDock.cpp
index b9d4d4e..1f09769 100644
--- a/src/playlist/PlaylistDock.cpp
+++ b/src/playlist/PlaylistDock.cpp
@@ -48,7 +48,6 @@ Playlist::Dock::Dock( QWidget* parent )
 
     setObjectName( "Playlist dock" );
     setAllowedAreas( Qt::AllDockWidgetAreas );
-
 }
 
 void
@@ -117,7 +116,8 @@ Playlist::Dock::polish()
     barBox->setMargin( 0 );
     barBox->setContentsMargins( 0, 0, 0, 0 );
 
-    KToolBar *plBar = new KToolBar( barBox, false, false );
+    // Use QToolBar instead of KToolBar, see bug 228390
+    QToolBar *plBar = new QToolBar( barBox );
     plBar->setFixedHeight( 30 );
     plBar->setObjectName( "PlaylistToolBar" );
 
@@ -125,7 +125,6 @@ Playlist::Dock::polish()
 
     { // START Playlist toolbar
         plBar->setSizePolicy( QSizePolicy::Minimum, QSizePolicy::Preferred );
-        plBar->setIconDimensions( 22 );
         plBar->setMovable( false );
         plBar->addAction( new KToolBarSpacerAction( m_mainWidget ) );
Comment 9 Christoph Feck 2010-07-30 17:45:53 UTC
Reopen, as the bug is not fixed by the commit, but only worked around.
Comment 10 Kevin Funk 2010-07-31 13:01:17 UTC
@#9: Could you elaborate why it is not fixed?
Comment 11 Christoph Feck 2010-08-17 00:29:21 UTC
Kevin, the bug is in kdelibs. I also see it in Kate for example.
Comment 12 Kevin Funk 2010-12-04 08:51:19 UTC
*** Bug 242197 has been marked as a duplicate of this bug. ***
Comment 13 Basti 2011-01-07 16:07:09 UTC
@#11 Is there a bug opened in kdelibs?
Comment 14 Christoph Feck 2011-01-07 17:59:23 UTC
Basti, the bug is assigned to kdelibs (and still valid).
Comment 15 Basti 2011-05-01 19:24:46 UTC
And why is it still unconfirmed?
Comment 16 Andrew Crouthamel 2018-11-05 03:19:34 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 17 Andrew Crouthamel 2018-11-17 04:59:38 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 18 Justin Zobel 2022-12-15 05:49:02 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 19 Bug Janitor Service 2022-12-30 05:22:37 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 20 Bug Janitor Service 2023-01-14 05:11:40 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!