Bug 166141 - spellchecker not checking correct language
Summary: spellchecker not checking correct language
Status: RESOLVED WORKSFORME
Alias: None
Product: kmail
Classification: Applications
Component: composer (show other bugs)
Version: 1.9.52
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 166925 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-07-09 15:32 UTC by jarlgjessing
Modified: 2008-08-28 11:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jarlgjessing 2008-07-09 15:32:50 UTC
Version:           1.9.52 (using 4.00.85 (KDE 4.0.85 (KDE 4.1 >= 20080703) "release 3.3", KDE:KDE4:Factory:Desktop / openSUSE_11.0)
Compiler:          gcc
OS:                Linux (i686) release 2.6.25.9-0.2-pae

Even though I've configured the spellchecker using "Personal Settings" to Danish, and in Composer->Settings->Spellchecking AND Composer->Tools->Spelling, it does not save the changes.
The settings in "Personal settings" are stored but not the ones in kmail. It returns to default which I guess is English
Comment 1 Thomas McGuire 2008-07-09 15:57:54 UTC
True, the KDE spellcheck language has no effect on KMail, it takes the language from the identity settings.
Go to the identity settings and change the dictionary there.

I agree the KDE-wide setting should somehow be taken into account, but I'm not sure how. If the KDE-wide setting is changed, we don't want to loose the identity setting, which might be intentionally changed by the user.
Comment 2 jarlgjessing 2008-07-09 16:54:00 UTC
Ok, except, I have set it under identity, I hve actually set it everywhere... Still does not work. Great app though :-) lots of things has been added since 3 series :-)
Comment 3 Thomas McGuire 2008-07-09 17:31:32 UTC
> Ok, except, I have set it under identity, I hve actually set it everywhere... Still does not work. Great app though :-) lots of things has been added since 3 series :-) 
I re-tested this, and it works for me. If you have multiple identities, and you turn on the identity and the dictionary combobox in the composer, you'll even see that the dictionary changes when changing identity.

Maybe it doesn't work for you because you're using the openSuse version, and they didn't backport some spellcheck-related fixes.
Comment 4 jarlgjessing 2008-07-09 19:40:18 UTC
No, I only have one identity. Should I report this error on bugs.opensuse.org?
Comment 5 Thomas McGuire 2008-07-09 20:22:55 UTC
> Should I report this error on bugs.opensuse.org? 
No, they'll release packages for KDE 4.1 RC1 soon, please test them and report back. Make sure kdelibs and kmail is updated to 4.1 RC1.
Comment 6 jarlgjessing 2008-07-18 11:11:02 UTC
It is now updated to RC1 and it still does not work :-(
I have also started from scratch that is removed ~/.kde4 and set the spellcheck to danish everywhere I can find. And as I type here I can see that the same problem exists for konqueror!
Comment 7 Thomas McGuire 2008-07-18 17:38:16 UTC
*** Bug 166925 has been marked as a duplicate of this bug. ***
Comment 8 Will Stephenson 2008-07-18 17:50:04 UTC
I can't reproduce this either (openSUSE's 4.1RC1).  

Jarl: is the correct Dictionary set for each identity in $HOME.kde4/share/config/emailidentities ?  

How many identities do you have?

do you have the Identity and Dictionary fields visible in the composer?  What do they show?  Is the correct Dictionary shown when changing the Identity combo?

As a last resort, attach the files $HOME.kde4/share/config/emailidentities and $HOME.kde4/share/config/emaildefaults here.
Comment 9 jarlgjessing 2008-07-18 21:50:29 UTC
Only one :-( And as mentioned I started a clean installation with no existing users on the system, so there are no "inherited" errors.

I have tried the installation 3 times now. No luck. The english dictionary works just fine it just does not use the danish.

[$Version]
update_info=kmail.upd:3.3-move-identities-to-own-file,kmail.upd:3.3-aegypten-emailidentities-split-sign-encr-keys

[General]
Default Identity=1358264993

[Identity #0]
Dictionary=Danish
Drafts=drafts
Email Address=jarl@yaeda.org
Fcc=sent-mail
Identity=Default
Inline Signature=
Name=Jarl E. Gjessing
Preferred Crypto Message Format=auto
Signature Type=disabled
Templates=templates
X-FaceEnabled=false
uoid=1358264993


[Defaults]
Profile=Default

[PROFILE_Default]
EmailAddress=jarl@yaeda.org
FullName=Jarl E. Gjessing
Organization=
ReplyAddr=
ServerType=
Comment 10 Salvatore Brigaglia 2008-07-19 11:51:48 UTC
I had this probmel too with RC1 but now it's gone: opensuse11 kde 4.0.99 and kmail 1.10.

Changing default language of the identity also sets the correct language in the composer's field.
Comment 11 Thomas McGuire 2008-07-19 11:57:30 UTC
> I had this probmel too with RC1 but now it's gone: opensuse11 kde 4.0.99 and kmail 1.10. 
OK, closing then, I always assumed this was only because some outdated version of kdelibs or kdepim in opensuse.
Comment 12 Ladislav Nesnera 2008-07-24 21:14:40 UTC
I have only one identity with Czech dictionary but KDE language is set to English.

nesnera@nesnera-nb:~> kontact
kontact(21142)/kmail KMFolderMgr::removeFolderAux: Can not find parent folder
Enchant dict for "cs" 0xb74fe0
nesnera@nesnera-nb:~> Enchant dict for "cs" 0xb74fe0 #Composer was started
Enchant dict for "en_US" 0x1a9ffe0 #Cursor was moved to the body field
Enchant dict for "cs" 0xb74fe0 #Czech dictionary was manually selected  (View | Dictionary was enabled)

This issue could be similar as Bug 79681

Environment:
Qt: 4.4.0
KDE: 4.1.00 (KDE 4.0.99 (4.1 RC1+)) "release 13.7"
KMail: 1.10.0
Comment 13 Ladislav Nesnera 2008-07-29 15:48:24 UTC
This bug should be reopened I'm afraid. Comment # describes how cs dictionary is switched to en. Problem persist for
Qt: 4.4.0
KDE: 4.1.00 (KDE 4.1.0) "release 16.3"
KMail: 1.10.0
Comment 14 Ladislav Nesnera 2008-07-29 15:49:23 UTC
Comment #12 
Comment 15 Thomas McGuire 2008-07-29 17:03:28 UTC
Fixed in r839222 (see http://websvn.kde.org/?view=rev&revision=839222)
I couldn't reproduce it because it worked fine for a German dictionary, I only saw the bug after using a Czech dictionary.
Comment 16 Ladislav Nesnera 2008-07-29 17:23:49 UTC
Fine. How can I help you?
Comment 17 Thomas McGuire 2008-07-29 17:26:04 UTC
> Fine. How can I help you?

You can't, the bug is fixed now. It will be available with KDE 4.1.1
Comment 18 Thomas McGuire 2008-08-02 15:08:22 UTC
SVN commit 841023 by tmcguire:

Backport r839222 by tmcguire to the 4.1 branch:

Fix spellcheck language not being correctly set for some languages.
CCBUG: 166141



 M  +1 -0      kmcomposewin.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=841023
Comment 19 Ladislav Nesnera 2008-08-23 12:23:39 UTC
This bug persists in my KMail still. Mail Komposer starts with an appropriate dictionary but there must exists same code which sets the dictionary from cs to en_US when I put the cursor to the body field of an e-mail.
Enchant dict for "cs" 0x13f61b0
Enchant dict for "en_US" 0x15fba50
Enchant dict for "en_US" 0x15fba50
(It's the same as description in Comment #12)
environment:
Qt: 4.4.0
KDE: 4.1.1 (KDE 4.1.0 (4.1 >= 20080722)) "release 40.1"
KMail: 1.10.0
openSUSE 11 64-bit
Comment 20 Ladislav Nesnera 2008-08-28 11:19:30 UTC
It works well for me now. Thanks a lot.
Qt: 4.4.0
KDE: 4.1.1 (KDE 4.1.0 (4.1 >= 20080722)) "release 40.4"
KMail: 1.10.0