Bug 163597 - Add drag and drop support to folder view containment
Summary: Add drag and drop support to folder view containment
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-folderview (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-09 12:54 UTC by FiNeX
Modified: 2008-08-02 22:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description FiNeX 2008-06-09 12:54:09 UTC
Version:           Revision 818680 (using Devel)
Installed from:    Compiled sources
OS:                Linux

The folder view containment should be improved adding the drag and drop support of files/directories.

Possible usecases:

- copy/move/link a file/folder from dolphin/konqueror to the folder view
- copy/move/link a file/folder from dolphin/konqueror to a directory listed in the folder view
- copy/move/link a file/folder from the folder view to dolphin/konqueror
- copy/move/link a file/folder from the folder view to a directory listed in the folder view
Comment 1 FiNeX 2008-06-12 09:26:41 UTC
File operations from/to dolphin/konqueror has been implemented.
Tested using trunk, r819491.
Comment 2 Aaron J. Seigo 2008-06-12 13:05:48 UTC
*** Bug has been marked as fixed ***.
Comment 3 FiNeX 2008-06-12 13:55:08 UTC
It miss the fourth point:
drag&drop a file/folder from the folder view, to a folder in the folder view.

I'll let this open :-) :-) :-)
Comment 4 Aaron J. Seigo 2008-06-12 14:13:38 UTC
SVN commit 819860 by aseigo:

drop within a folderview.

p.s. bugzilla has all the wrong granularity in bug reports.

BUG:163597


 M  +27 -16    folderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=819860
Comment 5 FiNeX 2008-06-12 14:47:58 UTC
Great! The commit works right. Aaron, what do you mean with your "P.S." ?



P.S. why icons in the popup menu (copy/move/...) are different from dolphin?
Comment 6 Aaron J. Seigo 2008-06-12 14:53:55 UTC
> what do you mean with your "P.S." ?

that having 4 items in one report like this is not particularly great (since we can't mark off which individual items are completed; it's all-or-nothing; we're stuck with just commenting which sucks), but then i wouldn't want this one split into 4 separate reports either really since they belong together.

i really don't like bugzilla, and this is but one of the reasons.

> why icons in the popup menu (copy/move/...) are different from dolphin? 

i used libkonq for this; dolphin doesn't use this code yet. it's a TODO item for dolphin. needs some fixes in libkonq it seems.
Comment 7 Aaron J. Seigo 2008-06-12 15:01:22 UTC
SVN commit 819869 by aseigo:

icons, order sync with dolphin's menu
CCBUG:163597


 M  +7 -7      konq_operations.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=819869
Comment 8 FiNeX 2008-06-12 15:12:21 UTC
Thanks for your explanation Aaron (and for the fix, of course) :-)

Amyway did dolphin devs knows this too?


P.S: Will the next version of bugzilla help for managing this kind of situation?
Comment 9 Jason A. Donenfeld 2008-08-01 03:24:16 UTC
This bug should be reopened:

There is no support for dragging files to the target of .desktop links (i.e. a .desktop file with "Type=Link URL[$e]=..."). This feature was in kde3 and was invaluable.

Steps:
1. Right click, choose Create New-->Link to Location (URL), enter a folder's url or even an ftp server (kioslave should take care of it).
2. Drag a file to the newly created link.

Result: The link is not seen as a drop target.
Comment 10 Witold Sowa 2008-08-02 14:40:34 UTC
There is also no support for draging onto the same folderview's empty space with ctls pressed, which should make a copy of file/dir (with prompt for change name).
Comment 11 Jason A. Donenfeld 2008-08-02 22:43:49 UTC
Comment #9 report moved to: http://bugs.kde.org/show_bug.cgi?id=168154