Bug 168154 - folderview drag-drop does not accept .desktop drops
Summary: folderview drag-drop does not accept .desktop drops
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-02 22:40 UTC by Jason A. Donenfeld
Modified: 2016-12-10 14:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
dolphinview patch (646 bytes, patch)
2008-09-11 11:01 UTC, David Faure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason A. Donenfeld 2008-08-02 22:40:03 UTC
Version:            (using KDE 4.1.0)
Installed from:    Gentoo Packages

There is no support for dragging files to the target of .desktop links (i.e. a .desktop file with "Type=Link URL[$e]=..."). This feature was in kde3 and was invaluable.

Steps:
1. Right click, choose Create New-->Link to Location (URL), enter a folder's url or even an ftp server (kioslave should take care of it).
2. Drag a file to the newly created link.

Result: The link is not seen as a drop target.
Comment 1 Aaron J. Seigo 2008-08-03 02:29:15 UTC
we use libkonq for this functionality.
Comment 2 Jason A. Donenfeld 2008-08-04 09:37:12 UTC
This should be reassigned to the libkonq team.
Comment 3 Peter Penz 2008-08-04 09:44:29 UTC
libkonq team == David Faure :-) @David: please let me know if I can help or should take over this task
Comment 4 David Faure 2008-09-11 10:58:24 UTC
Implemented in KonqOperations, this might fix the bug for the folderview case.

But in "konqueror desktop:/" (where I tried to test it), DolphinView::dropUrls doesn't let us drop a file onto a file, it always drops onto the current directory. Fixed. Ah but then it doesn't call KonqOperations::doDrop but does its own thing. That's a TODO in the dolphin code.
Comment 5 David Faure 2008-09-11 11:01:37 UTC
Created attachment 27368 [details]
dolphinview patch

For Dolphin I have the following patch, but it's not enough (and the if below needs to be adjusted...)
Comment 6 Emmanuel Pescosta 2013-04-10 19:15:05 UTC
It works for me in Dolphin 2.2.
Comment 7 Elvis Angelaccio 2016-12-10 14:13:24 UTC
This seems to work nowadays (and Dolphin switched to KIO::DropJob anyway)