Version: (using KDE 4.0.3) OS: Linux If I resize the preview-bit of the open/save dialogue, because it uses too much space, it does not remember this size. As you can see in the screenshot this forces the user to either increase the size of the whole dialogue or deal with a too small file-list.
Created attachment 24194 [details] screenshot
confirmed here... both the preview pane and the places pane are like goldfish. They grow to fill the availible space. Over time it seems like they get bigger until the file list is unusable. I adjust it back, but the next time I open it its broken again.
Using KDE 4.1.00 (KDE 4.1.0) (KDEmod) in ArchLinux i686: I can reproduce this behaviour. The preview pane size isn't saved or reloaded.
Seems to be fixed in : Version 4.1.62 (KDE 4.1.62 (KDE 4.2 >= 20080814)) kdelibs4.2 svn rev.849324 kdebase4.2 svn rev.849337 ArchLinux 2.6.25-zen2-20080814 i686 I don't know if it's fixed in the KDE4.1.1+ branch
No, it isn't fixed even in KDE4.2 svn . I've reproduce it recently :(
*** Bug 173281 has been marked as a duplicate of this bug. ***
Can anyone still reproduce this bug with a recent KDE version? (4.1.3 / 4.2beta2 / 4.2svn) ? Thanks :) (The file dialogs changed a lot in KDE4.2 :) )
Yes, I can still reproduce this bug with KDE 4.2 Beta2: Start kate, click "Open", scale down the preview part, close the open dialog, open it several times again and watch how the preview part grows bigger and bigger every time until the file list is unusable again.
*** Bug 175591 has been marked as a duplicate of this bug. ***
This bug is still present in KDE-4.2rc1.
This absolutely annoying bug made it's way to the final KDE-4.2. Is this "The Answer"?
Created attachment 30725 [details] Proposed patch @Ronny: can you test this patch ?
That patch avoids the preview widget to grow in size with every opening of the file dialog.
@Peter: acording to the annotations, you wrote the original code. Can you check out my patch? (Debugging this, I discovered that with the original line location , "restorePreviewWidth" was always false (because the size were the same). So the previewWidget didn't got resized to the properly width, and therefore it was increasing its size with each filedialog opening). With my patch, it compares the size after the splitter resize (based on the filedialog size), and resizes the previewWidget correctly ) Thanks
I forgot something: the patch must be applied against kdelibs/kfile/kdiroperator.cpp
Thanks Darío for the patch, it looks OK from my point of view but I want to leave the decision up to Rafael (he is maintaining the file dialog quite a while already and has a better overview about it). I've assigned this issue to Rafael...
I'm sorry for the late reply, I am really busy with university at the moment. The patch looks fine, please go ahead on committing it.
SVN commit 920600 by darioandres: Properly resize the preview-widget on dialog resizeEvent BUG: 160400 M +2 -2 kdiroperator.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=920600
SVN commit 920601 by darioandres: Backport of SVN commit 920600 to 4.2branch Properly resize the preview-widget on dialog resizeEvent BUG: 160400 M +2 -2 kdiroperator.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=920601
> @Ronny: can you test this patch ? Sorry for the late reply. No, I can not test the patch because, unfortunately, I do not have time to build from source, etc. I just tested releases so far. But thankfully it looks like I no not need to test the patch anymore. Thank you Darío, Peter and Rafael!
*** Bug 185764 has been marked as a duplicate of this bug. ***