Bug 159047 - systemsettings' defaults button doesn't work
Summary: systemsettings' defaults button doesn't work
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: System Settings Bugs
URL:
Keywords:
: 159538 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-10 00:23 UTC by Björn 'Fuchs' Krombholz
Modified: 2015-01-21 20:10 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Björn 'Fuchs' Krombholz 2008-03-10 00:23:36 UTC
Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

The Defaults buttons in systemsettings modules seem to have no effect. Especially when you are playing around with a new KDE 4 this is unfortunate.

I'm using a current trunk compiled with kdesvn-build.
Comment 1 Anne-Marie Mahfouf 2008-03-10 14:48:26 UTC
Confirmed in Mouse Cursor themes but it seems to work in other modules. Should the bug be reassigned to the faulty kcm?

Björn, can you test if it works for you in Appearance -> Icons for example? If I set Monochrome and Apply, clicking on Defaults sets the Oxygen theme back and clicking on Apply applies it for me.
Comment 2 Will Stephenson 2008-03-10 15:19:54 UTC
Anne-Marie: yes, the Defaults implementaiton is KCM specific.
Comment 3 Will Stephenson 2008-03-10 15:21:07 UTC
Björn, which module(s)?
Comment 4 Anne-Marie Mahfouf 2008-03-10 15:28:25 UTC
Appearance -> Windows does not work
Appearance -> Theme Manager is very slow, freezes my system so I cannot test it properly
Appearance -> Colors does not work
Appearance -> Style resets the default style but does not enable the Apply button
Appearance -> SplashScreen works OK, so does Appearance -> Fonts
Appareance -> Icons: Monochrome or Crystal SVG does not change anything, are those shipped in kdebase???


I don't have time to check the other modules of System Settings right now but it looks like Defaults is not working often.

Also: the context help for Defaults says "Reset all items to their default values", shouldn't it precise "in that page"? or "in that tab"?
Comment 5 Björn 'Fuchs' Krombholz 2008-03-10 19:15:24 UTC
Went through all of the modules. Below is a list of modules which don't behave as expected, which are less than I thought, but I was mainly playing around with the Appearance and Desktop settings:

Appearance -> Colors -> Scheme                  NO
Appearance -> Colors -> Colors                  NO
Appearance -> Colors -> Effects                 NO
Appearance -> Windows -> Window Decoration      NO/YES [1]
Appearance -> Theme Manager                     NO [2]
Appearance -> Icons -> Advanced                 YES [3]
Appearance -> Style -> Effects                  YES [4]
Desktop -> Desktop Effects -> General           YES/NO [5]
Desktop -> Desktop Effects -> All Effects       NO
Notifications -> System Notifications           NO [6]
Regional & Language -> ...                      YES [7]
Joystick                                        COULDN'T TEST
Keyboard & Mouse -> Mouse -> Cursor Theme       NO
CDDB Retrieval -> Submit                        NO [8]
Service Manager                                 COULDN'T TEST [9]
Login Manager                                   COULDN'T TEST [10]
Samba                                           COULDN'T TEST [10]

[1] works for subsettings of Plastik f.e., doesn't work to reset the style itself
[2] seems to do "something": There is no Theme entry for the default Oxygen. Selecting a theme, then Defaults runs "Updating system configuration", but doesn't actually change anything.
[3] but doesn't save the settings, so you always get the defaults for icon sizes
[4] The first selector is a bit strange: High Res + Low CPU was set when I started system settings, clicking Defaults had no effect on this setting. Changing this setting and then clicking Defaults resets it to the default Low Res + Very High CPU.
[5] works on the main page, but doesn't reset the "Advanced Options"
[6] neither does the Reset button in both tabs
[7] but inconsistent with other modules, because it resets _all_ tabs
[8] method is not reset
[9] crashed the system settings app
[10] su(do) modules don't work.for normal users: settings are disabled but Defaults button is enabled
Comment 6 Will Stephenson 2008-03-17 19:11:13 UTC
Björn: Thanks for your excellent work.  Would you be able to report these separately against the individual systemsettings modules?  That way the authors of each module get notified.  Put 'systemsettings' in keyword search of the module choice page of the bug report 'wizard', and you will see each module.
Comment 7 Björn 'Fuchs' Krombholz 2008-03-18 21:21:31 UTC
Done. Related bugs are: #159536 .. #159543 + #159545

I couldn't find an entry for the CDDB Retrieval module in the bug tracker.


PS: Is there an easy way to link to other related bugs in the comments like in other bug trackers?
Comment 8 George Kiagiadakis 2008-08-21 17:08:44 UTC
For the record... I think bug 159956 is also related. (the defaults button in file associations is always disabled).
Comment 9 David Faure 2008-09-16 18:05:37 UTC
Will, the componentchooser module has implementation of defaults() everywhere, but the button remains disabled. What does the module need to do, for the button to be enabled?
Comment 10 FiNeX 2008-11-14 00:02:31 UTC
What's the status of this issue?
Comment 11 Maciej Pilichowski 2008-11-14 08:54:08 UTC
Just tested mouse module, the problem is still there, "defaults" is enabled but does not work.
Comment 12 Maciej Pilichowski 2008-11-14 08:59:29 UTC
PS. It would be better to split report per module, because even in mouse module defaults works and does not work depending on tab. And it would be not easy to keeping track of single report with multiple issues.

So I suggest closing this one.
Comment 13 Will Stephenson 2008-11-20 11:41:17 UTC
As per #9 i need to check how the defaults button gets enabled, this is a systemsettings core issue.
Comment 14 Anne-Marie Mahfouf 2008-11-26 10:58:00 UTC
People can you look again in a recent trunk build as we fixed most of Default buttons! Only the trickier ones should be left!
Comment 15 Ben Cooksley 2009-05-08 10:01:11 UTC
The following modules now appear to be affected:

Desktop Effects - No change seen
Multiple Desktops - Applies instantly which it shouldn't at least without informing the user -> usability
Screensaver - There are no defaults, but it does cause a category to be selected, but doesn't cause a change
System Notifications - Applications tab doesn't work
Password & User Account - There are no defaults, but it is enabled
Spell Checker - KCMShell doesn't offer Reset button, System Settings does and it works
Proxy - I didn't change anything, but it is enabled, and it makes no change.
Connection Preferences - same as Proxy, but claimed changes were made as well.
Service Discovery - same as Proxy
Local Network Browsing - claims changes by default
Input Actions - Same as Proxy
Mouse - Themes tab didn't work. When resetting previous selection remains ( asking for a crash or incorrect settings being saved )
Standard Keyboard Shortcuts - same as Proxy
Global Keyboard Shortcuts - Didn't test, as it said it was going to revert "all shortcuts" but I didn't know if this was going to be applied -> usability
Multimedia - Same as Proxy ( are defaults even possible? )
Audio CDs - Same as Proxy
CDDB Retrieval - Same as Proxy
Service Manager - Same as Proxy
Session Manager - Same as Proxy
K3bSetup2 - Claimed changes were made on start, Reset didn't stop this, Defaults didn't work

Kamera, Samba, Login Manager and Remote controls were untested
Comment 16 Ben Cooksley 2009-05-08 10:09:43 UTC
Forgot to add: running up to date trunk - revision 964723.
Comment 17 Anne-Marie Mahfouf 2009-05-08 10:41:53 UTC
screensaver Defaults button disabled in commit
http://lists.kde.org/?l=kde-commits&m=124177131723678&w=2

About me, Password tab needs Defaults button to reset at defaults the Password prompt and that works correctly.

The Defaults button is always enabled when there are possible defaults, even if you are in Defaults: I think the KCModule code should be changed to make the Defaults button behave the same than in config dialogs in KDE.
Comment 18 Anne-Marie Mahfouf 2009-05-08 11:16:02 UTC
Messed the CCBUG again, Multiple Desktops Defaults is fixed with
http://lists.kde.org/?l=kde-commits&m=124177337226441&w=2
Comment 19 Ben Cooksley 2009-05-08 11:56:17 UTC
K3bSetup issue has been reported as a different bug: https://bugs.kde.org/show_bug.cgi?id=192017
Comment 20 Anne-Marie Mahfouf 2009-05-08 12:29:22 UTC
System notifications "Defaults" button bug has been reported as a different bug to Olivier Goffard
https://bugs.kde.org/show_bug.cgi?id=192023
Comment 21 Ben Cooksley 2009-05-08 13:05:21 UTC
Forgot to CCMAIL.
Fixed the mouse KCM to set the theme defaults.

http://lists.kde.org/?l=kde-commits&m=124178049502981&w=2
Comment 22 Anne-Marie Mahfouf 2009-05-09 09:40:56 UTC
Left are:
Notifications -> System Notification: reported separately
Regional & Language -> SpellChecker: not reported yet (maintained?)
Sharing: Apply is enabled as default and asks you to confirm any changes while you made none

The Global Keyboard Shortcuts kcm seems to work, it says some key conflicts with another which is probably a problem related to how the shortcuts work and not related to the kcm. To check when global shortcuts work well in KDE.
Comment 23 Ben Cooksley 2009-07-14 04:54:15 UTC
The Sharing KCM seems to be fixed now.
Comment 24 Chao Feng 2013-05-08 12:30:51 UTC
*** Bug 159538 has been marked as a duplicate of this bug. ***
Comment 25 David Edmundson 2015-01-21 20:10:20 UTC
Notifications -> System Notification: reported separately
Regional & Language -> SpellChecker: not reported yet (maintained?)
Sharing: Apply is enabled as default and asks you to confirm any changes while you made none

--
Sharing no longer exists, so that just leaves spellchecker which seems to work.

I'm going to close this as it doesn't seem super useful anymore