Bug 154995 - Lineedit on (some) website is drawn far too small
Summary: Lineedit on (some) website is drawn far too small
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: 4.4.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 172915 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-01-02 22:44 UTC by S. Burmeister
Modified: 2013-05-11 21:10 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.10.4


Attachments
screenshot (13.09 KB, image/png)
2008-01-02 22:45 UTC, S. Burmeister
Details
testcase (947 bytes, text/html)
2013-03-09 23:18 UTC, Andrea Iacovitti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description S. Burmeister 2008-01-02 22:44:06 UTC
Version:            (using KDE Devel)
OS:                Linux

The lineedit on imageshack.us is drawn far too small, see attached screenshot.
Comment 1 S. Burmeister 2008-01-02 22:45:26 UTC
Created attachment 22810 [details]
screenshot
Comment 2 Tommi Tervo 2008-01-03 08:44:35 UTC
Which revision do you have? Spart fixed similar bug while ago, see
http://bugs.kde.org/show_bug.cgi?id=153570
Comment 3 S. Burmeister 2008-01-03 13:41:11 UTC
> ------- Which revision do you have? Spart fixed similar bug while ago, see
> http://bugs.kde.org/show_bug.cgi?id=153570


This is current svn from. I just recompiled everything and it is still that 
way on imageshack.us.

Google.com looks ok, so I do not think that I miss the patch you have in mind.
Comment 4 FiNeX 2008-01-05 11:57:40 UTC
Confirmed.
Some weeks ago ALL lineedit was too small.

After the fix on bug #153570 a lot of lineedit was fixed, but some aren't.

Imageshak is a valid example.
Comment 5 FiNeX 2008-01-05 12:08:12 UTC
After some test I've found that this problem is caused by the CSS style of the "input" element.
In imageshack, for example, we have something like this:

<input type="file" style="height:20px" />

The little "height" value cause lineedit be so small.





P.S: Why if I set "height:40px" I measure 20px with kruler? And if I set 60px, kruler measure 30px?
Comment 6 Christophe Marin 2008-06-01 16:59:19 UTC
Still present in trunk (svn rev. 815196)
Comment 7 S. Burmeister 2008-09-21 12:53:20 UTC
Another website to test this: https://direkt.postbank.de/

Still fails in 4.1.1
Comment 8 Marcel Hasler 2008-10-27 16:14:47 UTC
Same in 4.1.2. Another example for a page that's nearly unusable is www.bahn.de.
Comment 9 Dario Andres 2008-12-21 00:51:59 UTC
*** Bug 172915 has been marked as a duplicate of this bug. ***
Comment 10 Richard Bos 2009-01-02 16:25:56 UTC
There are many more websites showing this, e.g.:
http://route.anwb.nl/routeplanner/
or
https://webmail.bhosted.nl:443/src/login.php

http://www.ponyparkcity.nl/nl/tarievenlijst.php -> select "reserver nu!"
The value fields for "Land" and "Huisjes" are too small
From the same site: http://www.ponyparkcity.nl/nl/vakantiehuisjes.php?id=2&subid=10
The popup windows "verblijfsduur" en "aankomstdatum" are too small.

This is with openSUSE_11.1 and kde-4.1.86 rpms.
Comment 11 Ralf Haferkamp 2009-06-19 10:44:00 UTC
Still present in KDE 4.3 Beta2
Comment 12 Russ Fineman 2010-01-14 00:38:34 UTC
search bar size marked as duplicate of this (215071). Problem still exists in 4.3.4 release 2. usin same webpage mentioned. Also appears when other KDE applications Like dolphin use Konqueror format.
Comment 13 Russ Fineman 2010-02-16 18:49:33 UTC
added this to 215071 by mistake today. Problem still exists in KDE 4.4 nad may also be occurring in OpenOffice 3.2.0 on both openSUSE 11.2 (KDE4.3.5 release 3) and 11.3 (KDE 4.4). Will check on OpenOffice issue.
Comment 14 Richard Bos 2012-01-03 16:38:43 UTC
Those 2 (from comment #10) are working okay now:
http://route.anwb.nl/routeplanner/
or
https://webmail.bhosted.nl:443/src/login.php

This one http://www.ponyparkcity.nl/nl/vakantiehuisjes.php?id=2&subid=10 (from comment #10 as well), is still small.
Comment 15 Andrea Iacovitti 2013-03-09 23:18:55 UTC
Created attachment 77896 [details]
testcase

I think the problem is in that KHTML fails to determine the correct size of form elements with native border (no css border specified)  and box-sizing=content-box.
The content size includes, wrongly, the border too
Comment 16 Andrea Iacovitti 2013-05-11 21:06:02 UTC
Git commit 6b4178b727c8c89ac3be6b3ffd76d37b480e2eac by Andrea Iacovitti.
Committed on 11/05/2013 at 22:55.
Pushed by aiacovitti into branch 'KDE/4.10'.

Include border thickness when calculating the size of widget that have
its content size specified by the style (box-sizing=content-box, no css
border, no auto size).
Works well for every widget/style, except for oxygen button for which the
retrieved nativeBorderWidth is so far too small (1px).

M  +3    -3    khtml/rendering/render_box.h
M  +24   -0    khtml/rendering/render_form.cpp
M  +2    -0    khtml/rendering/render_form.h

http://commits.kde.org/kdelibs/6b4178b727c8c89ac3be6b3ffd76d37b480e2eac