Bug 125689 - [PATCH] "Various Artists" only appears at top level of collection
Summary: [PATCH] "Various Artists" only appears at top level of collection
Status: RESOLVED INTENTIONAL
Alias: None
Product: amarok
Classification: Applications
Component: Collection Browser (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 137494 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-16 20:53 UTC by Iain Benson
Modified: 2008-03-29 12:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to enable Various Artists at all levels (22.76 KB, patch)
2006-04-16 20:55 UTC, Iain Benson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Iain Benson 2006-04-16 20:53:42 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

When the collection is display in tree view with artist at the top level, all the artists on albums marked as compilations are grouped into a "Various Artists" section, this does not occur when artist is at the second or third level.

I've attached my patch to collectionbrowser.cpp which adds this functionality.
Comment 1 Iain Benson 2006-04-16 20:55:31 UTC
Created attachment 15642 [details]
Patch to enable Various Artists at all levels
Comment 2 Ben Johnson 2006-09-29 00:08:07 UTC
Bugs 125837, 132209, and 125689 seem related. 125689 has a patch. Maybe a developer could review that? 
Comment 3 Mark Kretschmann 2006-11-25 14:32:02 UTC
*** Bug 137494 has been marked as a duplicate of this bug. ***
Comment 4 munlinux 2007-06-08 14:39:20 UTC
*** This bug has been confirmed by popular vote. ***
Comment 5 munlinux 2007-06-08 14:47:14 UTC
Actually, re-reading the original report, I'm removing my votes for this bug...

If I understand the original report's intention right, what I'd like to happen is the complete opposite of this patch:
- If I sort by ARTIST only (i.e. not ARTIST / ALBUM), I'd like all the separate artists be shown, and songs from compilation albums should NOT be lumped together under the "Various artists" heading.
- If I sort by ARTIST / ALBUM, the current behaviour is good, i.e. separate compilation albums are shown under "Various artists".

The original report is right about one thing - if the artist is something else than the 1st criterion, this works. That is, sorting by GENRE / ARTIST, or even GENRE / ARTIST / ALBUM works right.
Comment 6 Ian Fyffe 2007-06-23 03:26:20 UTC
So is anything happening with this?  Ive been wanting to sort by genre/artist/album since 1.4.3, but I can't as I have too many VA albums, and it all becomes a big mess.

genre/artist/album sorting should group VA albums together.
Comment 7 John Atkinson 2007-08-01 18:47:40 UTC
I definitely agree that this should be fixed. 

It's not only annoying but also confusing that "Genre / Artist / Album" will not group using various artists but "Artist / Album" will.

For the behaviour wanted in comment #5, isn't that the point of having the ability to choose which tracks are grouped as "Various artists" via the right-click menu?
Comment 8 Matthew Rothman 2007-10-08 13:12:59 UTC
This is my biggest annoyance with amarok at the moment, I like to view my collection as "Genre / Artist / Album" but cannot as compilations make doing so horrible.
Comment 9 Ian Fyffe 2008-02-01 14:53:58 UTC
Ok, so what else can we do?
Someone offered a patch and that wasn't enough..

This bug has been open for nearing two years now, with a simple solution.

Honestly. PLEASE someone tell me what I can do and I'll find a way to do it.  I just don't want to have to apply a patch to each version of Amarok I use.
Comment 10 Georg Sauthoff 2008-03-29 10:45:20 UTC
I always likes the grouped by 'Genre / Artist / Album' setting. But with more and more VA soundtracks and such this gets annoying. It is even more annoying that I have to switch between 'Genre / Artist /Album' and 'Genre / Album' all the time.

The most annoying thing is, that the 'Show under Various Artists' is mislabeled in Amarok 1.4.7. It should spell 'Show under Various Arists if and only if the collection view is grouped first by Artist'.

Basically I am saying the same as comment #6.
Comment 11 Maximilian Kossick 2008-03-29 12:17:45 UTC
I consider the patch way to intrusive to apply to Amarok 1. It touches code which is better left alone. By the way, this is actually fixed properly in Amarok 2 already.