Bug 114195 - Collection build does not include accented artists, albums or tracks
Summary: Collection build does not include accented artists, albums or tracks
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.3.3
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 114314 114509 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-10-10 22:35 UTC by Graham Murray
Modified: 2006-12-06 14:50 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Murray 2005-10-10 22:35:19 UTC
Version:           1.3.3 (using KDE KDE 3.4.2)
Installed from:    Gentoo Packages
Compiler:          gcc 3.4.4 
OS:                Linux

Since upgrading to 1.3.3, rebuilding the collection omits all artists, albums and tracks with non 7-bit ASCII characters. These were present after upgrading from 1.3.2 and were removed the first I rebuild the collection after upgrading to 1.3.3. My locale is en_GB.UTF-8 and the directories/files contain utf-8 characters. The tracks are still in the playlist, but says the file is not in the collection. All of the directories show correctly in the 'configure collection' folder list.
Comment 1 kdebugs 2005-10-11 19:37:37 UTC
Also using en_GB.UTF-8. amaroK reads the non-ascii directories, but if the filename contains something 'special', the track gets ignored.

I have a non-ascii (japanese in utf8) directory name including both ascii only filenames and some filenames with japanese in UTF8. The japanese filenames get ignored on both "dcop amarok collection scanCollection" and "dcop amarok collection scanCollectionChanges". They are read on 1.3.2, and used to work on recent SVN revisions between 1.3.2 and 1.3.3. The ascii only filenames in the same directory get added to the collection without problems.

"dcop amarok collection scanCollectionChanges" doesn't remove those filenames that are already on the collection, but doesn't add new ones. "dcop amarok collection scanCollection" removes all the 'offending' filenames (and thus the track, album, or the artist altogether) from the collection.

This is quite fatal to me and my collection, so downgrading to 1.3.2...
Comment 2 Mark Kretschmann 2005-10-13 08:17:28 UTC
*** Bug 114314 has been marked as a duplicate of this bug. ***
Comment 3 Mark Kretschmann 2005-10-13 08:30:12 UTC
Dirk, could it be a regression from your patch? I can't remember anything else we've changed concerning Collection reading from 1.3.2 -> 1.3.3.
Comment 4 Dirk Mueller 2005-10-13 14:24:01 UTC
SVN commit 470241 by mueller:

make non-ascii work again
CCMAIL: 114195-done@bugs.kde.org


 M  +1 -1      collectionreader.cpp  


--- trunk/extragear/multimedia/amarok/src/collectionreader.cpp #470240:470241
@@ -275,7 +275,7 @@
 
         incrementProgress();
 
-        const QString path = it.current();
+        const QString path = QFile::decodeName ( it.current() );
         KURL url; url.setPath( path );
         const QString ext = amaroK::extension( path );
         const QString dir = amaroK::directory( path );
Comment 5 Alexandre Oliveira 2005-10-16 16:22:46 UTC
*** Bug 114509 has been marked as a duplicate of this bug. ***
Comment 6 Jyri Turkia 2005-10-22 12:47:06 UTC
Well this is nice, i have same problem with suse 10.0 and can't find collectionreader.cpp
Comment 7 Dirk Mueller 2005-10-24 07:32:20 UTC
there's an online update scheduled for suse. just install it. 

Comment 8 Graham Murray 2005-10-24 20:09:12 UTC
I am seeing the same problem with 1.3.4 which has the fix in #4 applied.
Comment 9 Graham Murray 2005-10-25 23:29:26 UTC
My apologies, it looks like the problem I see with 1.3.4 and 1.3.5 is not this problem though the symptoms initially looked similar.
Comment 10 Ilya Petrov 2005-11-08 18:33:14 UTC
1.4-svn478977 - the same problem!
Comment 11 Jose Carlos Garcia Sogo 2006-12-06 14:50:32 UTC
I have a similar problem with 1.4.4. Files under directories with special characters are not being listed in collection, though it seems that they are being collected (by collection_scan.files file)