Bug 113899 - [PATCH] away/personal messages in listview when contact photos are enabled
Summary: [PATCH] away/personal messages in listview when contact photos are enabled
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: Contact list (other bugs)
Version First Reported In: SVN
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
: 177363 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-10-05 16:48 UTC by Seb Ruiz
Modified: 2009-09-18 23:44 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Patch to show personal message in 2nd line of LVI (1.47 KB, patch)
2005-10-07 17:12 UTC, Seb Ruiz
Details
Screenshot of patch in action (18.45 KB, image/jpeg)
2005-10-07 17:13 UTC, Seb Ruiz
Details
Add/changes options to allow for a more flexible configuration of the contact list (12.53 KB, patch)
2008-12-10 21:53 UTC, Benson Tsai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Seb Ruiz 2005-10-05 16:48:08 UTC
Version:           SVN (using KDE Devel)
Installed from:    Compiled sources

It is possible to see the away message in the list view when [x] Detailed view is checked in the appearance settings.  This is visualised as follows:

 _______________________________
|@@@ Nickname                   |
|@@@ Away/Personal Message      |
|@@@_&&_________________________|

Where && is the protocol icon

However, when using the option
[x] Use contact photos when available, without detailed view, the klistviewitem size becomes 2 lines, sufficient for showing both the nickname and the away/personal message.

The current setup is:
 ______________________________
|@@ Nickname                && |
|@@____________________________|

I dont see any reason to omit the personal message, such that the klistviewitem becomes:
 ______________________________
|@@ Nickname                && |
|@@_Away/Personal Message______|

Thanks,
Seb
Comment 1 Matt Rogers 2005-10-05 17:23:38 UTC
Do you have a suggestion for those people who use right aligned view and
also show photos? Left aligned might look the same as detailed view
when showing photos (I haven't checked) but i know that right-aligned
protocol icons with photos looks very different when you 
compare detailed view to right-aligned protocol icons w/ photo.
Comment 2 Conrad Hoffmann 2005-10-05 17:28:14 UTC
Isn't the point of the _detailed_ view to show the away message, which would make the point of the other view to _not_ show the away message? i think that behaviour should if anything be optional. maybe a better way would be an option for how big the pictures are displayed?
Comment 3 Seb Ruiz 2005-10-06 00:40:45 UTC
@Matt:
I am actually using right aligned view, showing photos.

The only difference b/w left & right aligned view is the location of the protocol icon (against the text, or against the right border).  Again, the effect of showing the contact photo is only to enlarge the contact icon, show the photo and add an extra line of text.

@Conrad:
Yes, except the point is, that an extra line is used for showing protocol icons, which imho is not necessary (they could still be shown next to the nickname.  Having 3 lines as opposed to 2 makes a big difference with a largish contact list.

I'd be happy if you simply took away the third line from detailed view and moved the icons like left/right aligned.

Hence the set of options could look like:

[o] Left Aligned Icons
[o] Right Aligned Icons
[x] Show details
[x] Show photo

This way the number of options is not changed, the flexibility increases and I am happy! :-)
Comment 4 Seb Ruiz 2005-10-07 17:12:16 UTC
Created attachment 12908 [details]
Patch to show personal message in 2nd line of LVI
Comment 5 Seb Ruiz 2005-10-07 17:13:58 UTC
Created attachment 12909 [details]
Screenshot of patch in action

Screenshot of attachment 12908 [details] in action, with a variety of different contact
information cases shown (w & w/o photo, w & w/o personal msg)
Comment 6 Seb Ruiz 2005-10-07 17:19:32 UTC
The patch will show the away/personal message in the second line of text if and only if the contact photo is also shown.  

Works for both left and right aligned protocol icons, and doesn't touch detailed view.
Comment 7 Conrad Hoffmann 2005-10-08 19:28:11 UTC
please don't get me wrong. i think your way is a totally valid option that should be implemented. But now there would be no way for people to _not_ show the away message, if they want to use pictures! rather, it should be implemented as option for the detailed mode. i use the word option quite on purpose, because i for example like the pictures as big as they are in detailed mode.
other than that, i have no objections to that patch, as i don't use that mode. but i would vote for implementing a little more flexible (but still as easy as possible) configuration for that stuff...
i guess like one additional checkbox might be ok. what do others think?
Comment 8 Seb Ruiz 2005-10-09 01:25:54 UTC
Yes, you are entirely correct.  I whipped up this patch in 5 minutes just to demonstrate what I meant, and because I wanted it done for myself!
Comment 9 Benson Tsai 2008-12-10 21:52:24 UTC
I feel like I'm raising the dead but it would be nice to configure the contact list to be able to hide/show details as well as size. For people with a long contact list, the more compact the better. That being said, there are probably people who like bigger images and do not mind the additional space taken up per contact. So I propose the following:

size: [small/medium/large]
[ ] left aligned icons
[x] show details
[x] show photo

Where size is a drop down menu. Left aligned icons will just make the icons align left as opposed to right. Lastly, show photo... will show the photo if available.

The result will be this (assuming left unticked, details ticked, and photos ticked):

small:
|@ Nickname Away/Persona.. && | 

medium:
|@@ Nickname               && | 
|@@ Away/Personal Message     | 

large:
|@@@ Nickname                 | 
|@@@ Away/Personal Message    |
|@@@                       && |

-----

And again just for a bit more completeness with left ticked, details unticked, and photo ticked:

size: [small/medium/large]
[x] left aligned icons
[ ] show details
[x] show photo

small:
|@ Nickname &&                | 

medium:
|@@ Nickname &&               | 
|@@                           | 

large:
|@@@ Nickname                 | 
|@@@ &&                       |
|@@@                          |

---

To finish it off (covering most cases), left, details, and photo all ticked with small selected:

size: [small]
[x] left aligned icons
[x] show details
[x] show photo

|@ Nickname && Away/Person... | 

Although I don't expect people to have large photos with right aligned status icons, it is a possibility. This way all of the original 3 configurations can be obtained and a good handful of other ones can as well. Of course the one I'm most interested in is small/right aligned/details/photo.
Comment 10 Benson Tsai 2008-12-10 21:53:27 UTC
Created attachment 29223 [details]
Add/changes options to allow for a more flexible configuration of the contact list
Comment 11 Benson Tsai 2008-12-12 16:52:05 UTC
*** Bug 177363 has been marked as a duplicate of this bug. ***
Comment 12 Seb Ruiz 2009-04-16 08:41:17 UTC
*bump*
Kopete devs: any update on this?
Comment 13 Benson Tsai 2009-04-16 09:19:07 UTC
The new model/view contact list can pretty much get any of the above configurations.

I would mark as closed.
Comment 14 Matt Rogers 2009-09-18 23:44:08 UTC
If the new model/view contact list stuff doesn't take care of this for you, reopen this bug or file a new bug (take your pick) :)