Summary: | Please implement rounded file selection | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kdelibs | Reporter: | Davide Ferrari <vide80> |
Component: | kstyle | Assignee: | Karol Szwed <gallium> |
Status: | RESOLVED WORKSFORME | ||
Severity: | wishlist | CC: | kde |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Patch to implement rounded corners
A Faster patch for rounded selections A patch for rounded selections on the desktop snapshot18.png |
Description
Davide Ferrari
2004-05-17 23:13:27 UTC
Created attachment 6265 [details]
Patch to implement rounded corners
Ok, here's a patch to do what you were asking for. I basically ripped the code
straight out of albumshaper, which is GPL so that should be ok.
It doesn't do rounded corners on the desktop though, because it currently
blends a single background colour with the selection colour, and I couldn't be
bothered to make it blend with an image. I wrote a patch for
kfileividesktop.cpp which did the same thing, but it doesn't look right on an
image background, so I haven't included it here. I could write a more complex
version if it's wanted and I have the time.
You were really kind, thanks! If you can work more on this issue, implementing it even on image backgrounds, it would be really perfect! And please commit it to the official KDE devel branch, I hope it would be accepted...anyway, thanks again, you rock! Created attachment 6287 [details]
A Faster patch for rounded selections
This is a much faster rounded corner drawing method.
Created attachment 6288 [details]
A patch for rounded selections on the desktop
This has the same effect as the other patch, but it works on the desktop
properly when there's an image behind.
It's not very nice code, but does seem to work.
The example looks awful. Would you please attach a screenshot of how this new file selector should look like (but only a small one (max. 640x480), not at 1920x1600)? Very cool to have it implemented !!!!! I've used a few GNOME and it has it by default. It's so beautifull and slick ! A chance to have it integrated to KDE 3.3 ? Another question : is it possible to also have a beautifull region selection (click on an empty place and drag to draw a rectangle that select a lot of icons) ? As the GNOME (or Windows xp) one : solid rectangle (selection color : typically blue) and semi-transparent filled (half-blue) ? It's eye candy (so, important for adoption of Linux/KDE by "the masse") BUT also an usability issue : we see better what is selected. Am Mittwoch 09 Juni 2004 19:03 schrieb James Ots:
> It's not very nice code, but does seem to work.
The drawing of the focus is incorrect on some items. I attach a screen shot.
Otherwise I like the look and I think it should be in 3.3
Greetings, Stephan
Created an attachment (id=6293)
snapshot18.png
Sebastien: See Bug 47633 for the region selection stuff. Since people seem to like it, I'll work a bit harder on it and iron out any faults. See y'all in a few days :-) Actually, that dodgy looking dotted box is happening in 3.2.2 without my rounded corner code. I'll have a look at it though and see if I can fix that too, since my head is full of that code at the moment. The FocusRect painting appears to be a bug in QT - I created a QIconView and it exhibits the same behaviour. It is now Bug 83167. Erm, wouldn't it be better for styles to be able to handle this (e.g, implement this in kstyle as well) James, any news about this topic? Well, there are patches applied by distro (i.e. Ubuntu, Suse) and KDE is going the 4 way. Closing this wish, even if it's not resolved upstream. |