Summary: | bookmark comments (keywords) should be searched as well | ||
---|---|---|---|
Product: | [Applications] keditbookmarks | Reporter: | Rick Reumann <rick> |
Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 4.0 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Rick Reumann
2003-01-11 17:58:04 UTC
I second this, this is a MUST HAVE feature and I was very suprised not to find it in Konqueror. The Search bookmarks feature in Mozilla's Bookmark manager is fantastic and includes a bunch of filters to make your search more effective. You can even save the query. For example I search for bookmarks containing the word KDE and lets say I find one. KDE.org. I save this search and it becomes a folder, the cool thing is that once I add more KDE bookmarks they will all pile up in that folder. I use this style filters for most of my bookmarks and I never have to organize them with Mozilla's awesome filters tehy go where I want them to from the start!! Konqueror needs a killer feature like this. KDE in CVS has a search bookmarks feature (like Mozilla) as well as the possibility to add comments to bookmarks. Unfortunately the search ignores comments. (aka keywords) This makes comments almost useless as keywords == bug. This is not a konqueror bug... thanks moritz i'll fix this soon Alex Are you sure it has a search features as powerful as Mozilla? Mozilla 's search feature is like this: Find bookmarks whose: Dopdown menu 1 here Dropdown menu 2 here _____space for input___________ [name] [contains] [location] [starts with] [description] [ends with] [keyword] [is] [is not] [dosen't contain] _____________________________________________________________________________ [] save query _____________________________________________________________________________ 4 x 6 = 12 Therefore, from the dropdown menus you have 12 fields of criteria, not to mention the input field. The save query function is also phenomenal. It allows your bookmarks to organize THEMSELVES. For example I can save a query for items locations which contain the term KDE. Now, all my bookmarks whcih have a url that contains KDE will be organized into a single folder and any items I add in the future will be addted to that folder. This means that all my messy KDE urls such as bugs.kde.org, kde-look.org, dot.kde.org, developer.kde.org, apps.kde.com, kdedevelopers.org, kde-forum.org etc. will be placed in one folder called Find "KDE". Of course, the search function is only one of many of Mozilla's bookmark manager features. If KDE developers have really managed to add sucha comprehensive and yet still simple search feature I am very impressed. If not, evena simple search is a good step forward. Subject: kdebase/konqueror/keditbookmarks CVS commit by lypanov: enable searching on comment field CCMAIL:52884-close@bugs.kde.org M +2 -2 search.cpp 1.28 --- kdebase/konqueror/keditbookmarks/search.cpp #1.27:1.28 @@ -22,4 +22,5 @@ #include "listview.h" #include "search.h" +#include "commands.h" #include <qregexp.h> @@ -85,6 +86,5 @@ void KBookmarkTextMap::update() void KBookmarkTextMap::visit(const KBookmark &bk) { if (!bk.isSeparator()) { - // todo - comment field - QString text = bk.url().url() + " " + bk.text(); + QString text = bk.url().url() + " " + bk.text() + NodeEditCommand::getNodeText(bk, "desc"); m_bk_map[text].append(bk); } Will someone inform me on this. Is the search feature as powerful as in Mozilla 1.5? I have no clue about Mozilla 1.5, but Konqueror-cvs's search feature looks to be pretty much similar to MozillaFirebird 0.7/Mozilla pre-1.6 Oh, that's too bad, Firebird's feature is pathetic compared to Mozilla 1.5. Also, it doesen't matter if you have a clue about Mozilla 1.5 or not, waht do you think I typed a whole page describing Mozilla 1.5's advanced search features for!!! Please read it and tell me. |