| Summary: | Long sound start system notifications cutted on system start | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kdelibs | Reporter: | Krzysztof <kw.pl> |
| Component: | knotify | Assignee: | Olivier Goffart <ogoffart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, bugs.kde.org, christian.gonzalez, doc.evans, dorian.nagel, einmaladresse_2, enrydeejay, fredcwells, jeawithlove, kretz, nbgi85, solstice.dhiver, sven.burmeister, tadcraig |
| Priority: | NOR | ||
| Version: | 4.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | delays close()ing the sound by 1 minute | ||
|
Description
Krzysztof
2008-02-14 09:07:22 UTC
Using KDE 4.1.1 (KDE 4.1.0 (4.1 >= 20080722)) (KDEmod) in ArchLinux i686 phonon 4.2.0 using xine-lib 1.1.14 Audio device: Intel Corporation 82801H (ICH8 Family) HD Audio Controller (rev 02) Chip/Codec: SigmaTel STAC9228 on a Dell Inspiron 1525 I can confirm this bug. The startup sound is cutted. The same here (4.1.1 on open SUSE). Logout sound works fine. However, all other, even short sounds (e.g. mail notification) are also chopped short. Using the xine and the gstreamer backend. I can also confirm this bug. For me, noticeable mostly only KDE startup. Audio is cut short. Cutoff point varies. (In reply to comment #0) > Version: 4.0.1 (using KDE 4.0.1) > Installed from: Ubuntu Packages > OS: Linux > > The long sound of start the system has been cuted on system start. > (In reply to comment #3) > I can also confirm this bug. For me, noticeable mostly only KDE startup. > Audio is cut short. Cutoff point varies. > I can confirm this bug.On stat of kde 4.1 sound cute short.Not the same when I kill X and reload kdm (ctrl + <---- ). With the following patch to kdelibs/kdeui/util I get to hear the startup sound most of the time. For some reason, on startup, 6 seconds is not a long enough timeout. Might be the sum of knotifyd startup + backend loading and initialization that's taking too long.
Is there any reason why this can't be a very long timeout? Like a few minutes or so? Or is this the same timeout for making passive popups disappear again?
Index: knotification.cpp
===================================================================
--- knotification.cpp (revision 860781)
+++ knotification.cpp (working copy)
@@ -327,7 +327,7 @@
if(!(d->flags & Persistent))
{
- QTimer::singleShot(6*1000, this, SLOT(close()));
+ QTimer::singleShot(10*1000, this, SLOT(close()));
}
if (KNotificationManager::self()->notify( this , d->pixmap , d->actions , d->contexts , appname ))
d->id = -1;
*** Bug 164748 has been marked as a duplicate of this bug. *** *** Bug 170797 has been marked as a duplicate of this bug. *** Created attachment 27942 [details]
delays close()ing the sound by 1 minute
Apply this patch to kdebase/runtime/knotify and passive popups will continue to have a 6s timeout but sounds now will have 66s, long enough for the startup sound...
I don't consider this a solution, but a workaround that could be applied as long as nobody has the time to work on a real solution.
*** Bug 173353 has been marked as a duplicate of this bug. *** *** Bug 174708 has been marked as a duplicate of this bug. *** *** Bug 175684 has been marked as a duplicate of this bug. *** SVN commit 887719 by mkretz: hack sound notifications to delay calls to close by 1 minute. This "fixes" the startup sound which got cut off by the hardcoded timeout of 6 seconds - now it's hardcoded to 1:06. BUG: 157810 M +12 -1 notifybysound.cpp M +1 -0 notifybysound.h WebSVN link: http://websvn.kde.org/?view=rev&revision=887719 Extending a timeout has never been a fix... Why is this bug in "fixed" status ? Why not removing the timeout ? Vincent, it's the timeout that closes the passive popups. Remove the timeout and you have to close all notification popups manually. Why is this bug in "fixed" status? Because the startup sound plays back in full length. The remaining timeout is a safety measure against accidental leaks. Do you still have problem with the startup sound? The sound seems to be good in KDE 4.2 RC, but KDE 4.1.4 is still affected! That should be fixed in KDE 4.1 too, as in e.g. Kubuntu people have a clutchy startup sound until summer (next KDE/Kubuntu version). It's, like so many bugs, very small work for very much change in look&feel (&hear). @Christian: it seems that the fix didn't get backported to 4.1.x. However there won't be a 4.1.5 release, so you'll have to wait until 4.2 (release later this month) *** Bug 186437 has been marked as a duplicate of this bug. *** |