Version: 1.7.2 (using KDE KDE 3.3.2) Installed from: Gentoo Packages Compiler: gcc 3.3.5 Gentoo Linux 3.3.5-r1, ssp-3.3.2-3, pie-8.7.7.1 OS: Linux Use Anti-SPAM Wizard to create filter rules for spam. Note that icons show up in tool bar to mark as Spam or as Ham. I configured filters for bogofilter, spamassassin and also for gmx. I have hand modified each filter to make the "move to folder" for each target a separate folder so I can tell how successful each of the spam filter applications is. Open the Configure Toolbars dialog. Without clicking on anything in the dialog, IMMEDIATELY the icons for "mark as SPAM" and "mark as HAM" disappear without even clicking Apply, etc. This is strange (and probably a bug), but not the true issue here. In the Configure Toolbars dialog, drag the "ActionList: toolbar_filter_actions" item anywhere in the toolbar list (i.e., move it up above the last item, etc.). The item disappears (and we were previously warned that it can't be brought back) even though I didn't remove it, I simply dragged it to another point in the live toolbar list. Also, just adding another item anywhere in the toolbar (e.g., to mark items as Important) and the SPAM/HAM toolbar buttons are now gone. I can't tell if some setting specific to my kmail preferences is causing this or not. I would be happy to supply additional information if this is useful.
Confirmed. I don't know exactly if this can be fixed in KDE 3.4 at all, the issue depends heavily on features in kdelibs. Let's see.
CVS commit by gungl: Avoid "conserve memory" when using dynamic actions. BUGS: 98715 M +1 -1 kmmainwin.cpp 1.604 --- kdepim/kmail/kmmainwin.cpp #1.603:1.604 @@ -136,5 +136,5 @@ void KMMainWin::slotEditToolbars() void KMMainWin::slotUpdateToolbars() { - createGUI("kmmainwin.rc"); + createGUI("kmmainwin.rc", false); applyMainWindowSettings(KMKernel::config(), "Main Window"); }
Danke Andreas. That solves the problem of the item disappearing when you move it. I can now move the icons for the SPAM/HAM buttons anywhere on the toolbar. However, the icons disappear from the toolbar when the Configure Toolbars dialog is displayed (for example, by right clicking on the toolbar). I can move the "ActionList: toolbar_filter_actions" item within the list and the icons reappear (in the proper new place) when I close the dialog. People might be confused by the icons disappearing while the dialog is up. Can this be fixed as well? Should it be under a separate bug?
CVS commit by gungl: As requested for better usability. Limit the hiding of the dynamic toolbar icons to a minimum. BUG: 98715 M +7 -5 kmmainwin.cpp 1.605 --- kdepim/kmail/kmmainwin.cpp #1.604:1.605 @@ -120,7 +121,4 @@ void KMMainWin::displayStatusMsg(const Q void KMMainWin::slotEditToolbars() { - // remove dynamically created actions before editing - mKMMainWidget->clearFilterActions(); - saveMainWindowSettings(KMKernel::config(), "Main Window"); KEditToolbar dlg(actionCollection(), "kmmainwin.rc"); @@ -130,12 +128,16 @@ void KMMainWin::slotEditToolbars() dlg.exec(); - // plug dynamically created actions again - mKMMainWidget->initializeFilterActions(); } void KMMainWin::slotUpdateToolbars() { + // remove dynamically created actions before editing + mKMMainWidget->clearFilterActions(); + createGUI("kmmainwin.rc", false); applyMainWindowSettings(KMKernel::config(), "Main Window"); + + // plug dynamically created actions again + mKMMainWidget->initializeFilterActions(); }
Excellent work. This seems to solve all of my issues. Thanks.
*** Bug 99709 has been marked as a duplicate of this bug. ***
*** Bug 94181 has been marked as a duplicate of this bug. ***
Are you sure 99709 is a duplicate? There is no obvious similarity - the buttons never disappear when the toolbar dialog is in use. They just don't _reappear_ when Kontact is restarted.
I'm quite sure, as I have coded this functionality. ;) The problem in KDE 3.3 was a general one. We had realized too late that the dynamic toolbar icon handling for the filters had created technical problems. Due to the freeze policy for KDE branches, I was not able to extend the GUI and underlaying functions in a way which had allowed to solve all those problems. I could work around some things, but a general cleanup was possible only for KDE 3.4 which will be out soon. I've marked the reports as duplicates because technically they rank all about the same problem, even if the visible symptoms have been different. Anyway, enjoy KDE 3.4 and Kontact, and of course, feel free to reopen any report if you can reproduce it with the new version. We're programmers, not God, that's why we make errors sometimes. :)