Bug 98651 - image editor tool filter based on clens
Summary: image editor tool filter based on clens
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-LensCorrection (show other bugs)
Version: 0.7.2
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-05 22:53 UTC by Thorsten Schnebeck
Modified: 2022-01-18 16:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Schnebeck 2005-02-05 22:53:43 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

Hi,

digicam-cvs has these days some imageplugins to correct lens distortion. On Windows there is the nice PTLens freeware to correct automatically this type of distortion by naming the camera or the lens.

For Linux there is now a command line version for PTLens called clens which does the same but there is a GUI missing. It does not look too complex to KDEify the whole program cause most parts of the program is something digikam/KDE has a already done:
clens reads command line parameter like image name and lens name, searches the lens correction parameters in a textfile database (the same db PTLens uses!) generates a transformation file for ptstitcher or nona, calls one of these programs and copy the exifdata to the resulting image by using code from jhead.

This works but digikam can do it better :-)
- database import/update from PTLens website
- user database of frequently used lenses
- matching used lens by exifdata
(old problem: libexif is not good enough for this, exiftool has no problems to detect the lenstype from exif: Tag-"from-to" or Tag-"fixed")
- generating transformation list
- calling external transformation program
- ready

Some links:
http://epaperpress.com/ptlens/
http://panotools.sourceforge.net/
https://sourceforge.net/projects/panotools/
http://www.sno.phy.queensu.ca/~phil/exiftool/ (no, I don't get money for continues promotion of exiftool :-))

Bye

  Thorsten
Comment 1 Maxime Delorme 2005-02-06 11:09:27 UTC
In the linux's world there is no easy stitcher. I think I should be feasible to do it because it exists on Win world (I've tested one provided by my Canon Camera).
So it's probably the fist step to do one.
See http://rbpark.ath.cx/articles.html that seems provide the easyest solution (I looking for such tools for long) by using : 
autopano-sift : http://user.cs.tu-berlin.de/~nowozin/autopano-sift/, 
hugin : http://hugin.sf.net/, and 
enblend : http://enblend.sourceforge.net/.

It's seems easier with that tutorial but you always need 3 programs, for me it's not an easy task.

It's should be an idea for a new digikam image plugin (even if it use more than one images ?) to create easily panoramic picture.
Comment 2 Thorsten Schnebeck 2005-02-06 12:34:11 UTC
No, no, no - this is not about stitching images together, this is about lens distortion correction of a single image. Have you tried clens? It uses libpano cause Prof. Dersch developed this lib in a very generic way that is useful for many things. Please look at the website from PTLens to see what I mean.

If you want an easy pano-stitcher you should use hugin-CVS. These days it integrates autopano-SIFT (or autopano) and emblend. So you can drag and drop a bunch of images into hugin and get good results with the auto-function. But compiling a hugin-CVS with all this stuff (wxwindows, mono, etc) is only for the advanced user!

If you think digiKam need an own pano-plugin please open a new bug-report.

Bye

  Thorsten
Comment 3 caulier.gilles 2005-02-21 15:48:36 UTC
Hum, looking url interresing. I will looking tese points in the future

Gilles Caulier
Comment 4 Maximilian Hombsch 2005-11-10 12:04:35 UTC
The Panotools package used by clens is also capable of correcting color fringes, so future versions could be expanded by that functionality.
Later on, anti-vignetting could also benefit from lens detection through exif-data.
Comment 5 Gerhard Hoogterp 2007-01-11 13:38:21 UTC
*** This bug has been confirmed by popular vote. ***
Comment 6 Arnd Baecker 2007-04-04 08:42:17 UTC
There is an interesting thread "PTLense Database Update?"
on the hugin-ptx mailing list
http://groups.google.com/group/hugin-ptx/browse_thread/thread/f89d582e46a19744
where radial lens distortion, vignetting, TCA (and more) is discussed.

Also according to Pablo d'Angelo  """...fulla (distributed with hugin) 
is a better tool to correctimages than clens ....""".
Comment 7 Arnd Baecker 2007-05-11 01:07:36 UTC
More details on the planned Lens correction database
can be found here
http://lists.freedesktop.org/archives/create/2007-May/000743.html
Comment 8 Arnd Baecker 2007-11-29 11:03:20 UTC
Triggered by a question on the hugin-ptx mailing list a bit of an
update on the lens data base:

> >What happened to the Lens Database project?
> It's still alive here:
> http://lensfun.berlios.de/
>
> ..though I don't know much more than that.

There is a bit more information in
  http://prokoudine.info/blog/?p=65

Out of which (maybe) the most important bits are:
"While the project goes fast forward, some help would be appreciated. "
and
"We actually need a tool to create measurements from
images to fill the database. The question is whether someone with good
math background could step in and help"

This is described in more detail in:
http://lensfun.berlios.de/article.php?story=20071113085018781

My impression is that once that particular tool to
create entries for the database is operational,
anyone could pretty easily contribute.

As I also mentioned in the related 
http://bugs.kde.org/show_bug.cgi?id=143864 ,
in the end such a tool should (in addition) be integrated
in the full process of raw conversion.
Comment 9 caulier.gilles 2008-04-17 10:23:27 UTC
SVN commit 797980 by cgilles:

digiKam from trunk : LensCorrection image editor plugin : 

- Use right dialog to have fine editing Lens correction settings preview.
- Fix slots and signals names to be speedly read source code.
* Update preview with Lens type is changed.

Adrian: 

- Now plugin is suitable as well and work properlly, but of course uncomplete. 
- Bugs 143864 and 125233 will be closed when chromatic aberrations corrections will be corrected by this plugin.
- Still few camera model not supported properlly by LensFun. There is no message to gui to ping user about. 
- Sometime,  LensFun device is null when a camera model is selected. Why?
- We need to improve gui to have a manual correction: for ex, lens focal must be selectable somewhere, and certainly more settings as 
Apeture. We need to discut about.
- I think than a visual preview of distorsion using a grid is a excelent guide to users (like LensDistorsion plugin do)

CCMAIL: adrian@suse.de

BUG: 98651
CCBUGS: 143864
CCBUGS: 125233



 M  +58 -61    imageeffect_lenscorrection.cpp  
 M  +2 -2      imageeffect_lenscorrection.h  
 M  +43 -41    klensfun.cpp  
 M  +12 -10    klensfun.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=797980