Bug 97817 - hiding tabbar bigger gap (frame) around terminal
Summary: hiding tabbar bigger gap (frame) around terminal
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
: 99587 104964 126398 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-01-24 19:50 UTC by Melchior Franz
Modified: 2007-05-07 23:57 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Melchior Franz 2005-01-24 19:50:02 UTC
Version:           cvs head from today (Mon Jan 24 19:40:19 CET 2005); but also in cvs/head from 2004.12.22 (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc (GCC) 3.3.4 (pre 3.3.5 20040809) libc 2.3.3 (20040917)
OS:                Linux

I'm still using konsole -D2004.12.21.22.41.44, because since a bit later that day, konsole draws an ugly frame around the window contents. I'm using "Linux colors" scheme and no frame, no menu, no tabbar, and no slider. See here for a screenshot: http://members.aon.at/mfranz/konsole.png (6 kB) (Even the much better "before" image has these ugly white 1 pixel lines on top and bottom, but these are AFAIK caused by Qt.)

The bug started probably with this commit to konsole.cpp:

revision 1.493
date: 2004/12/22 17:38:56;  author: hindenburg;  state: Exp;  lines: +28 -124
Convert konsole to use the new ktabwidget->setTabBarHidden for
hiding the tabbar.
Comment 1 Kurt Hindenburg 2005-01-25 19:33:19 UTC
We're aware of this.  The benefits of the new code greatly outweighs a couple of extra pixels around the terminal.  Just look at the number of bug reports dealing with hiding the tabbar in versions prior to 3.4.
At some time in the future I may look at what is acutally causing this...
Comment 2 Stephan Binner 2005-02-17 14:42:07 UTC
*** Bug 99587 has been marked as a duplicate of this bug. ***
Comment 3 Carsten Schlipf 2005-02-17 17:42:32 UTC
Too bad that this bugs prevents you from using konsole as system log monitor on the background. This is a huge drawback for me and I will have to switch back to using Eterm. See my screenshot in the bug report #99587
Comment 4 Matthew S. Hallacy 2005-03-13 03:42:49 UTC
No offense guys, but this totally ruins full screen mode as well. *full screen* should mean *full screen*, not "almost full screen except for a frame that is there for no good reason"

this is definitely a regression in features, please revert whatever you broke and do it the RightWay(tm)
Comment 5 Matthew S. Hallacy 2005-03-13 03:50:04 UTC
I should mention that this also causes a gap at the bottom of my screen because the extra pixels are just enough to keep an extra line from being drawn.

screen shot is here: http://poptix.net/konsole-notreallyfullscreen.png
Comment 6 JJ Luza 2005-03-28 12:43:29 UTC
I heard on irc that this bug is solved in CVS. Is it right ? and so is there a patch I could apply to main branch somewhere ?

Thanks.
Comment 7 Melchior Franz 2005-03-28 13:31:36 UTC
No, it is not right. I just updated to HEAD, and the ugly frame is still there.
Comment 8 JJ Luza 2005-03-28 13:38:50 UTC
ok, thanks
and sorry for the mistake.
Comment 9 Kurt Hindenburg 2005-03-29 07:00:41 UTC
I'm waiting on Qt4; which is suppose to fix this issue.  We'll see what fullscreen looks like then.
Comment 10 Chris Bainbridge 2005-04-06 16:10:42 UTC
Is there any way to get rid of the one-pixel white lines at the top and bottom of the screen in the old konsole? I know Melchior suggested it's a QT issue, so is there some qt option that handles it?
Comment 11 Stephan Binner 2005-05-03 00:01:37 UTC
*** Bug 104964 has been marked as a duplicate of this bug. ***
Comment 12 Davide Minini 2005-05-03 12:18:09 UTC
how can i install an old konsole version to kill these lines using a kde-3.4.0?
is there any other possible solution? 
tnx a lot!!
 
Comment 13 Melchior Franz 2005-05-03 12:53:21 UTC
install the kdelibs development package/headers from your distribution; check out kdebase/konsole/ from KDE's cvs with -D2004.12.20; compile it; install it; 

BTW: I'm not using konsole's brain-dead "fullscreen" mode (where you have the ugly white lines and no access to the auto-hiding panel), but simply let a shell script resize the konsole window so that the window decoration and the white lines are outside the screen. Just typing "fs" in the shell does this for me. :-)
Comment 14 Davide Minini 2005-05-03 14:26:58 UTC
tnx,

i did,

export CVSROOT=:pserver:anonymous@anoncvs.kde.org:/home/kde
cvs login
cvs  co -D "December 20, 2004" kdebase/konsole

cd kdebase/konsole..

and now how can i generate the configure script?

( i tried make -f Makefile.cvs )
Comment 15 Kurt Hindenburg 2006-05-01 02:22:13 UTC
*** Bug 126398 has been marked as a duplicate of this bug. ***
Comment 16 Robert Knight 2007-05-07 23:57:17 UTC
Fixed in KDE 4.  WONTFIX for KDE 3 series unfortunately for fear of breaking existing setups.