Bug 95226 - more items on toolbar, New, Undo, Highscores, About KSame
Summary: more items on toolbar, New, Undo, Highscores, About KSame
Status: RESOLVED FIXED
Alias: None
Product: ksame
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: Mandrake RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Marcus Kreutzberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-15 22:06 UTC by Alan Horkan
Modified: 2006-11-12 20:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Horkan 2004-12-15 22:06:22 UTC
Version:            (using KDE KDE 3.2.1)
Installed from:    Mandrake RPMs
OS:                Linux

the toolbar looks a bit unbalanced with only the undo optoin on it and I would suggest also adding buttons for at least New Game and Highscores but possibly also for About KSame.  

I've never done any KDE programming before but with a little prodding and encouragement I think I could even manage to provide a patch for this is you would like.
Comment 1 Stephan Binner 2004-12-16 19:58:12 UTC
The KDE style guide says that only often used action should be on the toolbar. Dunno how "About KSame" qualifies for that.
Comment 2 Alan Horkan 2004-12-16 20:12:27 UTC
I've seen apps put a Help button on the toolbar but thinking about it a little more putting an About button on the toolbar isn't a great idea but I hope you would agree that it looks odd to have only one item on the toolbar and that it would be approrpriate to add New and Highscores.   
Comment 3 Stephan Binner 2004-12-16 20:14:16 UTC
> I've seen apps put a Help button on the toolbar

Which was wrong and which were iirc removed in a great kdegames toolbar cleanup.
Comment 4 Alan Horkan 2005-04-14 19:59:37 UTC
I see in KDE 3.4 ksame includes Undo and New on the toolbar (in that order strangely enough).  

I hope someone will confirm this request and maybe also fix the toolbars to include
New, Undo, and Highscores, preferably in that order
Comment 5 Henrique Pinto 2006-11-12 17:41:17 UTC
The order of "New" and "Undo" was changed. "Show Highscores" is not a common operation, so it won't be in the toobar.
Comment 6 Alan Horkan 2006-11-12 20:30:06 UTC
> The KDE style guide says that only often used action should be on the toolbar.

the style guide probably also recommends having at least three items because a toolbar with very little on it also looks odd
you dont want to take the rules too far and take into account how much room is available on the toolbar when you decide what is frequently used.  

I urge you to reconsider.