Bug 94913 - Usability: improve CTRL and SHIFT buttons behaviour in the download images dialog
Summary: Usability: improve CTRL and SHIFT buttons behaviour in the download images di...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Keyboard (show other bugs)
Version: 0.7.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-11 11:49 UTC by Davide Ferrari
Modified: 2022-01-02 14:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Ferrari 2004-12-11 11:49:02 UTC
Version:           0.7 (using KDE KDE 3.3.2)
Installed from:    Gentoo Packages

I'm doing only a bug report cause these are 2 issues really similiar.

CTRL issue.
I think the default in the download images selection should be as with CTRL always pressed, so every image clicked will be ADDED to the current selection (or removed if already selected) and not chosen as the only selected images. The reason I suppose it's clear: it's quite strange that you are going to download from your camera only a single photo. When you do random selections you always download more than one photo.

SHIFT issue.
If I have this "scheme" of photo
1 2 3
4 5 6
7 8 9

and I want to download images from 3 to 9, I click on 3 to select it and then SHIFT-click on 9. But what happens here? Only 3,6 and 9 are select, with 4 5 7 8 still unselected! I think that the correct behaviour should be an "horizzontal" selection.
Comment 1 Mikolaj Machowski 2004-12-11 19:01:47 UTC
> SHIFT issue.
> and I want to download images from 3 to 9, I click on 3 to select it and
> then SHIFT-click on 9. But what happens here? Only 3,6 and 9 are select,
> with 4 5 7 8 still unselected! I think that the correct behaviour should
> be an "horizzontal" selection.

This is standard Qt/KDE behavior.

Comment 2 Renchi Raju 2004-12-11 19:05:37 UTC
> This is standard Qt/KDE behavior.

which is wrong. qt/kde lays items out horizontally and it makes sense that the selection be horizontally as well. the custom iconview we have for the main window does it correctly and replacing the camera iconview with that instead of the qt one will fix the problem
Comment 3 Renchi Raju 2004-12-11 20:19:45 UTC
CVS commit by pahlibar: 


* replaced qiconview  in cameraview with thumbview. selection is now more
  sensible, horizontal layout and so horizontal selection
* eliminates flicker as well
BUG: 94913


  M +7 -14     cameraiconitem.cpp   1.8
  M +5 -7      cameraiconitem.h   1.9
  M +31 -37    cameraiconview.cpp   1.12
  M +7 -6      cameraiconview.h   1.9
  M +4 -4      cameraui.cpp   1.35
  M +0 -1      cameraui.h   1.19



Comment 4 Renchi Raju 2004-12-11 20:28:10 UTC
shift issue has been fixed. regarding your ctrl issue (i.e the "locking selection mode"), this should not be the default, as the behavior will be different than the rest of digikam. on the other hand, there is another bugreport 92351 (a wishlist) and you can vote for it.
Comment 5 Davide Ferrari 2004-12-12 10:57:35 UTC
Ok, thanks for the shift solution, I will vote for the other bug regarding control too :)