Version: 0.7 beta 1 (using KDE KDE 3.3.1) Installed from: Slackware Packages Compiler: gcc 3.3.4 OS: Linux Different date formats are used in different parts of the GUI, which is potentially confusing. For example, my KDE locale is set to Polish, which uses dd/mm/yyyy short date format. This format is also used for file and EXIF dates in the tooltips which pop up when mouse pointer is over a file in the album view, but the edit box for album's date in the album properties dialog uses mm/dd/yyyy. This is especially confusing if day<=12, since then it's hard to tell which number corresponds to the day and which one to the month. Perhaps the album properties dialog should use a date picker like the one used by korganizer (it's easier to use and automatically uses correct date format depending on locale).
CVS commit by pahlibar: use kdatepicker instead of qdateedit for locale aware date selection CCMAIL: 91597-done@bugs.kde.org M +7 -6 albumpropsedit.cpp 1.11 M +2 -2 albumpropsedit.h 1.4 --- kdeextragear-3/digikam/digikam/albumpropsedit.cpp #1.10:1.11 @@ -27,5 +27,4 @@ #include <qcheckbox.h> #include <qlineedit.h> -#include <qdatetimeedit.h> #include <qlistview.h> #include <qframe.h> @@ -37,4 +36,5 @@ #include <klocale.h> #include <kurl.h> +#include <kdatepicker.h> #include <kdeversion.h> @@ -104,6 +104,6 @@ AlbumPropsEdit::AlbumPropsEdit(PAlbum* a new QVBoxLayout( dateBox->layout(), spacingHint() ); - dateEdit_ = new QDateEdit( dateBox ); - dateBoxLayout->addWidget( dateEdit_ ); + datePicker_ = new KDatePicker( dateBox ); + dateBoxLayout->addWidget( datePicker_ ); topLayout->addWidget( dateBox ); @@ -139,5 +139,5 @@ AlbumPropsEdit::AlbumPropsEdit(PAlbum* a titleEdit_->setText( album->getTitle() ); commentsEdit_->setText( album->getCaption() ); - dateEdit_->setDate( album->getDate() ); + datePicker_->setDate( album->getDate() ); QCheckListItem *checkItem = @@ -153,5 +153,6 @@ AlbumPropsEdit::AlbumPropsEdit(PAlbum* a this, SLOT(slotDelCollection())); - resize(500, 400); + //resize(500, 400); + adjustSize(); } @@ -195,5 +196,5 @@ QString AlbumPropsEdit::comments() const QDate AlbumPropsEdit::date() const { - return dateEdit_->date(); + return datePicker_->date(); } --- kdeextragear-3/digikam/digikam/albumpropsedit.h #1.3:1.4 @@ -33,5 +33,5 @@ #include <kdialogbase.h> -class QDateEdit; +class KDatePicker; class QListView; class QLineEdit; @@ -73,5 +73,5 @@ private: QLineEdit *commentsEdit_; - QDateEdit *dateEdit_; + KDatePicker *datePicker_; QListView *collectionEdit_;