Bug 91485 - Red eye reduction - user should be told to select a part of the image
Summary: Red eye reduction - user should be told to select a part of the image
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-RedEyes (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-16 23:58 UTC by Michał Kosmulski
Modified: 2017-07-15 05:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.7.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Kosmulski 2004-10-16 23:58:28 UTC
Version:           0.7 beta 1 (using KDE KDE 3.3.0)
Compiler:          gcc 3.3.4 
OS:                Linux

In my opinion, the menu option for "Red eye reduction" should clearly indicate that it is neccessary to select a part of the image to enable it. It took me some time to find this out, at first I thaught something was broken since this option was always disabled. Perhaps the menu item should be called "Red eye reduction (create a selection to enable)" or similar.
Comment 1 caulier.gilles 2004-10-18 13:11:03 UTC
A menu entry like "Red eye reduction (create a selection to enable)" is depreceate because it's a long text !

I have added a tooltip for the "Red Eyes" menu entry and a message in the filter dialog.

Also, the handbook will be explain the way to use this filter for the users.

Gilles Caulier
Comment 2 Renchi Raju 2004-11-09 01:39:19 UTC
some actions are meant to be intuitive (unfortunately in this case its not) or learnt from experience. for eg, in a file manager a user sees the delete file option is grayed out. now he selects a file and the option becomes active. this is a result of previous experiences with other softwares. similarly in this case, you will either have to "learn" it or read the docs (which explains how it works). i can't see any other solution. gilles, please close this bug
Comment 3 caulier.gilles 2004-11-09 10:47:39 UTC
Selon Renchi Raju <renchi@pooh.tam.uiuc.edu>:

> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=91485
>
>
>
>
> ------- Additional Comments From renchi pooh tam uiuc edu  2004-11-09 01:39
> -------
> some actions are meant to be intuitive (unfortunately in this case its not)
> or learnt from experience. for eg, in a file manager a user sees the delete
> file option is grayed out. now he selects a file and the option becomes
> active. this is a result of previous experiences with other softwares.
> similarly in this case, you will either have to "learn" it or read the docs
> (which explains how it works). i can't see any other solution.

_NOTA_ : using 'What's this menu entry in Image Editor and select 'Red Eyes
correction' menu entry giving you some help !!! This is a standard way for
learning to use an GUI ! Too, read the _FULL_ manual available with 0.7.0
release !!!

> gilles, please close this bug

Yes, i will do it.




--
Gilles CAULIER
Email :    caulier.gilles@free.fr
Internet : http://caulier.gilles.free.fr

Comment 4 caulier.gilles 2004-11-09 15:19:12 UTC
*** Bug has been marked as fixed ***.
Comment 5 David Anderson 2005-01-03 16:52:51 UTC
I have a suggestion for a solution: change red-eye reduction to work in the same way as the Kodak Easyshare album application.

In this app, there is a Red-Eye button on the toolbar. When you choose it, it changes the cursor to a cross-hair. You then have to click in the red-eye area, and it fixes it.
I guess there's some auto-detection of the extent of the red-eye area going on. If that can't be done, then alternatively you could choose an area after selecting the red-eye tool (optionally popping up a message box telling you to do this, with a "Never tell me this again" checkbox).
Comment 6 caulier.gilles 2017-07-15 05:57:36 UTC
Since digiKAm 5.0, the red eyes tool from digiKam core use eyes auto-detection on face. No need a manual selection. This permit to use this tool in BQM without any user interaction.