Bug 91373 - Preserve aspect ratio of tag icons instead of stretching them to be square
Summary: Preserve aspect ratio of tag icons instead of stretching them to be square
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Themes (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-15 09:46 UTC by Michał Kosmulski
Modified: 2022-01-13 06:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Kosmulski 2004-10-15 09:46:42 UTC
Version:           0.7 beta 1 (using KDE KDE 3.3.0)
Compiler:          gcc 3.3.4 
OS:                Linux

When an image is set as a tag's icon in the tag's property dialog, it is currently always stretched to be square. Instead, original aspect ratio should be preserved - especially for 'People' tags, images used as icons are usually portraits and their aspect ratio isn't even close to 1:1, so they look distorted when resized to fit the square frame.
Comment 1 Joern Ahrens 2004-10-17 02:32:15 UTC
CVS commit by jahrens: 


Cropping tag thumbnails, so they fit the icon frame now.

Additionally:
Displaying the tag thumbnails in all dialogs now (edit/create tag dialog
and in the "Comment/Tag" dialog).

CCMAIL: 91373-done@bugs.kde.org 


  M +2 -2      album.cpp   1.10
  M +9 -32     albumfolderview.cpp   1.50
  M +84 -0     syncjob.cpp   1.3
  M +16 -1     syncjob.h   1.3
  M +6 -13     tagcreatedlg.cpp   1.6
  M +5 -6      tagspopupmenu.cpp   1.2
  M +0 -1      thumbview.cpp   1.23



Comment 2 Michał Kosmulski 2004-11-04 13:57:27 UTC
I'm using 0.7.0 rc1 now and tag icons have the correct aspect ratio, but it seems their size is always "fit to width". I happen to have some icons which are photographs in portrait mode - and in this case (height>width) the larger dimension is height, so scaling should be such that if icons are 32x32 px, images' height should be 32 and width should be scaled accordingly, preserving the aspect ratio.
Comment 3 Renchi Raju 2004-11-04 18:34:23 UTC
the tag/album icons are quite small (32x32) and in order to maximize the visual information in such a small region, the icons are cropped (in both landscape and portrait) to retain only the center of the region. this is done currently only for the tag albums, but at some point the album thumbnails will be modified to do the same. preserving the aspect ratio is not done, because the thumbnail is a representation of the tag/album and not of the actual image inside it