Bug 89716 - KMail's HTML composer messes up signature
Summary: KMail's HTML composer messes up signature
Status: RESOLVED WORKSFORME
Alias: None
Product: kmail
Classification: Applications
Component: composer (show other bugs)
Version: 1.7
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: triaged
: 93784 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-09-17 18:09 UTC by Anno V. Heimburg
Modified: 2009-08-23 18:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anno V. Heimburg 2004-09-17 18:09:43 UTC
Version:           1.7 (using KDE 3.3.0, Gentoo)
Compiler:          gcc version 3.3.4 20040623 (Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6)
OS:                Linux (i686) release 2.6.8-gentoo-r3

I have a siganture that stretches several lines, including blank lines, as such:

line1
line2

line3

All is fine and well when composing a plain-text message. However, when I use the HTML features, KMail will send the signature like this:

<p>line1</p>
<p>line2</p>
<p></p>
<p>line3</p>

which looks odd because there now is a blank line between every line of the signature. The oddity does not show up when composing, only after sending.

To reproduce:
1) Select an identity with a signature that has several lines
2) Start a new mail with some text
3) Use some html-feature, e.g. bold, on some of the text
4) Send to self
5) View as HTML

The HTML-composer is good and necessary, sadly, in times of pointy-haired-bosses. Keep up the effort!
Comment 1 Edwin Schepers 2004-11-23 21:39:30 UTC
*** Bug 93784 has been marked as a duplicate of this bug. ***
Comment 2 Martin Köbele 2005-08-08 16:11:14 UTC
I experience the same bug with current kmail (kde 3.4.1)
Comment 3 Jaime Torres 2008-09-10 18:30:25 UTC
The signature looks good in 1.10.1 (kde svn trunk 857915)
Comment 4 Michael Leupold 2008-11-07 13:06:48 UTC
I just tried an in my opinion this is still a little messy in 1.10.1.

What I did:
- Change my signature to what the reporter suggested (no html)
- Compose a new mail, change to HTML compose mode
- Append the signature
- Send the mail

What the mail looked like:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">
<html><head><meta name="qrichtext" content="1" /><style type="text/css">
p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Tahoma'; font-size:10pt; font-weight:400; font-style:normal;">
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">This is a <span style=" font-weight:600;">test</span>!</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Line 1</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Line 2</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Line 3</p></body></html>


The problem seems to be as follows:
- KMail still inserts a paragraph for every textline in the signature.
- KMail uses styles to remove the margins (= extra newlines)
=> problem: empty lines now vanish because they have no extent.
Comment 5 Thomas McGuire 2009-08-23 18:50:42 UTC
I think all problems with vanishing newlines or more newlines are fixed with KDE 4.3.1.