Bug 87671 - session cannot start when user login shell is csh like shell
Summary: session cannot start when user login shell is csh like shell
Status: RESOLVED FIXED
Alias: None
Product: kdm
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: kdm bugs tracker
URL:
Keywords:
: 90593 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-21 11:59 UTC by Kenji Miyake
Modified: 2008-05-19 17:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
more bash variable filter (745 bytes, patch)
2004-08-21 15:51 UTC, Kenji Miyake
Details
more forbidden variables come with bash 3.0 (810 bytes, patch)
2004-10-03 11:59 UTC, Kenji Miyake
Details
Fix, malformed IFS inyected via kdm Xsession script (712 bytes, patch)
2004-10-10 02:31 UTC, Jose M Rodriguez
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kenji Miyake 2004-08-21 11:59:35 UTC
Version:            (using KDE KDE 3.3.0)
Installed from:    Debian testing/unstable Packages

session cannot start when user login shell is csh like shell
Comment 1 Kenji Miyake 2004-08-21 15:51:29 UTC
Created attachment 7206 [details]
more bash variable filter
Comment 2 Kenji Miyake 2004-08-21 15:55:09 UTC
Comment on attachment 7206 [details]
more bash variable filter

solve this problem to filter more bash variable
Comment 3 Oswald Buddenhagen 2004-08-21 17:57:37 UTC
fixed in head and 3.3-branch
Comment 4 Kenji Miyake 2004-10-03 11:59:43 UTC
Created attachment 7769 [details]
more forbidden variables come with bash 3.0

this patch vs version 1.94
Comment 5 Kenji Miyake 2004-10-03 12:00:55 UTC
more forbidden variables come with bash 3.0
Comment 6 Jose M Rodriguez 2004-10-10 02:31:47 UTC
Created attachment 7829 [details]
Fix, malformed IFS inyected via kdm Xsession script

This problem is generated by /bin/sh -c set.
I think is better use /usr/bin/env, we need only the env

I think all unix have /usr/bin/env.  You can also use env.  A correct PATH must
exist here.

I think I summit this earlier,	but I'm not familiar with KDE bug system and no
confirm received.

thanks in advance,
--
  josemi
Comment 7 Oswald Buddenhagen 2004-10-12 10:46:52 UTC
*** Bug 90593 has been marked as a duplicate of this bug. ***
Comment 8 Gregorio Guidi 2004-10-12 11:41:21 UTC
Here doing "eval `env`" creates a lot of problems,
it fails on variables containing '(', ')', ';' or newlines.
Comment 9 Oswald Buddenhagen 2004-10-14 15:43:51 UTC
i replaced the 'set | grep -v "blacklist"' with a simple 'export'. this will work reliably, but needs a posix /bin/sh. as this whole startup script sourcing is a hack anyway, this is certainly acceptable.
committed to both 3.3 branch and head.