Bug 84472 - Sundays are colored the same as holidays.
Summary: Sundays are colored the same as holidays.
Status: REPORTED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: LO wishlist (vote)
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-04 21:29 UTC by Dan Bullok
Modified: 2021-04-05 10:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch to allow custom color for day of prayer/rest (8.25 KB, patch)
2004-07-05 18:16 UTC, Dan Bullok
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Bullok 2004-07-04 21:29:44 UTC
Version:           3.3 beta1 (using KDE 3.2.91 (3.3 beta1), Gentoo)
Compiler:          gcc version 3.3.2 20031218 (Gentoo Linux 3.3.2-r5, propolice-3.3-7)
OS:                Linux (i686) release 2.6.5

Sundays are always colored the same as holidays.  At least, I can't find a way to change this.  Sunday is not a holiday.  In many countries, it is a "day of rest", or whatever, but this is not universal.  I consider this a bug, not only because Sundays are not holidays, but because when a holiday falls on a Sunday, it is not visually distinct.
Comment 1 Dan Bullok 2004-07-05 18:16:12 UTC
Created attachment 6562 [details]
patch to allow custom color for day of prayer/rest

Here's a patch that fixes the problem.	Adds "Day of rest/prayer color" to
Configure KOrganizer->Colors.  Modifies KOMonthView, MonthViewCell, and
KODayMatrix to use the custom color to draw days of rest/prayer. 
Method names derived from KOGlobals::self()->calendarSystem()->weekDayOfPray().


Would you like me to commit to CVS?
Comment 2 Bram Schoenmakers 2004-07-27 16:13:19 UTC
Won't this make the monthview too colorful? I suggest to make the default pray-color 255, 100, 100 (default holiday-color), so people can optionally change it to another color.
Comment 3 Dan Bullok 2004-07-27 16:42:20 UTC
Setting default pray-color = default holiday-color makes sense.  I don't think that it's too colorful with different colors, but then, I'm wearing a rainbow-colored shirt, so I clearly don't know where to draw the line on too much color ;)
I'll leave the choosing of default pray-color to those with better taste.  All I care about is that I can change it independent of the holiday-color.
 
Comment 4 Reinhold Kainhofer 2006-11-02 19:18:41 UTC
Reassigning all KOrganizer bug reports and wishes to the newly created 
korganizer-devel mailing list.
Comment 5 Alex 2021-04-05 08:51:35 UTC
I don't think this bug exists anymore. At the moment, in the calendar, Saturdays and Sundays are both coloured red, while public holidays are boldened. I'll mark this as fixed, but feel free to reopen it if you disagree.
Comment 6 Alex 2021-04-05 10:10:25 UTC
Actually my mistake, I just happened to have some stuff that happened to be on the same day as nearby public holidays, so I thought that bold = public holiday, when it really means that you just have something on that day. And it looks like in the settings, pink is still a holiday colour, which is the same as weekend colours. But by default, public holidays aren't shown at all, and I can't work out how to show them... I'll re-mark this as reported until I understand the issue better.