Bug 83427 - QComboBox broken again insertItem no longer works.
Summary: QComboBox broken again insertItem no longer works.
Status: RESOLVED WORKSFORME
Alias: None
Product: kjsembed
Classification: Frameworks and Libraries
Component: Core (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: KJSEmbed ML
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-15 18:08 UTC by Jason Hihn
Modified: 2023-01-06 05:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
qcombobox inter item test (200 bytes, text/plain)
2004-06-15 18:13 UTC, Jason Hihn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Hihn 2004-06-15 18:08:07 UTC
Version:           CVS 6/15 (using KDE KDE 3.2.2)
Installed from:    Compiled From Sources
OS:                Linux

After getting the CVS version, and findint hat QTimeEdit and QTab change notification are supported (thank you), but QComboBox's insertItem broke. 

combo.InsertItem is not an object. Cannot be called.

It can create a QComboBox, but not put anything in it.
Comment 1 Jason Hihn 2004-06-15 18:13:53 UTC
Created attachment 6370 [details]
qcombobox inter item test
Comment 2 Richard Moore 2004-06-18 23:34:49 UTC
CVS commit by rich: 

- Reverted the updated QComboBox bindings. Looks like I need to do some
  more work on making the XSL binding generator work with the custom
  bindings code.

- Added a test case so I don't break this again.

CCMAIL: 83427-done@bugs.kde.org


  A            tests/test_qcombobox.js   1.1
  M +11 -10    qtbindings/qcombobox_imp.cpp   1.3


--- kdebindings/kjsembed/qtbindings/qcombobox_imp.cpp  #1.2:1.3
@@ -7,7 +7,8 @@
 #include <qfont.h>
 
+#include <klocale.h>
 #include <kjs/object.h>
+#include <kdebug.h>
 
-#include <kjsembed/global.h>
 #include <kjsembed/jsobjectproxy.h>
 #include <kjsembed/jsopaqueproxy.h>
@@ -86,5 +87,5 @@ void QComboBoxImp::addBindings( KJS::Exe
     QCString lastName;
 
-    while( methods[idx].id ) {
+    do {
         if ( lastName != methods[idx].name ) {
             QComboBoxImp *meth = new QComboBoxImp( exec, methods[idx].id );
@@ -93,5 +94,5 @@ void QComboBoxImp::addBindings( KJS::Exe
         }
         ++idx;
-    }
+    } while( methods[idx].id );
 
 
@@ -435,5 +436,5 @@ KJS::Value QComboBoxImp::insertStrList_7
     return KJS::Value();
     
-    const QStrList * arg0; // Dummy
+    const QStrList *arg0; // Dummy
         
     int arg1 = (args.size() >= 2) ? args[1].toInteger(exec) : -1;
@@ -452,5 +453,5 @@ KJS::Value QComboBoxImp::insertStrList_8
     return KJS::Value();
     
-    const char ** arg0; // Dummy
+    const char **arg0; // Dummy
         
     int arg1 = (args.size() >= 2) ? args[1].toInteger(exec) : -1;
@@ -756,5 +757,5 @@ KJS::Value QComboBoxImp::setValidator_34
     return KJS::Value();
     
-    const QValidator * arg0; // Dummy
+    const QValidator *arg0; // Dummy
         
       instance->setValidator( 
@@ -778,5 +779,5 @@ KJS::Value QComboBoxImp::setListBox_36( 
     return KJS::Value();
     
-    QListBox * arg0; // Dummy
+    QListBox *arg0; // Dummy
         
       instance->setListBox( 
@@ -800,5 +801,5 @@ KJS::Value QComboBoxImp::setLineEdit_38(
     return KJS::Value();
     
-    QLineEdit * arg0; // Dummy
+    QLineEdit *arg0; // Dummy
         
       instance->setLineEdit( 
@@ -842,10 +843,10 @@ KJS::Value QComboBoxImp::eventFilter_42(
     return KJS::Value();
     
-    QObject * arg0; // Dummy
+    QObject *arg0; // Dummy
         
     // Unsupported parameter QEvent *
     return KJS::Value();
     
-    QEvent * arg1; // Dummy
+    QEvent *arg1; // Dummy
         
       bool ret;


Comment 3 Jason Hihn 2004-06-21 17:18:59 UTC
Sorry Rich, but my build as of 6/21 from fresh CVS is still not working with  tests/test_qcombobox.js

Also, i seem to have found that Image is not working in Qt-Only mode as well.
"Cound not create object of type 'Image'"




Comment 4 Andrew Crouthamel 2018-11-02 04:21:27 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Andrew Crouthamel 2018-11-16 02:41:17 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 6 Justin Zobel 2022-12-07 00:23:40 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 7 Bug Janitor Service 2022-12-22 05:18:24 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Bug Janitor Service 2023-01-06 05:22:19 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!