Bug 82957 - Middle click on tab to close in Konqueror
Summary: Middle click on tab to close in Konqueror
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: tabbing (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-06 23:35 UTC by Aaron Peterson
Modified: 2008-08-17 11:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Peterson 2004-06-06 23:35:54 UTC
Version:           3.2.90 (using KDE KDE 3.2.90)
Installed from:    Gentoo Packages
Compiler:          irrelevant irrelevant
OS:                Linux

dupe of Bug 48417 to get it reopened

I believe that if I'm the owner of a bug, then I can reopen it.

I hope anyway.

Middle clicking on tabs is a grief filled event in konqueror, dialog boxes poping up left and right, or random url's getting loaded.

I will reopen this bug untill an option is created to disable this toilet worthy behavior.
Comment 1 Stephan Binner 2004-06-12 12:54:21 UTC
> I will reopen this bug untill an option is created to disable this toilet

You want your bugs.kde.org account to be disabled?
Comment 2 Aaron Peterson 2004-06-12 16:46:56 UTC
Just assign it to me if you don't want to have bugs assigned to yourself...  It's on my LONG list of todo things.

This is really important for people who are migrating from windows, because this is the default firefox behavior on windows... and it works really well.

***********
>> I will reopen this bug untill an option is created to disable this toilet 
> 
> You want your bugs.kde.org account to be disabled? 

Why not?
It will surely be a sign of an inferior process/product.

********
I spend a ridiculous amount of time fiddling with KDE and other free software, figuring out stuff, so I can migrate people to free software.

I'm a furious user, because previous bugs were marked invalid, or wont fix, or other stuff like that... and they are not invalid..  I view this feature as a MUST FIX... and I don't care if it's you guys who fix it, or me, when I get up to speed in kde/qt stuff.. and figure out what to do with the source code / actually start working an an existing product.

I'm furious, because I don't see how leaving a bug open hurts anyone.  And this enhancement request was already closed, and I couldn't join it.

********
Yes, I use inflammatory language.. I'm a bit mad!   That's what mad people do..  however, you are volunteers...  so I'll apologize...  just please keep this bug open, because it's very important to converting people to linux.
Comment 3 Stephan Binner 2004-06-12 18:27:52 UTC
> Just assign it to me if you don't want to have bugs assigned to yourself...

It was not assigned to me.

> This is really important for people who are migrating from windows, because this is the default firefox behavior on windows... and it works really well.

Linux is not Windows. And it's *not* the default Firefox behavior under Linux.

> It will surely be a sign of an inferior process/product.

Only a sign for your inferior ability to argument instead of playing games in the bug database.

> and I don't care if it's you guys who fix it, or me, when I get up to speed in kde/qt stuff

You're free to change whatever in your installation or KDE distribution what you want. But to have the vanilla KDE changed (including breaking/removing stuff for users and becoming inconsistent to a Unix paradigma) you must deliver better arguments.

> I don't see how leaving a bug open hurts anyone.  And this enhancement request

Bug? Enhancement request? You contradict yourself.

> Yes, I use inflammatory language

To discredit yourself? You succeeded.

*** This bug has been marked as a duplicate of 48417 ***

*** This bug has been marked as a duplicate of 48417 ***
Comment 4 Aaron Peterson 2004-06-12 23:57:51 UTC
Want me to open a different bug, without the inflammatory language? Or can we just ignore it. I stepped into the wrong when I confronted wrong.. and two wrongs don't make a right.   and three don't either... 

note, I appologize for the inflammatory language.  I did state my intentions to reopen this bug, and, by doing so, I hoped that I would get attention.  It's a tactic, and so far it's working.
********************

Reopen 48417 if you're going to resolve me duplicate of it, Actually, that would be really nice, because it doesn't have all the inflametory language at the top.

********************
> Linux is not Windows. And it's *not* the default Firefox behavior under Linux. 

... what's your point? ...  why does kde have "redmond look and feel options"

and the unix paradigma suck(s) in some ways... having the option to do something more efficiently / differently / better, is important.. and .. isn't configurability and customizeability part of KDE's philosophy?    If the default sucks, at least give people the ability to go to a different way of doing things.   
 
If there was a "ransom" feature in bugzilla, I'd be assigning $ to this..  please, just leave this open, or do another solution.

You see, you are in a bit of a position of power, and, the people who give you that power are the users who use your software. 

I invest a ton of time in this kde product, and I'm doing it for the benifit of all free software... I pay a lot for this kde, and I expect to be treated like it.  Note, I also value your time, and I'm willing to express such gratitude...  but i don't value your ego... when it stomps on mine.


********************
> > I don't see how leaving a bug open hurts anyone.  And this enhancement request 
> 
> Bug? Enhancement request? You contradict yourself. 

To the contrary, due to termonology from Bugzilla, Bug encompasses enhancement request, and wishlists.

Comment 5 Moritz Moeller-Herrmann 2004-07-02 12:19:18 UTC
I can confirm that this behaviour is very useful. I am forced to use Windows NT at work and use MyIE2 (an IE with tabs). On my linux machine I have dabbled with opera. Now I miss an easy way to close tabs in konqueror. I know that a middle click means paste in traditional Unix. But it also means "open in new tab/window" in the browser context.

So for usability reasons and for the benefit of peoples accustomed to other browsers, I propose closing tabs by middle click.

Pasting urls by middle click is not needed. You could paste on 
a) the address field, to get the url in the current tab. 
b) on the new tab button to get the url in a new tab.
Comment 6 Aaron Peterson 2004-08-28 20:40:48 UTC
The real point of this bug is that it is too time consuming to close tabs.

quanta plus 3.3 has an acceptable solution to this problem.

(the favicons change into [X]'s to close the tab)

i still like middle mouse click to close, however, I recognise it as a dangerous behavior, and there is no way that I want middle mouse click to close tabs by default.

Also, I don't think that opening a URL with a middle mouse click is safe enough to have a single click operation, however, it is borderline, yet I personally would rather have the tab do nothing on middle click.


Comment 7 Stephan Binner 2004-09-04 23:12:36 UTC
> quanta plus 3.3 has an acceptable solution to this problem. 
> (the favicons change into [X]'s to close the tab)

Konqueror has exactly the same as hidden configuration option.
Comment 8 Aaron Peterson 2004-09-05 04:02:01 UTC
> Konqueror has exactly the same as hidden configuration option. 

Yay!!! now.. just to find the hidden configuration options!

(to lots of ya'll) When dealing with irate yet patient customers/users/promoters  one must try to see what they mean...   There could be other solutions to the problem...

(to me.. )When being irate, try to list the actual needs, rather than what you want to have done about it...  I still find middle mouse click to close a tab as being superior.. and am hoping that there is a hidden config for that.. (at least to make middle mouse click not open random pages)
Comment 9 David 2004-09-05 09:54:06 UTC
> Konqueror has [a hidden option to change favicons into [X]'s to close the tab]  
 
It's not exactly hidden (Configure Konqueror menu, Web Behavior panel, Advanced Options button.  At least in 3.3) which is a good thing - it lets me use the browser ever - but to me at least it's also not an acceptable solution to this bug.  

People who have gotten used to middle-click to close are not necessarily all New windows refugees.  (not that it would be insufficient if they were.)  I escaped over a year ago, and I have changed some of Mozilla's middle-mouse behavior, but not all:  every time I set up Firefox or Mozilla on windows I change middlemouse.scrollbarPosition to true.  My point is that personal preferences are not limited to what the user happened to use first!

Anyway, Mozilla/Firefox/etc Have those options, and are much more usable because of them, Please do likewise with Konq, even if they are hidden away on an about:config type page or window.
Comment 10 Stephan Binner 2004-09-05 11:34:36 UTC
> Yay!!! now.. just to find the hidden configuration options!

http://wiki.kde.org/tiki-index.php?page=Secret+Config+Settings#id887861

> I still find middle mouse click to close a tab as being superior.. and am hoping that there is a hidden config for that

There isn't, but feel free to send a patch for such a hidden option.

@davidro
> It's not exactly hidden

It is because permanent close buttons are not equal to those close buttons on hover.
Comment 11 Erik Charlebois 2004-09-09 04:57:38 UTC
I'd still like to see middle click closing as an option. The problem with the X's on hover for closing is that the close button is a much smaller target than the tab (when I do want to close), and sometimes when selecting the tab I inadvertently click on the icon just as it changes into an X, closing the tab, which is downright frustrating (and has led me to disable the feature).
Comment 12 Aaron Peterson 2004-09-09 13:14:09 UTC
yes, it is a small target, and.. the delay is a touch too long.. but if it were any less, it would be too little...

The quanta style tab closing doesn't satisfy me.. it is a lot better than navigating a pull down menu, while reading conten..

I love the middle mouse click to close a tab, because I can finish reading the article, and click, and move on to the next article..

Having to go all the way to the right of the screen to click the X button, or pulling down a , way, way overloaded right click menu.. filled with really interesting buttons to accidentally click.. 

It's [the current behavior, (no middle mouse click to close is) like playing a video game.. where if i loose, I loose 5 minutes of my time... and there is nothing to win.

-AP
Comment 13 Stephan Binner 2004-09-12 23:38:07 UTC
CVS commit by binner: 

Hidden option for Bug 82957: Middle click on tab to close in Konqueror (wishlist)
CCMAIL: 82957-done@bugs.kde.org


  M +10 -0     konq_tabs.cc   1.55
  M +1 -0      konq_tabs.h   1.20


--- kdebase/konqueror/konq_tabs.cc  #1.54:1.55
@@ -121,4 +121,5 @@ KonqFrameTabs::KonqFrameTabs(QWidget* pa
   KConfigGroupSaver cs( config, QString::fromLatin1("FMSettings") );
 
+  m_MouseMiddleClickClosesTab = config->readBoolEntry( "MouseMiddleClickClosesTab", false );
   m_maxLength = config->readNumEntry("MaximumTabLength", 30);
   m_minLength = config->readNumEntry("MinimumTabLength", 3);
@@ -512,4 +513,12 @@ void KonqFrameTabs::slotMouseMiddleClick
 void KonqFrameTabs::slotMouseMiddleClick( QWidget *w )
 {
+  if ( m_MouseMiddleClickClosesTab ) {
+    if ( m_pChildFrameList->count() > 1 ) {
+      // Yes, I know this is an unchecked dynamic_cast - I'm casting sideways in a class hierarchy and it could crash one day, but I haven't checked setWorkingTab so I don't know if it can handle nulls.
+      m_pViewManager->mainWindow()->setWorkingTab( dynamic_cast<KonqFrameBase*>(w) );
+      emit ( removeTabPopup() );
+    }
+  }
+  else {
   QApplication::clipboard()->setSelectionMode( QClipboard::Selection );
   KURL filteredURL ( KonqMisc::konqFilteredURL( this, QApplication::clipboard()->text() ) );
@@ -520,4 +529,5 @@ void KonqFrameTabs::slotMouseMiddleClick
     }
   }
+  }
 }
 

--- kdebase/konqueror/konq_tabs.h  #1.19:1.20
@@ -128,4 +128,5 @@ private:
   bool m_permanentCloseButtons;
   bool m_alwaysTabBar;
+  bool m_MouseMiddleClickClosesTab;
 };
 


Comment 14 Moritz Moeller-Herrmann 2004-09-13 02:10:48 UTC
Stephan Binner wrote:
> CVS commit by binner: 
> 
> Hidden option for Bug 82957: Middle click on tab to close in Konqueror (wishlist)

MILLE GRAZIE! Cool. Das ist echt sehr sehr nett. Klasse. Freu mich schon 
auf KDE-3.4 ;-)

Comment 15 _ 2005-01-03 16:04:04 UTC
Is this implemented in KDE 3.4?
Comment 16 Stephan Binner 2005-01-06 11:23:35 UTC
Yes.
Comment 17 El E 2005-03-18 05:35:59 UTC
How do I enable this?
Comment 18 Walter 2005-03-23 22:51:38 UTC
in your ~/.kde/share/config/konquerorrc 

add: 
 
[FMSettings]
MouseMiddleClickClosesTab=true

W:-}
Comment 19 Aaron Peterson 2006-07-24 06:47:55 UTC
Thank you so much for fixing this bug!

Now, we just need it to be a visible option in the configure konqueror dialog.

The default behavior of konquor has changed so that an invalid URL now pops up in a KDE error dialog box. (different from javascript dialog box). This is a security breach, because it's easy to accidentlly paste instructions to do something wrong into the tab, and it looks official.

middle mouse click is not always paste in unix. it only makes sence to paste in a content area. In many other window managers the middle mouse button opens a menu, one different from the right click menu.

I propose that the middle click default action could come up with a menu, that says "close tab" and "load clipboard URL in this tab"

I will open a new bug for this real soon now.
Comment 20 Alexander Rødseth 2008-01-30 12:13:42 UTC
Now both this bug and bug 48417 are closed, but closing tabs with the middle mousebutton doesn't work in konqueror for KDE 4. Should I open a new wish? 
Comment 21 Aaron Peterson 2008-08-17 11:59:18 UTC
Yeah... It's gone back to the old broken behavior in KDE 4.1.0

The option is clearly there in the Konqueror settings... so it's a bug that it does nothing.

It's also a bug that it would even consider opening a rouge middle click as default behavior.

Also a bug that we can't change the status on this bug!?