Bug 79697 - after having created a Task with attendees we dont get any dialog asking if we want to send an email to the Attendees
Summary: after having created a Task with attendees we dont get any dialog asking if w...
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Cornelius Schumacher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-15 15:17 UTC by Michel de la Giroday
Modified: 2004-06-29 23:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
KOrganizer Personal settings (95.53 KB, image/png)
2004-06-24 10:02 UTC, Michel de la Giroday
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michel de la Giroday 2004-04-15 15:17:01 UTC
Version:           3.3 pre (using KDE 3.2.1, compiled sources)
Compiler:          gcc version 3.3.1 (SuSE Linux)
OS:          Linux (i686) release 2.4.21-202-default

Create a Task with Attendees - click on the Ok or Apply button - You should be asked if you want to send an email to the Attendees - after clicking yes the email should be send. ( as for when you create an Event )

We are not asked if we want to send an email to the Attendees 
No email is send.
Comment 1 Reinhold Kainhofer 2004-06-23 22:47:53 UTC
Hello Michel,
In the current version of korganizer, there is a configuration option (in the settings -> Personal -> Use Groupware communication) where you can enable/disable these questions. If you enable groupware communication, you will be asked if you want to publish the event to the attendees. This works just fine here.

Cheers,
Reinhold
Comment 2 Michel de la Giroday 2004-06-24 10:02:41 UTC
Created attachment 6452 [details]
KOrganizer Personal settings 

KOrganizer Personal Settings
Comment 3 Michel de la Giroday 2004-06-24 10:20:19 UTC
Hello Reinhold,

The comments I made to the attachment were lost for some reason, so I am adding it now.
I am using the HEAD version of kdepim updated round =08h00 (swedish time) this morning. You can see my settings on the attached png. I could reproduce the bug. We definitly are _not_ asked to send an email to the attendees of a task.
To make sure before replying to you, I asked a colleague of mine to try on his on installation which is similar to mine and he could reproduce the problem too.
So I am pretty sure this those not work. Please revert the status of the bug if 
you agree with me or ask for more details if you need to know more, I will be happy to provide it to you.

Best,
Michel
Comment 4 Reinhold Kainhofer 2004-06-24 11:19:52 UTC
Okay, Michel says it's not fixed, so reopen it...
Comment 5 Reinhold Kainhofer 2004-06-29 23:26:40 UTC
CVS commit by kainhofe: 
 
 Editing a todo in the todo editor didn't send out groupware mails. The code was just missing... Copied from the event editor (I can't move that code to a method of the KOIncidenceEditor, because differnt functions need to be called for todos than for events). 
 
 CCMAIL: 82300-done@bugs.kde.org 
 
 
   M +40 -7     kotodoeditor.cpp   1.68 
 
 
 --- kdepim/korganizer/kotodoeditor.cpp  #1.67:1.68 
 @@ -41,4 +41,5 @@ 
  #include "koprefs.h" 
  #include "koeditorattachments.h" 
 +#include "kogroupware.h" 
  #include "kodialogmanager.h" 
   
 @@ -220,13 +221,37 @@ bool KOTodoEditor::processInput() 
   
    if ( mTodo ) { 
 +    bool rc = true; 
 +    Todo *todo = mTodo->clone(); 
      Todo *oldTodo = mTodo->clone(); 
   
 -    writeTodo( mTodo ); 
 - 
 -    mTodo->setRevision( mTodo->revision() + 1 ); 
 +    kdDebug(5850) << "KOTodoEditor::processInput() write todo." << endl; 
 +    writeTodo( todo ); 
 +    kdDebug(5850) << "KOTodoEditor::processInput() event written." << endl; 
   
 +    if( *mTodo == *todo ) 
 +      // Don't do anything 
 +      kdDebug(5850) << "Todo not changed\n"; 
 +    else { 
 +      kdDebug(5850) << "Todo changed\n"; 
 +      int revision = todo->revision(); 
 +      todo->setRevision( revision + 1 ); 
 +      if( !KOPrefs::instance()->mUseGroupwareCommunication || 
 +          KOGroupware::instance()->sendICalMessage( this, 
 +                                                    KCal::Scheduler::Request, 
 +                                                    todo ) ) { 
 +        // Accept the event changes 
 +        writeTodo( mTodo ); 
 +        mTodo->setRevision( revision + 1 ); 
      emit incidenceChanged( oldTodo, mTodo ); 
 - 
 +      } else { 
 +        // Revert the changes 
 +        todo->setRevision( revision ); 
 +        rc = false; 
 +      } 
 +    } 
 +    delete todo; 
      delete oldTodo; 
 +    return rc; 
 +   
    } else { 
      mTodo = new Todo; 
 @@ -234,6 +259,13 @@ bool KOTodoEditor::processInput() 
   
      writeTodo( mTodo ); 
 +    if ( KOPrefs::instance()->mUseGroupwareCommunication ) { 
 +      if ( !KOGroupware::instance()->sendICalMessage( this, 
 +                                                      KCal::Scheduler::Request, 
 +                                                      mTodo ) ) { 
 +        kdError() << "sendIcalMessage failed." << endl; 
 +      } 
 +    } 
   
 -    if ( !mCalendar->addTodo( mTodo ) ) { 
 +    if ( !mCalendar->addIncidence( mTodo ) ) { 
        KODialogManager::errorSaveTodo( this ); 
        delete mTodo;