Bug 77486 - hardcoded strings output in crypto plugin
Summary: hardcoded strings output in crypto plugin
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: Cryptography Plugin (show other bugs)
Version: SVN
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
: 75407 96494 106417 122310 140196 149778 157787 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-03-13 16:54 UTC by Marcin Orlowski
Modified: 2009-02-02 12:45 UTC (History)
15 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch againts kopete (kde 3.5) silencing crypto-plugin (5.34 KB, patch)
2005-12-16 01:15 UTC, Florian Loitsch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Orlowski 2004-03-13 16:54:47 UTC
Version:           0.8.1 (using KDE KDE 3.2.1)
OS:          Linux

Crypto plugin spits out hardcoded messages: "Outgoing Encrypted Message:" and "Incoing Encrypted Message:" whenever such message is being sent/received. Additionally it takes a whole line for such message, thus wastes some space.

This behaviour shall either be configurable per plugin, or shomehow definable in XSLT template. I personally would like to see just "lock" icon, next to nickname instead of current message. It would suffice.
Comment 1 Olivier Goffart 2004-09-02 13:16:45 UTC
*** Bug 75407 has been marked as a duplicate of this bug. ***
Comment 2 Michel Nolard 2005-04-18 10:11:10 UTC
I think that bug #96494 is a duplicate of this one.
Comment 3 Michel Nolard 2005-04-18 10:17:33 UTC
2 things are needed :
 - XSLT style support to define the way outgoing/incoming encrypted message are displayed
 - a preview of the way an XSLT style formats encrypted message in Kopete's style chooser dialog

I think that this way, people will be able to replace heavy displays by lock icons or lighter colors :)
Comment 4 Olivier Goffart 2005-04-18 14:09:12 UTC
*** Bug 96494 has been marked as a duplicate of this bug. ***
Comment 5 Olivier Goffart 2005-05-28 17:57:24 UTC
*** Bug 106417 has been marked as a duplicate of this bug. ***
Comment 6 Antonio 2005-10-28 07:59:20 UTC
Indeed, this behavior is quite annoying and still there in Kopete 0.10.4, after 4 dupes. Additionally, the redundant messages are saved in the history, which makes it almost unusable. I guess have to go back to Psi for the time being. Please do something about it, thanks!
Comment 7 Florian Loitsch 2005-12-16 01:15:46 UTC
Created attachment 13934 [details]
patch againts kopete (kde 3.5) silencing crypto-plugin

the following patch removes the hardcoded crypto-output. A new attribute
("encrypted") is sent to the XSL styles, which can now react accordingly.
Drawback: if the style doesn't handle the 'encrypted'-attribute then encrypted
messages won't look different (I looked into it, but unless Kopete knows
about the crypto-plugin this is not easily solved).
The chosen approach actually lets any plugin add its attributes.
Comment 8 Florian Loitsch 2005-12-16 01:21:10 UTC
Forgot to say: as plugins can add their attributes, styles might not always
implement all possible plugin-attributes. I'm therefore proposing a special
tag (for instance <demo />) which is sent during the preview.
Style-programmers could then demonstrate all their capabilities (and maybe
even some personal art).
Comment 9 Thomas Beinicke 2005-12-16 09:44:15 UTC
I think in the next version of Kopete we will use the new XML+CSS style engine which works pretty good.
We can also use Adium themes then, not sure if they have an attribute for encryption in there already but it should be easy to add.
Comment 10 Charles-Hubert MOINDRON 2006-01-06 09:01:00 UTC
In my opinion, even if encrypted messages look just like regular messages, it is not a problem. There are users (like myself) that use encryption whenever possible, just because we like privacy, and so we consider encrypted message as the standard.
Of course, the suggested "encrypted" attribute is the best way of solving this :-)
Comment 11 Gregor Kališnik 2006-05-02 22:19:34 UTC
I made a patch that shows an icon and not that buggy "Encrypted message" text. But I've made it for 0.11.1. I can add it if you want...
Comment 12 Gregor Kališnik 2006-05-02 22:23:31 UTC
Ups :) never mind about me kde@florian.loitsch.com allready made the patch... (sorry for not reading the messages first...)
Comment 13 Felix Becker 2006-06-14 00:27:33 UTC
http://kde-apps.org/content/show.php?content=40844

fix for kopete 0.12.0
Comment 14 Marcin Orlowski 2006-06-18 22:31:10 UTC
Anyone with powers could please take a look a this patch? The v0.12 still spits this string out (and the bug is over 2 year old now ;(
Comment 15 Matt Rogers 2007-01-18 03:19:26 UTC
*** Bug 140196 has been marked as a duplicate of this bug. ***
Comment 16 Frank Niethardt 2007-06-09 19:01:36 UTC
Somebody of the developers still reading this? It's REALLY annoying. And I would love to see a small lock icon...
Comment 17 Charles Connell 2007-07-16 05:08:50 UTC
Fixed for trunk. We may consider doing text coloring instead of icons...less obtrusive. For now it's an icon. Someone please close bug, I don't have permission.
Comment 18 Charles Connell 2007-07-17 00:17:18 UTC
*** Bug has been marked as fixed ***.
Comment 19 Charles Connell 2007-10-15 22:33:11 UTC
*** Bug 149778 has been marked as a duplicate of this bug. ***
Comment 20 Charles Connell 2008-01-23 20:28:31 UTC
*** Bug 122310 has been marked as a duplicate of this bug. ***
Comment 21 Matt Rogers 2008-02-14 16:46:17 UTC
*** Bug 157787 has been marked as a duplicate of this bug. ***
Comment 22 Stefan Endrullis 2008-08-23 13:25:23 UTC
Since one year this issue is fixed in trunk. Does somebody know in what kopete version this issue is resolved or what version it's planned to be released. In my kopete version (0.12.7, KDE 3.5.9) it's still missing :(

Or do I have to enable a special flag before compiling kopete?
Comment 23 Christian Weiske 2009-02-02 12:45:03 UTC
Will this be released in 3.5.1x?