Bug 77140 - Allow changing the foreground/text color of buttons
Summary: Allow changing the foreground/text color of buttons
Status: RESOLVED FIXED
Alias: None
Product: kcalc
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Evan Teran
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-10 01:15 UTC by Daniel Solaz
Modified: 2019-07-10 21:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 19.08.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Solaz 2004-03-10 01:15:23 UTC
Version:           1.3.999 (using KDE 3.2.0, compiled sources)
Compiler:          gcc version 3.3.3 [FreeBSD] 20031106
OS:          FreeBSD (i386) release 5.2-RELEASE

button text is black even when using a CDE-style (white text, dark background) color scheme
this is not a widget style issue

also, if button background color can be configured, so should button text color
Comment 1 Marc Collin 2005-07-31 20:08:11 UTC
ya that could be very nice to be able to choose text color for every button
Comment 2 Vadim Rootckovsky 2010-01-03 10:04:51 UTC
Could not reproduce for KCalc 2.5, KDE 4.3.4-1
Comment 3 Christoph Feck 2010-01-04 01:22:09 UTC
The wish is still valid. You cannot change the text color, so you are limited to background/button colors that contrast well with the current text color.
Comment 4 Thiago Neves 2019-02-07 14:00:22 UTC
Version 19.03.70 has this option.

Settings > Configure KCalc > Colors
Comment 5 Christoph Feck 2019-02-07 14:03:07 UTC
Reopening because of the issue in comment #3.
Comment 6 Thiago Neves 2019-02-07 14:06:25 UTC
(In reply to Christoph Feck from comment #5)
> Reopening because of the issue in comment #3.

I see, so I'll fix this
Comment 7 Christoph Feck 2019-07-10 21:18:54 UTC
Git commit f9ac47bc0d887a3d86f7b5039902199e16e60f6c by Christoph Feck, on behalf of Thiago Neves.
Committed on 10/07/2019 at 21:14.
Pushed by cfeck into branch 'master'.

Allow changing the foreground/text color of buttons
FIXED-IN: 19.08.0

Differential Revision: https://phabricator.kde.org/D18854

M  +157  -88   colors.ui
M  +32   -1    kcalc.cpp
M  +26   -0    kcalc.kcfg
M  +15   -1    kcalc_button.cpp
M  +2    -0    kcalc_button.h

https://commits.kde.org/kcalc/f9ac47bc0d887a3d86f7b5039902199e16e60f6c