CVS commit by bhards: 

Add support for global kde options --icon and --miniicon, as requested
by bug:76367 for a few of the widgets: textbox, radiolist, checklist,
combobox, menu and password. Also added those to the test script.
Those are the easy ones. Others require a bit more fiddling.

Thanks to David Faure for the guidance on how to address this 
properly.

CCMAIL: 76367@bugs.kde.org


  M +9 -5      test   1.8
  M +8 -0      widgets.cpp   1.7


--- kdebase/kdialog/test  #1.7:1.8
@@ -27,18 +27,22 @@
 
 echo "text box:"
-./kdialog --title "This is a text box" --textbox widgets.h 400 300
+./kdialog --miniicon "about_kde" --title "This is a text box" --textbox widgets.h 400 300
 
 echo "menu:"
-./kdialog --title "This is a menu" --menu "Choose one of these" a English b German c French d Spanish
+./kdialog --miniicon "about_kde"  --title "This is a menu" --menu "Choose one of these" a English b German c French d Spanish
 
 echo "checklist:"
-./kdialog --title "This is a checklist" --checklist "Choose some of these" a English on  b German off  c French off d Spanish on
+./kdialog --miniicon "about_kde" --title "This is a checklist" --checklist "Choose some of these" a English on  b German off  c French off d Spanish on
 
 echo "radiolist:"
-./kdialog --title "This is a radiolist" --radiolist "Choose one of these" a English off b German off c French on d Spanish off
+./kdialog --miniicon "about_kde" --title "This is a radiolist" --radiolist "Choose one of these" a English off b German off c French on d Spanish off
 
 echo "combobox:"
-./kdialog --title "This is a combobox" --combobox "Pick your favorite ice-cream flavor:" "Vanilla" "Chocolate" "Strawberry" "Fudge"
+./kdialog --miniicon "about_kde" --title "This is a combobox" --combobox "Pick your favorite ice-cream flavor:" "Vanilla" "Chocolate" "Strawberry" "Fudge"
 
 echo "passivepopup:"
 ./kdialog --title "This is a passive popup" --passivepopup "It will disappear in about 10 seconds" 10
+
+echo "password:"
+./kdialog --title "This is a password dialog" --icon "desktop" --miniicon "about_kde" --password "Enter the password:"
+

--- kdebase/kdialog/widgets.cpp  #1.6:1.7
@@ -28,4 +28,5 @@
 #include <kcombobox.h>
 #include <kdebug.h>
+#include <kapplication.h>
 
 #include <qlabel.h>
@@ -47,4 +48,5 @@ bool Widgets::passwordBox(QWidget *paren
   KPasswordDialog dlg( KPasswordDialog::Password, false, 0, parent );
 
+  kapp->setTopWidget( &dlg );
   dlg.setCaption(title);
   dlg.setPrompt(text);
@@ -60,4 +62,5 @@ int Widgets::textBox(QWidget *parent, in
   KDialogBase dlg( parent, 0, true, QString::null, KDialogBase::Ok, KDialogBase::Ok );
   dlg.setCaption(title);
+  kapp->setTopWidget( &dlg );
   QTextEdit *edit = new QTextEdit( dlg.makeVBoxMainWidget() );
   edit->setReadOnly(TRUE);
@@ -91,4 +95,5 @@ bool Widgets::comboBox(QWidget *parent, 
                    KDialogBase::Ok );
 
+  kapp->setTopWidget( &dlg );
   QVBox* vbox = dlg.makeVBoxMainWidget();
 
@@ -111,4 +116,5 @@ bool Widgets::listBox(QWidget *parent, c
 
   box.setCaption(title);
+  kapp->setTopWidget( &box );
 
   for (unsigned int i = 0; i+1<args.count(); i += 2) {
@@ -135,4 +141,5 @@ bool Widgets::checkList(QWidget *parent,
 
   box.setCaption(title);
+  kapp->setTopWidget( &box );
 
   for (unsigned int i=0; i+2<args.count(); i += 3) {
@@ -176,4 +183,5 @@ bool Widgets::radioBox(QWidget *parent, 
 
   box.setCaption(title);
+  kapp->setTopWidget( &box );
 
   for (unsigned int i=0; i+2<args.count(); i += 3) {

Damn. All that crud belongs to bug:76237.

I agree. Bugzilla should be enhanced to support entering the processor/architecture type. Some types allow you to compile in 32-bits and 64-bits (like AMD64) and maybe this could also be added to options to choose from.

I can only second Jure's comment. In KOrganizer we had a crash (bug 84979), that would only happen on amd64, but the bug reporter and other people who confirmed the crash never mentioned amd64 (they were not asked for it, so why should they bother?). Of course, we were unable to reproduce the crash on our i386 machines, since we didn't have all information available. Only comment #10 of the report casually mentioned the amd64 platform for the first time.

Such a situation could be prevented in the future if the bug reporter is also asked about his hardware platform.

Cheers,
Reinhold

*** Bug 296659 has been marked as a duplicate of this bug. ***

(In reply to Oswald Buddenhagen from comment #0)
> there a too few fields and some of the existing fields are misleading. 
>  
> Platform should be the hardware platform. that matters for the fewest bugs,
> so 
> maybe it can be left out alltogether. 

Platform has been renamed to Hardware in the UI, which is a complete misunderstanding.  Hardware=openSUSE?  Thank you very much.

Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.

If this bug is no longer persisting or relevant please change the status to resolved.

🐛🧹 ⚠️ This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information, then set the bug status to REPORTED. If there is no change for at least 30 days, it will be automatically closed as RESOLVED WORKSFORME.

For more information about our bug triaging procedures, please read https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging.

Thank you for helping us make KDE software even better for everyone!

The bug exists.