Bug 72317 - Support for multiple possible entries in forms
Summary: Support for multiple possible entries in forms
Status: CONFIRMED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kwallet (show other bugs)
Version: 0.1
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
: 82965 83819 85524 92956 94598 96960 104110 120804 123622 126031 132750 148934 185102 220239 249346 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-01-10 16:31 UTC by Tom Chance
Modified: 2013-02-09 01:39 UTC (History)
25 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Enable multiple accounts in KHTML (/Konqueror) (24.03 KB, patch)
2010-07-22 20:37 UTC, Filip Brcic
Details
Save multiple web accounts in KWallet (25.15 KB, patch)
2010-08-01 17:05 UTC, Filip Brcic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Chance 2004-01-10 16:31:12 UTC
Version:            (using KDE KDE 3.1.94)
Installed from:    Gentoo Packages

I'm not sure if this is something for kwalletmanager or khtml, but I'm guessing kwallet.

There doesn't seem to be support for forms in which one might have multiple different entries. For example, when using the login form on www.gmx.net it just loads the last-used username and  password combination, even if I have several saved. It'd be good if a small dialogue popped up asking the user which values kwallet should insert into the form.
Comment 1 George Staikos 2004-01-16 15:57:39 UTC
I think this requires support in both places.  Hmm, good plan for 3.3.
Comment 2 Oded Arbel 2004-03-24 11:02:27 UTC
The main problem, IMO, is that after kwallet fills the form, it is not used again: I don't mind having to select the username field and typing in the other username - KHTML has autocompletion to aid me - but if I change the username, I expect kwallet to enter the matching password for me, like IE is doing it.

Alternatively a pop up dialog with a list of usernames to choose from, like Mozilla, will probably be a better idea.

I would really love to see it for KDE 3.3. thanks :-)
Comment 3 Jeffrey Froman 2004-07-19 16:44:49 UTC
This is a really critical one for me, and the primary reason I'm still stuck with using Mozilla for most of my work. I develop web applications for which a variety of usernames and passwords must be used to test various access levels. In general, it is an important feature for anyone who manages multiple accounts of any kind accessed from a given URL, which I suspect happens often among IT professionals (as well as avid webmail users :-)
Comment 4 George Staikos 2004-07-19 18:06:06 UTC
On Monday 19 July 2004 10:44, Jeffrey Froman wrote:
> ------- This is a really critical one for me, and the primary reason I'm
> still stuck with using Mozilla for most of my work. I develop web
> applications for which a variety of usernames and passwords must be used to
> test various access levels. In general, it is an important feature for
> anyone who manages multiple accounts of any kind accessed from a given URL,
> which I suspect happens often among IT professionals (as well as avid
> webmail users :-)

   This is mostly a KHTML integration issue, and until someone decides to do 
that, and tells me what else is needed (if anything), I guess it won't 
happen...

Comment 5 Jeffrey Froman 2004-07-20 01:04:36 UTC
On Monday 19 July 2004 09:06, George Staikos wrote:
> This is mostly a KHTML integration issue, and until someone decides to do
> that, and tells me what else is needed (if anything), I guess it won't
> happen..

Thanks, George. I'll see what I can do to alert someone in that area.

Jeffrey
Comment 6 Stephan Binner 2004-09-17 22:49:09 UTC
*** Bug 83819 has been marked as a duplicate of this bug. ***
Comment 7 George Staikos 2004-11-05 20:31:31 UTC
*** Bug 85524 has been marked as a duplicate of this bug. ***
Comment 8 George Staikos 2004-11-05 20:33:25 UTC
CVS commit by staikos: 

- Add wildcard query support to KWallet
- Add a testcase for it
- Add a new file kwallettypes for the DCOPRef additions
  (Time to move some of these into dcop/?)

Review of the interface is appreciated.  What does this get us?  Well, the
ability to find close matches for URLs.
CCBUG: 82965, 72317


  A            kwallet/client/kwallettypes.h   1.1 [LGPL (v2+)]
  M +65 -1     kio/misc/kwalletd/kwalletd.cpp   1.74
  M +4 -1      kio/misc/kwalletd/kwalletd.h   1.37
  M +23 -1     kwallet/backend/kwalletbackend.cc   1.54
  M +5 -1      kwallet/backend/kwalletbackend.h   1.21
  M +2 -2      kwallet/client/Makefile.am   1.12
  M +62 -3     kwallet/client/kwallet.cc   1.46
  M +38 -1     kwallet/client/kwallet.h   1.30
  M +17 -0     kwallet/tests/kwalletboth.cpp   1.2



Comment 9 George Staikos 2004-11-09 11:59:17 UTC
*** Bug 92956 has been marked as a duplicate of this bug. ***
Comment 10 George Staikos 2004-11-13 08:40:54 UTC
*** Bug 82965 has been marked as a duplicate of this bug. ***
Comment 11 Andreas Bayer 2004-11-21 21:23:53 UTC
If i go to gmx i would like to have a window where i can choose one combination of username and password. Perhaps a discription for each pair would be helpful.
Comment 12 George Staikos 2004-12-07 16:19:29 UTC
*** Bug 94598 has been marked as a duplicate of this bug. ***
Comment 13 George Staikos 2005-01-13 23:08:14 UTC
*** Bug 96960 has been marked as a duplicate of this bug. ***
Comment 14 Roland 2005-01-13 23:23:58 UTC
i tink, a site with more then one account must have a editchance for delete not longer existing acounts. there must be a workaround in kwallet to do this i think. and i think, there must a questin to add a new account, if an existing account is saveed in kwallet... my thinkin ;)
Comment 15 George Staikos 2005-04-18 15:15:46 UTC
*** Bug 104110 has been marked as a duplicate of this bug. ***
Comment 16 elektrohirn 2005-09-23 12:52:09 UTC
I agree. In my opinion, the behaviour should be as this:

When you're on a site the first time, enter id+pwd then you get asked if you want to store this id+pwd.

If you enter a site where kwallet has only one id+pwd, this one is filled in automatically, like today.

If you enter a site where multiple ids+pwds are stored, a popup should appear letting you choose from the exisiting ids OR let you select an entry like "leave empty", so the id+pwd fields are not auto-filled, you can enter a completely new id+pwd and you get asked if you want to store these too. Instead of a popup, which just gets in the way, perhaps the login name field could somehow extend to a multiple-line-choice field where you can select one of the entries. Pressing DEL could delete an entry (as you can also delete it in kwallet itself).

Tom
Comment 17 Tom Chance 2005-09-23 13:51:30 UTC
I rather like Firefox's method, whereby the form isn't automatically filled in when you have multiple saved entries. When you start typing in, for example, your username it drops down an auto-complete box, and selecting that then fills in the rest of the form accordingly.

My only gripe with that is that there's no indication that it has remembered your values until you start typing... but that could be done, and it's certainly nicer than a pop-up dialogue.
Comment 18 Jens 2005-09-23 21:51:04 UTC
I would like to keep the "auto fill in" method for cases where only one set of data is saved in kwallet. This way I can select a bookmark (with the mouse) and then click on "Submit" in the ready filled form (mouse) without having to use the keyboard in between (better usability).

I'd even vote for an "auto-fill+submit" so you save yourself the trouble of finding the "LOGIN" button every time (but this would probably not work with javascript based form submits).

Thanks! :)

Jens
Comment 19 Susanne Oberhauser 2005-11-28 11:07:45 UTC
is there any documentation how to use the wildcards in kwallet URLs?

Is it regular expressions?  or shell wildcards?  or something other?


thx


S.
Comment 20 George Staikos 2005-11-28 20:01:05 UTC
On Monday 28 November 2005 05:07, Susanne Oberhauser wrote:
> is there any documentation how to use the wildcards in kwallet URLs?
>
> Is it regular expressions?  or shell wildcards?  or something other?


  Shell wildcards.  It doesn't work from KHTML yet though. The UI isn't done.
Comment 21 Luk van den Borne 2006-01-21 21:30:30 UTC
What's the current status? Is it being worked on?
Comment 22 George Staikos 2006-01-26 08:43:13 UTC
*** Bug 120804 has been marked as a duplicate of this bug. ***
Comment 23 Tommi Tervo 2006-04-21 18:12:01 UTC
*** Bug 126031 has been marked as a duplicate of this bug. ***
Comment 24 Joel Webb 2006-04-21 18:22:28 UTC
I like Firefox's way of handling it as well. Another issue to this form remembering is that it should be to the domain, not the page that your on. I have started using Konqueror as my default browser rather than Firefox because of the load time and that it is accually working for some of our websites that we are developing.

1. It should remember multiple logins.
2. If there are multiple logins, user should have to start typing in username in, and a dropdown list should appear. User can select which user they want to choose.
3. Once selected, Konqueror should put in correct password which which user they chose.
4. Konqueror should also be sensitive to words like "UserID, ID" instead of just "Username"
Comment 25 Dirk Stoecker 2006-08-21 22:36:49 UTC
*** Bug 132750 has been marked as a duplicate of this bug. ***
Comment 26 Dirk Stoecker 2006-08-22 10:53:57 UTC
*** Bug 123622 has been marked as a duplicate of this bug. ***
Comment 27 Lyle G Lisle 2007-02-22 17:26:09 UTC
I agree with Mr Webb, except I'm not sure about ignoring the page.  Perhaps the page could select the default entry?

Any chance of this happening this decade? 
Comment 28 Pino Toscano 2007-08-18 00:50:06 UTC
*** Bug 148934 has been marked as a duplicate of this bug. ***
Comment 29 Philippe 2007-08-18 14:51:47 UTC
For me it's more a bug than a feature we wish. All Konqueror's interest is affected. Very boring for persons they make webdeveloppment or making moderation on a site. They must have several accounts attached on the same domaine name.
Comment 30 Mateusz Jędrasik 2008-02-16 18:31:43 UTC
are we there yet? it's another reason to use ffox for me, which is slower than konq in certain places, and takes up gtk2 into memory.
Comment 31 Maciej Pilichowski 2008-02-16 21:10:23 UTC
Obviously not, otherwise this report would be marked as FIXED. Please keep the "noise" ratio down -- thank you in advance for understanding.
Comment 32 Maciej Pilichowski 2008-09-07 15:42:41 UTC
Since the http://bugs.kde.org/show_bug.cgi?id=123622 was marked as duplicate, one note -- there should be a way to simply overwrite the old values with new ones, as well (so not only having multiple accounts).
Comment 33 Artem S. Tashkinov 2009-02-25 17:02:27 UTC
*** Bug 185102 has been marked as a duplicate of this bug. ***
Comment 34 Artem S. Tashkinov 2009-02-25 17:04:08 UTC
This bug is almost five years old ... do KDE developers use Konqueror at all? ;)
Comment 35 Christoph Feck 2009-12-27 14:03:29 UTC
*** Bug 220239 has been marked as a duplicate of this bug. ***
Comment 36 Filip Brcic 2010-07-22 20:37:47 UTC
Created attachment 49409 [details]
Enable multiple accounts in KHTML (/Konqueror)

Hi,

I tried to add support for multiple accounts and it seams I succeeded. By that I mean I successfully recompiled KDE trunk and KDE 4.3.3 (my desktop's version) with this patch and tried multiple accounts in konqueror and it works. Also, accounts are saved for the whole site, not just for the specific URL like it was the practice before.

Key features of my approach are the following:

Login page is identified by having 2 form input fields, one that is plain text field, and the other that is the password field. All other form types are dropped to old behaviour.

Login on one site is universal on that site. That means if you can login using multiple URLs (like on bugs.kde.org), the login data will be stored only once and used on all login pages.

All account usernames on the site are stored as PASSWORD value in the FormData folder of Network KWallet with the key:

accounts_SITE

All passwords are stored as PASSWORD value in the FormData folder of the Network KWallet with the key:

account_SITE_USERNAME

When you come to the SITE's login page, the system offers you to autocomplete username. When you select some username from the autocomplete list, the system autofills the correct password.

No username if prefilled, but that could be easily done (for example, by selecting the first username from the accounts list or by keeping record which username was last used).

I made this patch from the current kdelibs trunk checkout, yet I tested it also on kdelibs 4.3.3 and it applies correctly (actually it doesn't since the copyright comments don't apply correctly, but if you ignore that one error as it is only related to comments, the patch does apply). Therefore, it is safe to assume this patch works on all versions of kdelibs from 4.3.3 to trunk (possibly with some older versions, but I didn't check that).

It is worth noting that I marked all changes I made with

// BEGIN CHANGE [BRCHA]
...
// END CHANGE [BRCHA]

comments, so that the changes are easily visible and searchable on the kdelibs checkout with the applied patch.

Also, I didn't add support for KHTMLWalletQueue and marked the point with // TODO [BRCHA]. I will investigate KHTMLWalletQueue implementation and add support for that in some near future. Luckily I still didn't get to the point where WalletQueue is used, but it is probably useful to add support for that as well ;). KHTMLWalletQueue supports only Maps (as maps were the only thing used in the old approach), so I'll have to add support for Password storing.
Comment 37 Filip Brcic 2010-08-01 17:05:38 UTC
Created attachment 49730 [details]
Save multiple web accounts in KWallet

I ran this patch for a week, found some errors (1: system offered to save
password always, not only when it is new or changed + 2: you had to click on
the password field so that it gets filled with the password because I didn't
"setFocusNode" before setting the value) and fixed them. Also, I added support
for writing password values using KHTMLWalletQueue as well.

Please, test this on your systems (don't blame me if your computer explodes, although that is unlikely), and report if you encounter some error.
Comment 38 Panagiotis Papadopoulos 2010-09-11 02:44:44 UTC
*** Bug 249346 has been marked as a duplicate of this bug. ***
Comment 39 Panagiotis Papadopoulos 2010-09-11 02:51:38 UTC
Filip:

You should post your patch at the KDE reviewboard, that way it won’t be overlooked that easily :-)
http://reviewboard.kde.org/
Comment 40 meyerm 2013-02-09 01:39:15 UTC
Please see bug #143307